Fix warning IDE0008 "Use explicit type instead of var" (#97)

Author: Denis-Averin

src/Api/BarcodeApi.cs

@@ -52,7 +52,7 @@ public BarcodeApi(Configuration configuration)
         {
             _configuration = configuration;
 
-            var requestHandlers = new List<IRequestHandler>();
+            List<IRequestHandler> requestHandlers = new List<IRequestHandler>();
             switch (_configuration.AuthType)
             {
                 case AuthType.JWT:
@@ -386,7 +386,7 @@ public async Task<BarcodeResponseList> PostBarcodeRecognizeFromUrlOrContentAsync
                 .Replace(resourcePath, "\\*", string.Empty)
                 .Replace("&amp;", "&")
                 .Replace("/?", "?");
-            var formParams = new MultipartFormDataContent();
+            MultipartFormDataContent formParams = new MultipartFormDataContent();
 #pragma warning disable CS0618 // Type or member is obsolete
             resourcePath = UrlHelper.AddQueryParameterToUrl(resourcePath, "type", request.Type);
 
@@ -818,7 +818,7 @@ public async Task<BarcodeResponseList> ScanBarcodeAsync(ScanBarcodeRequest reque
                 .Replace(resourcePath, "\\*", string.Empty)
                 .Replace("&amp;", "&")
                 .Replace("/?", "?");
-            var formParams = new MultipartFormDataContent();
+            MultipartFormDataContent formParams = new MultipartFormDataContent();
 
 
 
@@ -829,7 +829,7 @@ public async Task<BarcodeResponseList> ScanBarcodeAsync(ScanBarcodeRequest reque
             }
             if (request.decodeTypes != null)
             {
-                foreach (var oneParam in request.decodeTypes)
+                foreach (DecodeBarcodeType oneParam in request.decodeTypes)
                 {
                     formParams.Add(new StringContent(oneParam.ToString()), "decodeTypes");
                 }

src/Api/FileApi.cs

@@ -52,7 +52,7 @@ public FileApi(Configuration configuration)
         {
             _configuration = configuration;
 
-            var requestHandlers = new List<IRequestHandler>();
+            List<IRequestHandler> requestHandlers = new List<IRequestHandler>();
             switch (_configuration.AuthType)
             {
                 case AuthType.JWT:
@@ -275,7 +275,7 @@ public async Task<FilesUploadResult> UploadFileAsync(UploadFileRequest request)
                 .Replace(resourcePath, "\\*", string.Empty)
                 .Replace("&amp;", "&")
                 .Replace("/?", "?");
-            var formParams = new MultipartFormDataContent();
+            MultipartFormDataContent formParams = new MultipartFormDataContent();
             resourcePath = UrlHelper.AddPathParameter(resourcePath, "path", request.path);
 #pragma warning disable CS0618 // Type or member is obsolete
             resourcePath = UrlHelper.AddQueryParameterToUrl(resourcePath, "storageName", request.storageName);

src/Api/FolderApi.cs

@@ -52,7 +52,7 @@ public FolderApi(Configuration configuration)
         {
             _configuration = configuration;
 
-            var requestHandlers = new List<IRequestHandler>();
+            List<IRequestHandler> requestHandlers = new List<IRequestHandler>();
             switch (_configuration.AuthType)
             {
                 case AuthType.JWT:

src/Api/StorageApi.cs

@@ -52,7 +52,7 @@ public StorageApi(Configuration configuration)
         {
             _configuration = configuration;
 
-            var requestHandlers = new List<IRequestHandler>();
+            List<IRequestHandler> requestHandlers = new List<IRequestHandler>();
             switch (_configuration.AuthType)
             {
                 case AuthType.JWT:

src/Aspose.BarCode.Cloud.Sdk.csproj

@@ -3,7 +3,7 @@
   <PropertyGroup>
     <TargetFrameworks>netstandard2.0</TargetFrameworks>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-    <WarningsNotAsErrors>IDE0005;IDE0008;IDE1006</WarningsNotAsErrors>
+    <WarningsNotAsErrors>IDE0005;IDE1006</WarningsNotAsErrors>
     <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
     <AnalysisLevel>latest-Recommended</AnalysisLevel>
 

src/Internal/ApiInvoker.cs

@@ -50,7 +50,7 @@ private static byte[] GetMultipartFormData(Dictionary<string, object> postParame
         {
             // TODO: stream is not disposed
             MemoryStream formDataStream = new MemoryStream();
-            var needsCrlf = false;
+            bool needsCrlf = false;
 
             if (postParameters.Count > 0)
             {
@@ -91,7 +91,7 @@ private static byte[] GetMultipartFormData(Dictionary<string, object> postParame
 
             // Dump the Stream into a byte[]
             formDataStream.Position = 0;
-            var formData = new byte[formDataStream.Length];
+            byte[] formData = new byte[formDataStream.Length];
             int _ = formDataStream.Read(formData, 0, formData.Length);
             formDataStream.Close();
 
@@ -143,14 +143,14 @@ private object InvokeInternal(
         private WebRequest PrepareRequest(string path, string method, Dictionary<string, object> formParams,
             Dictionary<string, string> headerParams, string body, string contentType)
         {
-            var request = WebRequest.Create(path);
+            WebRequest request = WebRequest.Create(path);
             request.Method = method;
 
             byte[] formData = null;
             if (formParams.Count > 0)
             {
 
-                var formDataBoundary = Guid.NewGuid().ToString();
+                string formDataBoundary = Guid.NewGuid().ToString();
                 request.ContentType = "multipart/form-data; boundary=" + formDataBoundary;
                 formData = GetMultipartFormData(formParams, formDataBoundary);
 
@@ -193,7 +193,7 @@ private WebRequest PrepareRequest(string path, string method, Dictionary<string,
 
                         if (body != null)
                         {
-                            var requestWriter = new StreamWriter(streamToSend);
+                            StreamWriter requestWriter = new StreamWriter(streamToSend);
                             requestWriter.Write(body);
                             requestWriter.Flush();
                         }
@@ -223,8 +223,8 @@ private WebRequest PrepareRequest(string path, string method, Dictionary<string,
 
         private object ReadResponse(WebRequest client, bool binaryResponse)
         {
-            var webResponse = (HttpWebResponse)GetResponse(client);
-            var resultStream = new MemoryStream();
+            HttpWebResponse webResponse = (HttpWebResponse)GetResponse(client);
+            MemoryStream resultStream = new MemoryStream();
 
             StreamHelper.CopyTo(webResponse.GetResponseStream(), resultStream);
             try
@@ -237,7 +237,7 @@ private object ReadResponse(WebRequest client, bool binaryResponse)
                     return resultStream;
                 }
 
-                using (var responseReader = new StreamReader(resultStream))
+                using (StreamReader responseReader = new StreamReader(resultStream))
                 {
                     string responseData = responseReader.ReadToEnd();
                     resultStream.Dispose();
@@ -275,7 +275,7 @@ public async Task<Stream> InvokeBinaryApiAsync(string path,
             MultipartFormDataContent formParams,
             string contentType = "application/json")
         {
-            var responseStream = await InvokeInternalAsync(path, method, true, body, headerParams, formParams, contentType)
+            Stream responseStream = await InvokeInternalAsync(path, method, true, body, headerParams, formParams, contentType)
                     as Stream;
             return responseStream;
         }
@@ -287,7 +287,7 @@ public async Task<string> InvokeApiAsync(string path,
             MultipartFormDataContent formParams,
             string contentType = "application/json")
         {
-            var response = await InvokeInternalAsync(path, method, false, body, headerParams, formParams, contentType) as string;
+            string response = await InvokeInternalAsync(path, method, false, body, headerParams, formParams, contentType) as string;
             return response;
         }
 
@@ -305,9 +305,9 @@ private async Task<object> InvokeInternalAsync(string path,
             }
             await Task.WhenAll(_requestHandlers.Select(p => p.PreparingAsync()).ToArray());
 
-            using (var client = new HttpClient())
+            using (HttpClient client = new HttpClient())
             {
-                using (var request = new HttpRequestMessage(new HttpMethod(method), path))
+                using (HttpRequestMessage request = new HttpRequestMessage(new HttpMethod(method), path))
                 {
                     if (!(formParams is null))
                     {

src/Internal/RequestHandlers/ApiExceptionRequestHandler.cs

@@ -44,10 +44,10 @@ private static void ThrowApiException(HttpWebResponse webResponse, Stream result
             try
             {
                 resultStream.Position = 0;
-                using (var responseReader = new StreamReader(resultStream))
+                using (StreamReader responseReader = new StreamReader(resultStream))
                 {
                     string responseData = responseReader.ReadToEnd();
-                    var errorResponse = (ApiErrorResponse)
+                    ApiErrorResponse errorResponse = (ApiErrorResponse)
                         SerializationHelper.Deserialize(responseData,
                             typeof(ApiErrorResponse));
                     if (string.IsNullOrEmpty(errorResponse.Error.Code))
@@ -83,10 +83,10 @@ private static async Task ThrowApiException(HttpResponseMessage response)
                 using (Stream resultStream = await response.Content.ReadAsStreamAsync())
                 {
                     resultStream.Position = 0;
-                    using (var responseReader = new StreamReader(resultStream))
+                    using (StreamReader responseReader = new StreamReader(resultStream))
                     {
                         string responseData = await responseReader.ReadToEndAsync();
-                        var errorResponse = (ApiErrorResponse)
+                        ApiErrorResponse errorResponse = (ApiErrorResponse)
                             SerializationHelper.Deserialize(responseData,
                                 typeof(ApiErrorResponse));
                         if (string.IsNullOrEmpty(errorResponse.Error.Code))

src/Internal/RequestHandlers/DebugLogRequestHandler.cs

@@ -1,4 +1,4 @@
-using System.Collections.Specialized;
+using System.Collections.Generic;
 using System.Diagnostics;
 using System.IO;
 using System.Net;
@@ -49,8 +49,8 @@ public void ProcessResponse(HttpWebResponse response, Stream resultStream)
 
         private static void LogRequest(WebRequest request, Stream streamToSend)
         {
-            var header = $"{request.Method}: {request.RequestUri}";
-            var sb = new StringBuilder();
+            string header = $"{request.Method}: {request.RequestUri}";
+            StringBuilder sb = new StringBuilder();
 
             FormatHeaders(sb, request.Headers);
             if (streamToSend != null)
@@ -65,8 +65,8 @@ private static void LogRequest(WebRequest request, Stream streamToSend)
 
         private static void LogResponse(HttpWebResponse response, Stream resultStream)
         {
-            var header = $"\r\nResponse {(int)response.StatusCode}: {response.StatusCode}";
-            var sb = new StringBuilder();
+            string header = $"\r\nResponse {(int)response.StatusCode}: {response.StatusCode}";
+            StringBuilder sb = new StringBuilder();
 
             FormatHeaders(sb, response.Headers);
             StreamHelper.CopyStreamToStringBuilder(sb, resultStream);
@@ -75,7 +75,7 @@ private static void LogResponse(HttpWebResponse response, Stream resultStream)
 
         private static void FormatHeaders(StringBuilder sb, WebHeaderCollection headerDictionary)
         {
-            foreach (var key in headerDictionary.AllKeys)
+            foreach (string key in headerDictionary.AllKeys)
             {
                 sb.Append(key);
                 sb.Append(": ");
@@ -85,7 +85,7 @@ private static void FormatHeaders(StringBuilder sb, WebHeaderCollection headerDi
 
         private static void FormatHeaders(StringBuilder sb, HttpHeaders headers)
         {
-            foreach (var header in headers)
+            foreach (KeyValuePair<string, IEnumerable<string>> header in headers)
             {
                 sb.Append(header.Key);
                 sb.Append(": ");
@@ -117,8 +117,8 @@ public async Task ProcessResponseAsync(HttpResponseMessage response)
 
         private static async Task LogRequestAsync(HttpRequestMessage request)
         {
-            var header = $"{request.Method}: {request.RequestUri}";
-            var sb = new StringBuilder();
+            string header = $"{request.Method}: {request.RequestUri}";
+            StringBuilder sb = new StringBuilder();
 
             FormatHeaders(sb, request.Headers);
             string content = await request.Content.ReadAsStringAsync();
@@ -133,8 +133,8 @@ private static async Task LogRequestAsync(HttpRequestMessage request)
 
         private static async Task LogResponseAsync(HttpResponseMessage response)
         {
-            var header = $"\r\nResponse {(int)response.StatusCode}: {response.StatusCode}";
-            var sb = new StringBuilder();
+            string header = $"\r\nResponse {(int)response.StatusCode}: {response.StatusCode}";
+            StringBuilder sb = new StringBuilder();
 
             FormatHeaders(sb, response.Headers);
             string content = await response.Content.ReadAsStringAsync();

src/Internal/RequestHandlers/JWTRequestHandler.cs

@@ -20,7 +20,7 @@ public JwtRequestHandler(Configuration configuration)
         {
             _configuration = configuration;
 
-            var requestHandlers = new List<IRequestHandler>
+            List<IRequestHandler> requestHandlers = new List<IRequestHandler>
             {
                 new DebugLogRequestHandler(_configuration),
                 new ApiExceptionRequestHandler()
@@ -88,7 +88,7 @@ public void ProcessResponse(HttpWebResponse response, Stream resultStream)
 
         private void RequestToken()
         {
-            var postData = "grant_type=client_credentials";
+            string postData = "grant_type=client_credentials";
 
             if (string.IsNullOrEmpty(_configuration.ClientId))
             {
@@ -112,15 +112,15 @@ private void RequestToken()
                 null,
                 contentType: "application/x-www-form-urlencoded");
 
-            var result = (GetAccessTokenResult)
+            GetAccessTokenResult result = (GetAccessTokenResult)
                 SerializationHelper.Deserialize(responseString, typeof(GetAccessTokenResult));
 
             _accessToken = result.AccessToken;
         }
 
         private async Task RequestTokenAsync()
         {
-            var postData = "grant_type=client_credentials";
+            string postData = "grant_type=client_credentials";
 
             if (string.IsNullOrEmpty(_configuration.ClientId))
             {
@@ -144,7 +144,7 @@ private async Task RequestTokenAsync()
                 null,
                 contentType: "application/x-www-form-urlencoded");
 
-            var result = (GetAccessTokenResult)
+            GetAccessTokenResult result = (GetAccessTokenResult)
                 SerializationHelper.Deserialize(responseString, typeof(GetAccessTokenResult));
 
             _accessToken = result.AccessToken;

src/Internal/StreamHelper.cs

@@ -13,7 +13,7 @@ public static void CopyTo(Stream source, Stream destination, int bufferSize = 81
                 source.Position = 0;
             }
 
-            var array = new byte[bufferSize];
+            byte[] array = new byte[bufferSize];
             int count;
             while ((count = source.Read(array, 0, array.Length)) != 0)
             {
@@ -23,8 +23,8 @@ public static void CopyTo(Stream source, Stream destination, int bufferSize = 81
 
         public static byte[] ReadAsBytes(Stream input)
         {
-            var buffer = new byte[16 * 1024];
-            using (var ms = new MemoryStream())
+            byte[] buffer = new byte[16 * 1024];
+            using (MemoryStream ms = new MemoryStream())
             {
                 int read;
                 while ((read = input.Read(buffer, 0, buffer.Length)) > 0)
@@ -55,10 +55,10 @@ public static void CopyStreamToStringBuilder(StringBuilder sb, Stream stream)
             }
 
             streamToRead.Seek(0, SeekOrigin.Begin);
-            var bodyReader = new StreamReader(streamToRead);
+            StreamReader bodyReader = new StreamReader(streamToRead);
             if (bodyReader.Peek() != -1)
             {
-                var content = bodyReader.ReadToEnd();
+                string content = bodyReader.ReadToEnd();
                 streamToRead.Seek(0, SeekOrigin.Begin);
 
                 sb.AppendLine("Body:");