Skip to content

Commit b24ce5a

Browse files
authored
Replace custom Pair with AbstractMap.SimpleImmutableEntry (#66)
1 parent 75dbd64 commit b24ce5a

2 files changed

Lines changed: 7 additions & 39 deletions

File tree

src/main/java/com/aspose/barcode/cloud/ApiClient.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -851,7 +851,7 @@ public String buildUrl(String path, List<Pair> queryParams, List<Pair> collectio
851851
url.append("&");
852852
}
853853
String value = parameterToString(param.getValue());
854-
url.append(escapeString(param.getName()))
854+
url.append(escapeString(param.getKey()))
855855
.append("=")
856856
.append(escapeString(value));
857857
}
@@ -870,7 +870,7 @@ public String buildUrl(String path, List<Pair> queryParams, List<Pair> collectio
870870
}
871871
String value = parameterToString(param.getValue());
872872
// collection query parameter value already escaped as part of parameterToPairs
873-
url.append(escapeString(param.getName())).append("=").append(value);
873+
url.append(escapeString(param.getKey())).append("=").append(value);
874874
}
875875
}
876876
}

src/main/java/com/aspose/barcode/cloud/Pair.java

Lines changed: 5 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -25,44 +25,12 @@
2525

2626
package com.aspose.barcode.cloud;
2727

28-
/** Name-value pair. */
29-
public class Pair {
30-
private String name = "";
31-
private String value = "";
28+
import java.util.AbstractMap;
3229

33-
public Pair(String name, String value) {
34-
setName(name);
35-
setValue(value);
36-
}
37-
38-
private void setName(String name) {
39-
if (isNullOrEmpty(name)) {
40-
return;
41-
}
42-
43-
this.name = name;
44-
}
45-
46-
private void setValue(String value) {
47-
if (isNullOrEmpty(value)) {
48-
return;
49-
}
50-
51-
this.value = value;
52-
}
53-
54-
public String getName() {
55-
return this.name;
56-
}
57-
58-
public String getValue() {
59-
return this.value;
60-
}
30+
/** Key-value pair. */
31+
public class Pair extends AbstractMap.SimpleImmutableEntry<String, String> {
6132

62-
private static boolean isNullOrEmpty(String arg) {
63-
if (arg == null) {
64-
return true;
65-
}
66-
return arg.trim().isEmpty();
33+
public Pair(String key, String value) {
34+
super(key, value);
6735
}
6836
}

0 commit comments

Comments
 (0)