Update DevTools to revision 202726.

Author: auchenberg

app/devtools/BUILD.gn

@@ -17,13 +17,11 @@ devtools_core_files =
   gypi_values.devtools_bindings_js_files +
   gypi_values.devtools_common_js_files +
   gypi_values.devtools_components_js_files +
-  gypi_values.devtools_devtools_app_js_files +
+  gypi_values.devtools_emulation_js_files +
   gypi_values.devtools_host_js_files +
   gypi_values.devtools_main_js_files +
   gypi_values.devtools_platform_js_files +
-  gypi_values.devtools_screencast_js_files +
   gypi_values.devtools_sdk_js_files +
-  gypi_values.devtools_toolbox_js_files +
   gypi_values.devtools_toolbox_bootstrap_js_files +
   gypi_values.devtools_ui_js_files +
   gypi_values.devtools_workspace_js_files +
@@ -34,20 +32,28 @@ devtools_extensions_js_files = gypi_values.devtools_extensions_js_files -
   gypi_values.devtools_extension_api_files
 
 devtools_modules_js_files =
+  gypi_values.devtools_accessibility_js_files +
   gypi_values.devtools_audits_js_files +
+  gypi_values.devtools_animation_js_files +
+  gypi_values.devtools_cm_modes_js_files +
   gypi_values.devtools_components_lazy_js_files +
   gypi_values.devtools_console_js_files +
   gypi_values.devtools_devices_js_files +
+  gypi_values.devtools_diff_js_files +
   gypi_values.devtools_elements_js_files +
+  gypi_values.devtools_emulated_devices_js_files +
   devtools_extensions_js_files +
   gypi_values.devtools_heap_snapshot_worker_js_files +
   gypi_values.devtools_layers_js_files +
   gypi_values.devtools_network_js_files +
   gypi_values.devtools_profiler_js_files +
   gypi_values.devtools_promises_js_files +
   gypi_values.devtools_resources_js_files +
+  gypi_values.devtools_security_js_files +
+  gypi_values.devtools_screencast_js_files +
   gypi_values.devtools_script_formatter_worker_js_files +
   gypi_values.devtools_settings_js_files +
+  gypi_values.devtools_snippets_js_files +
   gypi_values.devtools_source_frame_js_files +
   gypi_values.devtools_sources_js_files +
   gypi_values.devtools_temp_storage_shared_worker_js_files +
@@ -60,7 +66,7 @@ all_devtools_files =
   devtools_core_files +
   gypi_values.devtools_module_json_files +
   devtools_modules_js_files +
-  gypi_values.devtools_uglify_files
+  gypi_values.devtools_acorn_files
 
 # FIXME: Fix the generate_devtools_grd.py script to accept trailing slashes.
 resources_out_dir_no_slash = "$root_out_dir/resources/inspector"
@@ -76,8 +82,10 @@ generated_scripts = [
 visibility = [ "//third_party/WebKit/*" ]
 
 group("devtools_frontend_resources") {
-  deps = [
+  public_deps = [
+    ":copy_compatibility_scripts",
     ":copy_inspector_images",
+    ":copy_emulated_devices_images",
     ":devtools_extension_api",
     ":frontend_protocol_sources",
     ":supported_css_properties",
@@ -87,63 +95,73 @@ group("devtools_frontend_resources") {
   if (!debug_devtools) {
     # This overwrites application-specific core CSS (devtools.css),
     # and thus should be guarded out in Debug builds.
-    deps += [
-      ":concatenated_devtools_css",
+    public_deps += [
       ":concatenated_inspector_css",
       ":concatenated_toolbox_css",
     ]
   }
 }
 
+copy("copy_compatibility_scripts") {
+  sources = gypi_values.devtools_compatibility_scripts
+  outputs = [ resources_out_dir + "{{source_file_part}}" ]
+}
+
 copy("copy_inspector_images") {
   sources = gypi_values.devtools_image_files
   outputs = [ resources_out_dir + "Images/{{source_file_part}}" ]
 }
 
+copy("copy_emulated_devices_images") {
+  sources = gypi_values.devtools_emulated_devices_images
+  outputs = [ resources_out_dir + "emulated_devices/{{source_file_part}}" ]
+}
+
 action("generate_devtools_grd") {
   script = "scripts/generate_devtools_grd.py"
 
   deps = [ ":devtools_frontend_resources" ]
   static_files_list = "$target_gen_dir/devtools_static_grd_files.tmp"
-  inputs = gypi_values.devtools_image_files + all_devtools_files + [
-    static_files_list
-  ]
+  inputs = gypi_values.devtools_image_files + all_devtools_files
+  inputs += gypi_values.devtools_compatibility_scripts
+  inputs += [ static_files_list ]
 
   static_files = []
 
   if (debug_devtools) {
     # Debug: all files are picked as-is.
     generated_files = generated_scripts + [
-      resources_out_dir + "devtools.html",
       resources_out_dir + "inspector.html",
       resources_out_dir + "toolbox.html",
     ]
     static_files += all_devtools_files + [ "front_end/Runtime.js" ]
   } else {
-    # Release: pick compiled files and lazy-loaded CSS.
+    # Release: pick compiled non-remote files and lazy-loaded CSS.
     generated_files = [
-      resources_out_dir + "devtools.css",
-      resources_out_dir + "devtools.html",
-      resources_out_dir + "devtools.js",
       resources_out_dir + "inspector.css",
       resources_out_dir + "inspector.html",
       resources_out_dir + "inspector.js",
       resources_out_dir + "toolbox.css",
       resources_out_dir + "toolbox.html",
       resources_out_dir + "toolbox.js",
+      resources_out_dir + "accessibility_module.js",
       resources_out_dir + "audits_module.js",
+      resources_out_dir + "animation_module.js",
       resources_out_dir + "components_lazy_module.js",
       resources_out_dir + "console_module.js",
       resources_out_dir + "devices_module.js",
+      resources_out_dir + "diff_module.js",
       resources_out_dir + "elements_module.js",
       resources_out_dir + "heap_snapshot_worker_module.js",
       resources_out_dir + "layers_module.js",
       resources_out_dir + "network_module.js",
       resources_out_dir + "profiler_module.js",
       resources_out_dir + "promises_module.js",
       resources_out_dir + "resources_module.js",
+      resources_out_dir + "security_module.js",
       resources_out_dir + "script_formatter_worker_module.js",
       resources_out_dir + "settings_module.js",
+      resources_out_dir + "snippets_module.js",
       resources_out_dir + "source_frame_module.js",
       resources_out_dir + "sources_module.js",
       resources_out_dir + "temp_storage_shared_worker_module.js",
@@ -167,7 +185,8 @@ action("generate_devtools_grd") {
   ]
 
   args = rebase_path(generated_files, root_build_dir) +
-    rebase_path(generated_files, root_build_dir) + [
+    rebase_path(generated_files, root_build_dir) +
+    rebase_path(gypi_values.devtools_compatibility_scripts, root_build_dir) + [
     "--static_files_list", rebase_path(static_files_list, root_build_dir),
     "--relative_path_dirs" ] +
     rebase_path(relative_path_dirs, root_build_dir) + [
@@ -217,56 +236,61 @@ action("build_applications") {
   ]
 
   inputs = helper_scripts + all_devtools_files + generated_scripts + [
-    "front_end/devtools.html",
     "front_end/inspector.html",
     "front_end/toolbox.html",
   ]
 
   outputs = [
-    resources_out_dir + "devtools.html",
     resources_out_dir + "inspector.html",
     resources_out_dir + "toolbox.html",
   ]
 
+  deps = [
+    ":supported_css_properties",
+    ":frontend_protocol_sources",
+  ]
+
   if (debug_devtools) {
-    deps = [ ":copy_debug_non_modules" ]
+    deps += [ ":copy_debug_non_modules" ]
 
     debug_mode = "1"
   } else {
     outputs += [
-      resources_out_dir + "devtools.js",
       resources_out_dir + "inspector.js",
       resources_out_dir + "toolbox.js",
+      resources_out_dir + "accessibility_module.js",
       resources_out_dir + "audits_module.js",
+      resources_out_dir + "animation_module.js",
+      resources_out_dir + "cm_modes_module.js",
       resources_out_dir + "components_lazy_module.js",
       resources_out_dir + "console_module.js",
       resources_out_dir + "devices_module.js",
+      resources_out_dir + "diff_module.js",
       resources_out_dir + "elements_module.js",
+      resources_out_dir + "emulated_devices_module.js",
       resources_out_dir + "heap_snapshot_worker_module.js",
       resources_out_dir + "layers_module.js",
       resources_out_dir + "network_module.js",
       resources_out_dir + "profiler_module.js",
       resources_out_dir + "promises_module.js",
       resources_out_dir + "resources_module.js",
+      resources_out_dir + "security_module.js",
+      resources_out_dir + "screencast_module.js",
       resources_out_dir + "script_formatter_worker_module.js",
       resources_out_dir + "settings_module.js",
+      resources_out_dir + "snippets_module.js",
       resources_out_dir + "source_frame_module.js",
       resources_out_dir + "sources_module.js",
       resources_out_dir + "temp_storage_shared_worker_module.js",
       resources_out_dir + "timeline_module.js",
       resources_out_dir + "ui_lazy_module.js",
     ]
 
-    deps = [
-      ":supported_css_properties",
-      ":frontend_protocol_sources",
-    ]
-
     debug_mode = "0"
   }
 
   args = [
-    "devtools", "inspector", "toolbox",
+    "inspector", "toolbox",
     "--input_path", rebase_path("front_end", root_build_dir),
     "--output_path", rebase_path(resources_out_dir, root_build_dir),
     "--debug", debug_mode
@@ -276,9 +300,9 @@ action("build_applications") {
 if (debug_devtools) {
   # Debug: copy non-module directories and core into resources_out_dir as-is.
   group("copy_debug_non_modules") {
-    deps = [
+    public_deps = [
       ":copy_runtime_core",
-      ":copy_uglify_js_files",
+      ":copy_acorn_js_files",
       ":copy_codemirror_files",
     ]
   }
@@ -289,9 +313,9 @@ if (debug_devtools) {
     outputs = [ resources_out_dir + "/{{source_file_part}}" ]
   }
 
-  copy("copy_uglify_js_files") {
-    sources = gypi_values.devtools_uglify_files
-    outputs = [ resources_out_dir + "UglifyJS/{{source_file_part}}" ]
+  copy("copy_acorn_js_files") {
+    sources = gypi_values.devtools_acorn_files
+    outputs = [ resources_out_dir + "acorn/{{source_file_part}}" ]
   }
 
   copy("copy_codemirror_files") {
@@ -320,10 +344,6 @@ if (!debug_devtools) {
     }
   }
 
-  concatenate_css("concatenated_devtools_css") {
-    app_name = "devtools"
-  }
-
   concatenate_css("concatenated_inspector_css") {
     app_name = "inspector"
   }

app/devtools/Inspector-0.1.json

@@ -1282,7 +1282,7 @@
                 "id": "PseudoIdRules",
                 "type": "object",
                 "properties": [
-                    { "name": "pseudoId", "type": "integer", "description": "Pseudo style identifier (see <code>enum PseudoId</code> in <code>LayoutStyleConstants.h</code>)."},
+                    { "name": "pseudoId", "type": "integer", "description": "Pseudo style identifier (see <code>enum PseudoId</code> in <code>ComputedStyleConstants.h</code>)."},
                     { "name": "rules", "type": "array", "items": { "$ref": "CSSRule" }, "description": "CSS rules applicable to the pseudo style."}
                 ],
                 "description": "CSS rule collection for a single pseudo style."

app/devtools/Inspector-1.0.json

@@ -1596,7 +1596,7 @@
                 "id": "PseudoIdRules",
                 "type": "object",
                 "properties": [
-                    { "name": "pseudoId", "type": "integer", "description": "Pseudo style identifier (see <code>enum PseudoId</code> in <code>LayoutStyleConstants.h</code>)."},
+                    { "name": "pseudoId", "type": "integer", "description": "Pseudo style identifier (see <code>enum PseudoId</code> in <code>ComputedStyleConstants.h</code>)."},
                     { "name": "rules", "type": "array", "items": { "$ref": "CSSRule" }, "description": "CSS rules applicable to the pseudo style."}
                 ],
                 "description": "CSS rule collection for a single pseudo style."

app/devtools/Inspector-1.1.json

@@ -2337,7 +2337,7 @@
                 "id": "PseudoIdMatches",
                 "type": "object",
                 "properties": [
-                    { "name": "pseudoId", "type": "integer", "description": "Pseudo style identifier (see <code>enum PseudoId</code> in <code>LayoutStyleConstants.h</code>)."},
+                    { "name": "pseudoId", "type": "integer", "description": "Pseudo style identifier (see <code>enum PseudoId</code> in <code>ComputedStyleConstants.h</code>)."},
                     { "name": "matches", "type": "array", "items": { "$ref": "RuleMatch" }, "description": "Matches of CSS rules applicable to the pseudo style."}
                 ],
                 "description": "CSS rule collection for a single pseudo style."

app/devtools/OWNERS

@@ -1,5 +1,5 @@
+dgozman@chromium.org
 pfeldman@chromium.org
-vsevik@chromium.org
 yurys@chromium.org
-per-file devtools.gyp*=apavlov@chromium.org
-per-file BUILD.gn=apavlov@chromium.org
+per-file devtools.gyp*=sergeyv@chromium.org
+per-file BUILD.gn=sergeyv@chromium.org

app/devtools/PRESUBMIT.py

@@ -42,14 +42,13 @@ def _CompileDevtoolsFrontend(input_api, output_api):
     # FIXME: The compilation does not actually run if injected script-related files
     # have changed, as they reside in core/inspector, which is not affected
     # by this presubmit.
-    # Once this is fixed, InjectedScriptHost.idl and JavaScriptCallFrame.idl
+    # Once this is fixed, injected_script_externs.js
     # should be added to the list of triggers.
     devtools_front_end = input_api.os_path.join("devtools", "front_end")
     if (any(devtools_front_end in path for path in local_paths) or
         any("protocol.json" in path for path in local_paths) or
         any("compile_frontend.py" in path for path in local_paths) or
-        any("InjectedScriptSource.js" in path for path in local_paths) or
-        any("InjectedScriptCanvasModuleSource.js" in path for path in local_paths)):
+        any("InjectedScriptSource.js" in path for path in local_paths)):
         lint_path = input_api.os_path.join(input_api.PresubmitLocalPath(),
             "scripts", "compile_frontend.py")
         out, _ = input_api.subprocess.Popen(
@@ -115,11 +114,25 @@ def _CheckOptimizePNGHashes(input_api, output_api):
     return [output_api.PresubmitError(error_message)]
 
 
+def _CheckCSSViolations(input_api, output_api):
+    results = []
+    for f in input_api.AffectedFiles(include_deletes=False):
+        if not f.LocalPath().endswith(".css"):
+            continue
+        for line_number, line in f.ChangedContents():
+            if "/deep/" in line:
+                results.append(output_api.PresubmitError(("%s:%d uses /deep/ selector") % (f.LocalPath(), line_number)))
+            if "::shadow" in line:
+                results.append(output_api.PresubmitError(("%s:%d uses ::shadow selector") % (f.LocalPath(), line_number)))
+    return results
+
+
 def CheckChangeOnUpload(input_api, output_api):
     results = []
     results.extend(_CompileDevtoolsFrontend(input_api, output_api))
     results.extend(_CheckConvertSVGToPNGHashes(input_api, output_api))
     results.extend(_CheckOptimizePNGHashes(input_api, output_api))
+    results.extend(_CheckCSSViolations(input_api, output_api))
     return results