Skip to content

Commit 8020f0a

Browse files
committed
fixing type issues breaking npm build
1 parent 5f40148 commit 8020f0a

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

backend/src/controllers/target.controller.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,10 @@ class TargetValuesController {
4141
includeLogsInResponse
4242
);
4343

44-
return res.status(200).json(result);
44+
res.status(200).json(result);
4545
} catch (error) {
4646
console.error('Error calculating target values:', error);
47-
return res.status(500).json({ error: 'Failed to calculate target values' });
47+
res.status(500).json({ error: 'Failed to calculate target values' });
4848
}
4949
}
5050
}

backend/src/controllers/teams.controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class TeamsController {
3434
try {
3535
const { login } = req.params;
3636
const exact = req.query.exact === 'true';
37-
const member = await teamsService.getMemberByLogin(login, exact);
37+
const member = await teamsService.getMemberByLogin(login);
3838
if (member) {
3939
res.json(member);
4040
} else {

backend/src/controllers/webhook.controller.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ export const setupWebhookListeners = (github: App) => {
2020
}
2121

2222
const survey = await surveyService.createSurvey({
23+
id: crypto.randomUUID(), // Or some other unique ID generation
2324
status: 'pending',
2425
hits: 0,
2526
userId: payload.pull_request.user.login,

0 commit comments

Comments
 (0)