Refactor logger configuration and simplify log rotation settings

Author: austenstone

backend/src/services/logger.ts

@@ -2,7 +2,6 @@ import bunyan from 'bunyan';
 import { existsSync, mkdirSync, readFileSync } from 'fs';
 import { Request, Response, NextFunction } from 'express';
 import path, { dirname } from 'path';
-import process from 'node:process';
 import { fileURLToPath } from 'url';
 
 const __filename = fileURLToPath(import.meta.url);
@@ -18,7 +17,7 @@ const packageJson = JSON.parse(readFileSync(packageJsonPath, 'utf8'));
 export const appName = packageJson.name || 'GitHub Value';
 
 const period = process.env.LOG_ROTATION_PERIOD || '1d';
-const count = parseInt(process.env.LOG_ROTATION_COUNT ?? '14');
+const count = process.env.LOG_ROTATION_COUNT ? parseInt(process.env.LOG_ROTATION_COUNT) : 14;
 
 const logger = bunyan.createLogger({
   name: appName,
@@ -47,15 +46,15 @@ const logger = bunyan.createLogger({
     {
       path: `${logsDir}/error.json`,
       type: 'rotating-file',
-      period: period,
-      count: count,
+      period,
+      count,
       level: 'error'
     },
     {
       path: `${logsDir}/debug.json`,
       type: 'rotating-file',
-      period: period,
-      count: count,
+      period,
+      count,
       level: 'debug'
     }
   ]

compose.yml

@@ -10,8 +10,6 @@ services:
       NODE_ENV: production
       NODE_OPTIONS: --enable-source-maps
       MONGODB_URI: mongodb://root:octocat@mongo:27017
-    env_file:
-      - backend/.env
     depends_on:
       mongo:
         condition: service_healthy