lint

Author: austenstone

.vscode/settings.json

@@ -0,0 +1,3 @@
+{
+  "eslint.workingDirectories": [ "./backend", "./frontend" ],
+}

backend/src/app.ts

@@ -92,7 +92,7 @@ class App {
           await TargetValuesService.initialize();
           logger.info('Targets initialized');
         } catch (error) {
-          logger.warn('GitHub App failed to connect', (error as any)?.message || error);
+          logger.warn('GitHub App failed to connect', error instanceof Error ? error.message : String(error));
         }
 
       }

backend/src/controllers/api-docs.controller.ts

@@ -982,7 +982,7 @@ class ApiDocsController {
       }
 
       res.status(200).json(openApiSpec);
-    } catch (error) {
+    } catch {
       res.status(500).json({ error: "Failed to retrieve API documentation" });
     }
   }

backend/src/controllers/teams.controller.ts

@@ -33,7 +33,6 @@ class TeamsController {
   async getMemberByLogin(req: Request, res: Response): Promise<void> {
     try {
       const { login } = req.params;
-      const exact = req.query.exact === 'true';
       const member = await teamsService.getMemberByLogin(login);
       if (member) {
         res.json(member);

backend/src/services/seats.service.ts

@@ -27,22 +27,11 @@ type MemberDailyActivity = {
   };
 };
 
-interface ActivityTotalDocument {
-  org: string;
-  date: Date;
-  assignee: mongoose.Types.ObjectId;
-  assignee_id: number;
-  assignee_login: string;
-  total_active_time_ms?: number;
-  last_activity_at?: Date;
-  last_activity_editor?: string;
-}
-
 interface MemberDocument {
   _id: mongoose.Types.ObjectId;
   id: number;
   login: string;
-  [key: string]: any; // For other properties
+  // [key: string]: any; // For other properties
 }
 
 class SeatsService {
@@ -129,7 +118,7 @@ class SeatsService {
     }
 
     // Build query with date range filtering if provided
-    const query: mongoose.FilterQuery<any> = {
+    const query: mongoose.FilterQuery<SeatType> = {
       assignee: member._id
     };
 
@@ -184,7 +173,7 @@ class SeatsService {
 
           if (!member) {
             // Try case-insensitive search as a fallback
-            const regex = new RegExp(`^${identifierString.replace(/[-\/\\^$*+?.()|[\]{}]/g, '\\$&')}$`, 'i');
+            const regex = new RegExp(`^${identifierString.replace(/[-/\\^$*+?.()|[\]{}]/g, '\\$&')}$`, 'i');
             const memberCaseInsensitive = await Member.findOne({ 
               login: regex
             }).lean() as MemberDocument | null;
@@ -203,22 +192,17 @@ class SeatsService {
             // Now TypeScript knows member has these properties
             numericId = member.id;
           }
-        } catch (memberLookupError: unknown) {
-          // Properly type the error
+        } catch {
           return []; // Return empty array on error
         }
       } else {
         numericId = Number(identifier);
-        //console.log(`Using numeric ID directly: ${numericId}`);
       }
 
-      // Build query
-      const query: Record<string, any> = { assignee_id: numericId };
+      const query: mongoose.FilterQuery<SeatType> = { assignee_id: numericId };
 
-      // Add filters
       if (params.org) {
         query.org = params.org;
-       // console.log(`Added org filter: ${params.org}`);
       }
 
       if (params.since || params.until) {

backend/src/services/smee.ts

@@ -1,6 +1,6 @@
 import logger from "./logger.js";
 import Client from "smee-client";
-import { EventSource } from "eventsource";
+import { ErrorEvent, EventSource } from "eventsource";
 
 export interface WebhookServiceOptions {
   url?: string,
@@ -61,7 +61,7 @@ class WebhookService {
         });
         this.eventSource = await this.smee.start();
         // also catch any lower‑level EventSource errors
-        this.eventSource.addEventListener('error', (err: any) => {
+        this.eventSource.addEventListener('error', (err: ErrorEvent) => {
           const m = err?.message || err;
           if (typeof m === 'string' && m.includes('ECONNRESET')) {
             logger.warn('Smee EventSource', 'read ECONNRESET, reconnecting');

backend/src/services/survey.service.ts

@@ -69,18 +69,18 @@ class SurveyService {
   /**
    * Get all surveys based on filtering criteria
    */
-  async getAllSurveys(params: {
-    org?: string;
-    team?: string;
-    reasonLength?: string;
-    since?: string;
-    until?: string;
-    status?: string;
-    userId?: string;
-  }) {
+    async getAllSurveys(params: {
+      org?: string;
+      team?: string;
+      reasonLength?: string;
+      since?: string;
+      until?: string;
+      status?: string;
+      userId?: string;
+    }) {
     const { org, team, reasonLength, since, until, status, userId } = params;
 
-    const dateFilter: mongoose.FilterQuery<any> = {};
+    const dateFilter: mongoose.FilterQuery<SurveyType> = {};
 
     // Validate the date strings before creating Date objects
     if (since) {

backend/src/services/target-calculation-service.ts

@@ -1,4 +1,4 @@
-import settingsService, { SettingsType } from './settings.service.js';
+import { SettingsType } from './settings.service.js';
 import adoptionService, { AdoptionType } from './adoption.service.js';
 import metricsService from './metrics.service.js';
 import { MetricDailyResponseType } from "../models/metrics.model.js";
@@ -48,25 +48,6 @@ interface Targets {
   [key: string]: Record<string, Target>;
 }
 
-// More specific typed interfaces for metrics data
-interface MetricsData {
-  copilot_ide_code_completions?: {
-    total_code_suggestions: number;
-    total_engaged_users: number;   // NEW
-  };
-  copilot_ide_chat?: {
-    total_chats: number;
-  };
-  copilot_dotcom_chat?: {          // NEW
-    total_chats: number;
-  };
-  copilot_dotcom_pull_requests?: {
-    total_pr_summaries_created: number;
-  };
-  total_active_users: number;
-  total_engaged_users?: number;    // NEW (top-level, used in debug log)
-}
-
 export class TargetCalculationService {
   // Class variables to store fetched data
   settings!: SettingsType;
@@ -841,7 +822,6 @@ RESULT:
   calculateProductivityOrThroughputBoostPercent(): Target {
     const adoptedDevs = this.calculateAdoptedDevs().current;
     const weeklyTimeSavedHrs = this.calculateWeeklyTimeSavedHrs().current;
-const monthlyTimeSavings = adoptedDevs * weeklyTimeSavedHrs * 4; // Assuming 4 weeks per month
 
     // Convert hours per year to number
     const hoursPerYear = typeof this.settings.hoursPerYear === 'number' ? this.settings.hoursPerYear : 2000;

backend/src/services/target.service.ts

@@ -1,6 +1,5 @@
 import mongoose from 'mongoose';
-import adoptionService, { AdoptionType } from './adoption.service.js';
-import app from '../index.js';
+import { AdoptionType } from './adoption.service.js'
 import { SettingsType } from './settings.service.js';
 import { TargetCalculationService } from './target-calculation-service.js';