cleanup

Author: austenstone

backend/index.js

@@ -18,18 +18,16 @@ class SeatsController {
     const { since, until, org } = req.query as { [key: string]: string | undefined };
 
     try {
-      // Create params object with all query parameters
-      const params = { since, until, org };
-      
+      const sanitizedOrg = typeof org === 'string' ? org : undefined;
+      const params = { since, until, org: sanitizedOrg };
+
       // Use our new unified getSeat method that handles both ID and login
       // Pass the ID directly without conversion - the service will handle it
       const seat = await SeatsService.getSeat(id, params);
 
       res.status(200).json(seat);
     } catch (error: unknown) {
       const errorMessage = error instanceof Error ? error.message : 'Unknown error occurred';
-      const sanitizedId = encodeURIComponent(id);
-      console.error(`Error in getSeat controller for id=${sanitizedId}:`, errorMessage);
       res.status(500).json({ error: errorMessage });
     }
   }

backend/jest.config.ts

@@ -191,7 +191,7 @@ class SeatsService {
       const query: mongoose.FilterQuery<SeatType> = { assignee_id: numericId };
 
       if (params.org) {
-        query.org = params.org;
+        query.org = { $eq: params.org };
       }
 
       if (params.since || params.until) {
@@ -219,11 +219,11 @@ class SeatsService {
 
       return results || [];
     } catch (error: unknown) {
-      console.error('========== SEAT LOOKUP ERROR ==========');
-      console.error(`Error retrieving seat data for ${identifier}:`, error);
+      logger.error('========== SEAT LOOKUP ERROR ==========');
+      logger.error('Error retrieving seat data for %s:', identifier, error);
       // Safe access to stack property
-      console.error(`Stack trace:`, error instanceof Error ? error.stack : 'No stack trace available');
-      console.error('=======================================');
+      logger.error(`Stack trace:`, error instanceof Error ? error.stack : 'No stack trace available');
+      logger.error('=======================================');
 
       // Return empty results rather than throwing error
       return [];