refactor: streamline survey update logic and clean up route comments

Author: austenstone

backend/src/controllers/survey.controller.ts

@@ -10,16 +10,7 @@ class SurveyController {
     let survey: SurveyType;
     try {
       const _survey = await surveyService.updateSurvey({
-        id: req.body.id,
-        userId: req.body.userId,
-        org: req.body.org,
-        repo: req.body.repo,
-        prNumber: req.body.prNumber,
-        usedCopilot: req.body.usedCopilot,
-        percentTimeSaved: req.body.percentTimeSaved,
-        reason: req.body.reason,
-        timeUsedFor: req.body.timeUsedFor,
-        kudos: req.body.kudos,
+        ...req.body,
         hits: 0,
         status: 'completed'
       });
@@ -135,6 +126,7 @@ class SurveyController {
       const updated = await Survey.findOneAndUpdate({
         id: { $eq: Number(id) }
       }, {
+        // we don't want to update all fields... just the ones passed in the body.
         ...req.body,
         hits: 0,
         status: 'completed'

backend/src/routes/index.ts

@@ -18,37 +18,31 @@ router.get('/', (req: Request, res: Response) => {
   res.send('Hello github-value!');
 });
 
-// Survey routes
 router.get('/survey', surveyController.getAllSurveys);
 router.post('/survey', surveyController.createSurvey);
 router.get('/survey/:id', surveyController.getSurveyById);
 router.put('/survey/:id', surveyController.updateSurvey); // put github survey logic here
 router.delete('/survey/:id', surveyController.deleteSurvey);
 router.post('/survey/:id/github', surveyController.updateSurveyGitHub);
 
-// Metrics routes
 router.get('/metrics', metricsController.getMetrics);
 router.get('/metrics/totals', metricsController.getMetricsTotals);
 
-// Seats routes
 router.get('/seats', SeatsController.getAllSeats);
 router.get('/seats/activity', adoptionController.getAdoptions);
 router.get('/seats/activity/totals', adoptionController.getAdoptionTotals);
 router.get('/seats/:id', SeatsController.getSeat);
 
-// Teams routes
 router.get('/teams', teamsController.getAllTeams);
 router.get('/members', teamsController.getAllMembers);
 router.get('/members/:login', teamsController.getMemberByLogin);
 
-// Settings routes - Fix for updated Express typings
 router.get('/settings', settingsController.getAllSettings);
 router.post('/settings', settingsController.createSettings);
 router.put('/settings', settingsController.updateSettings);
 router.get('/settings/:name', settingsController.getSettingsByName);
 router.delete('/settings/:name', settingsController.deleteSettings);
 
-// Setup routes
 router.get('/setup/registration/complete', setupController.registrationComplete);
 router.get('/setup/install/complete', setupController.installComplete);
 router.get('/setup/install', setupController.getInstall);
@@ -59,7 +53,6 @@ router.get('/setup/status', setupController.setupStatus);
 
 router.get('/status', setupController.getStatus);
 
-// Target routes
 router.get('/targets', targetValuesController.getTargetValues);
 router.post('/targets', targetValuesController.updateTargetValues);