Skip to content

Commit 447633f

Browse files
committed
Add assertions in unit test to test multiple appenders.
1 parent ee08593 commit 447633f

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

powertools-logging/powertools-logging-log4j/src/main/java/software/amazon/lambda/powertools/logging/log4j/BufferingAppender.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
* <h3>Configuration Example:</h3>
5959
* <pre>{@code
6060
* <BufferingAppender name="BufferedAppender"
61-
* bufferAtVerbosity="INFO"
61+
* bufferAtVerbosity="DEBUG"
6262
* maxBytes="20480"
6363
* flushOnErrorLog="true">
6464
* <AppenderRef ref="ConsoleAppender"/>
@@ -80,7 +80,7 @@
8080
* <li>On Lambda completion: remaining buffered logs can be flushed via {@link software.amazon.lambda.powertools.logging.PowertoolsLogging}</li>
8181
* </ul>
8282
*
83-
* @see software.amazon.lambda.powertools.logging.PowertoolsLogging#flushLogBuffer()
83+
* @see software.amazon.lambda.powertools.logging.PowertoolsLogging#flushBuffer()
8484
*/
8585
@Plugin(name = BUFFERING_APPENDER_PLUGIN_NAME, category = Core.CATEGORY_NAME, elementType = Appender.ELEMENT_TYPE)
8686
public class BufferingAppender extends AbstractAppender implements BufferManager {

powertools-logging/powertools-logging-log4j/src/test/java/software/amazon/lambda/powertools/logging/log4j/internal/Log4jLoggingManagerTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package software.amazon.lambda.powertools.logging.log4j.internal;
22

33
import static org.assertj.core.api.Assertions.assertThat;
4+
import static org.assertj.core.api.Assertions.contentOf;
45
import static org.slf4j.event.Level.DEBUG;
56
import static org.slf4j.event.Level.ERROR;
67
import static org.slf4j.event.Level.WARN;
@@ -92,6 +93,9 @@ void shouldDetectMultipleBufferingAppendersRegardlessOfName() throws IOException
9293
// Then - both appenders should have flushed their buffers
9394
File logFile = new File("target/logfile.json");
9495
assertThat(logFile).exists();
96+
assertThat(contentOf(logFile))
97+
.contains("Test message 1")
98+
.contains("Test message 2");
9599
}
96100

97101
@AfterEach

0 commit comments

Comments
 (0)