ini: use envsubst

eval was prob used to expand $VAR refs ini values ie: path =
$HOME/.config

reason for this patch: if say the ini is updated via session_token or
user_input then think of backticks or $() or ! in user_input_pw

envsubst would continue to expand available env vars

unknown vars become empty strings
so key=val of "credentials=user:${NONEXISTENT}" becomes
"credentials=user:"

if a token or password contains $ .. itll be silently empty and literal
but at least not executed

- Known env var: ($HOME) is expanded (OK)
- Unknown env var: ($NONEXISTENT) becomes EMPTY STRING
- string with bang: (!) is passed through as is (OK)
- backticks or exec: (`) or ($()) is passwd through as is (OK)

Author: wfleurant

examples/config/src/lib/ini.sh

@@ -47,7 +47,7 @@ ini_load() {
     elif [[ $line =~ $key_regex ]]; then
       key="${BASH_REMATCH[1]}"
       value="${BASH_REMATCH[2]}"
-      [[ $value == *\$* ]] && eval "value=\"$value\""
+      [[ $value == *\$* ]] && value=$(envsubst <<< "$value")
       ini["${section}${key}"]="$value"
     fi
   done <"$ini_file"

examples/ini/src/lib/ini.sh

@@ -47,7 +47,7 @@ ini_load() {
     elif [[ $line =~ $key_regex ]]; then
       key="${BASH_REMATCH[1]}"
       value="${BASH_REMATCH[2]}"
-      [[ $value == *\$* ]] && eval "value=\"$value\""
+      [[ $value == *\$* ]] && value=$(envsubst <<< "$value")
       ini["${section}${key}"]="$value"
     fi
   done <"$ini_file"

lib/bashly/libraries/ini/ini.sh

@@ -47,7 +47,7 @@ ini_load() {
     elif [[ $line =~ $key_regex ]]; then
       key="${BASH_REMATCH[1]}"
       value="${BASH_REMATCH[2]}"
-      [[ $value == *\$* ]] && eval "value=\"$value\""
+      [[ $value == *\$* ]] && value=$(envsubst <<< "$value")
       ini["${section}${key}"]="$value"
     fi
   done <"$ini_file"