py_wheel: always generate zip64-capable wheels (#2711)

devtbi · rickeylev · web-flow · commit ccbe5dcdb84a · 2025-05-03T03:22:48.000Z
Currently, there is no possibility to pass the force zip64 option to the wheel creation. This hinders creation of packages that contain >2Gb files (e.g. large projects with debug symbols). To fix, always generate zip64 capable wheels. zip64 support is wide spread. Fixes #2852 --------- Co-authored-by: Richard Levasseur <richardlev@gmail.com> Co-authored-by: Richard Levasseur <rlevasseur@google.com>
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -54,12 +54,14 @@ END_UNRELEASED_TEMPLATE
 
 {#v0-0-0-changed}
 ### Changed
+
 * (rules) On Windows, {obj}`--bootstrap_impl=system_python` is forced. This
   allows setting `--bootstrap_impl=script` in bazelrc for mixed-platform
   environments.
 * (rules) {obj}`pip_compile` now generates a `.test` target. The `_test` target is deprecated
   and will be removed in the next major release.
   ([#2794](https://github.com/bazel-contrib/rules_python/issues/2794)
+* (py_wheel) py_wheel always creates zip64-capable wheel zips
 
 {#v0-0-0-fixed}
 ### Fixed
diff --git a/examples/wheel/test_publish.py b/examples/wheel/test_publish.py
@@ -104,7 +104,7 @@ def test_upload_and_query_simple_api(self):
     </head>
     <body>
         <h1>Links for example-minimal-library</h1>
-             <a href="/packages/example_minimal_library-0.0.1-py3-none-any.whl#sha256=a73acae23590c7a8d4365c888c1f12f0399b7af27169ea99fc7a00f402833926">example_minimal_library-0.0.1-py3-none-any.whl</a><br>
+             <a href="/packages/example_minimal_library-0.0.1-py3-none-any.whl#sha256=ef5afd9f6c3ff569ef7e5b2799d3a2ec9675d029414f341e0abd7254d6b9a25d">example_minimal_library-0.0.1-py3-none-any.whl</a><br>
     </body>
 </html>"""
             self.assertEqual(
diff --git a/examples/wheel/wheel_test.py b/examples/wheel/wheel_test.py
@@ -85,7 +85,7 @@ def test_py_library_wheel(self):
                 ],
             )
         self.assertFileSha256Equal(
-            filename, "a73acae23590c7a8d4365c888c1f12f0399b7af27169ea99fc7a00f402833926"
+            filename, "ef5afd9f6c3ff569ef7e5b2799d3a2ec9675d029414f341e0abd7254d6b9a25d"
         )
 
     def test_py_package_wheel(self):
@@ -110,7 +110,7 @@ def test_py_package_wheel(self):
                 ],
             )
         self.assertFileSha256Equal(
-            filename, "a76001500453dbd1d778821dcaba165d56db502c854cef9381dd3f8f89caee11"
+            filename, "39bec133cf79431e8d057eae550cd91aa9dfbddfedb53d98ebd36e3ade2753d0"
         )
 
     def test_customized_wheel(self):
@@ -206,7 +206,7 @@ def test_customized_wheel(self):
 second = second.main:s""",
             )
         self.assertFileSha256Equal(
-            filename, "941c0d79f4ca67cfa0028248bd0606db7fc69953ff9c7c73ac26a3e6d3c23587"
+            filename, "685f68fc6665f53c9b769fd1ba12cce9937ab7f40ef4e60c82ef2de8653935de"
         )
 
     def test_filename_escaping(self):
@@ -278,7 +278,7 @@ def test_custom_package_root_wheel(self):
             for line in record_contents.splitlines():
                 self.assertFalse(line.startswith("/"))
         self.assertFileSha256Equal(
-            filename, "7bd959b7efe9e325b30a6559177a1a4f22ac7a68fade310845916276110e9287"
+            filename, "2fbfc3baaf6fccca0f97d02316b8344507fe6c8136991a66ee5f162235adb19f"
         )
 
     def test_custom_package_root_multi_prefix_wheel(self):
@@ -312,7 +312,7 @@ def test_custom_package_root_multi_prefix_wheel(self):
             for line in record_contents.splitlines():
                 self.assertFalse(line.startswith("/"))
         self.assertFileSha256Equal(
-            filename, "caf51e22bdcd3c6c766c8903319ce717daeb6caac577d14e16326a8597981854"
+            filename, "3e67971ca1e8a9ba36a143df7532e641f5661c56235e41d818309316c955ba58"
         )
 
     def test_custom_package_root_multi_prefix_reverse_order_wheel(self):
@@ -346,7 +346,7 @@ def test_custom_package_root_multi_prefix_reverse_order_wheel(self):
             for line in record_contents.splitlines():
                 self.assertFalse(line.startswith("/"))
         self.assertFileSha256Equal(
-            filename, "9e8c0baa408b829dec691a5e8d3bc040be0bbfcc95c0eee19e1e5ffadea4a059"
+            filename, "372ef9e11fb79f1952172993718a326b5adda192d94884b54377c34b44394982"
         )
 
     def test_python_requires_wheel(self):
@@ -371,7 +371,7 @@ def test_python_requires_wheel(self):
 """,
             )
         self.assertFileSha256Equal(
-            filename, "b47f3eaf4f9fa4685a58c7415ba1feddd39635ae26c18473504f7d7e62e8ce07"
+            filename, "10a325ba8f77428b5cfcff6345d508f5eb77c140889eb62490d7382f60d4ebfe"
         )
 
     def test_python_abi3_binary_wheel(self):
@@ -436,7 +436,7 @@ def test_rule_creates_directory_and_is_included_in_wheel(self):
                 ],
             )
         self.assertFileSha256Equal(
-            filename, "d8e874b807e5574bd11a9312c58ce7fe7055afb80412d0d0e7ed21fc9223cd53"
+            filename, "85e44c43cc19ccae9fe2e1d629230203aa11791bed1f7f68a069fb58d1c93cd2"
         )
 
     def test_rule_expands_workspace_status_keys_in_wheel_metadata(self):
diff --git a/tools/wheelmaker.py b/tools/wheelmaker.py
@@ -154,7 +154,7 @@ def arcname_from(name):
         hash = hashlib.sha256()
         size = 0
         with open(real_filename, "rb") as fsrc:
-            with self.open(zinfo, "w") as fdst:
+            with self.open(zinfo, "w", force_zip64=True) as fdst:
                 while True:
                     block = fsrc.read(2**20)
                     if not block:

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ def test_py_library_wheel(self):`
`85`	`85`	`],`
`86`	`86`	`)`
`87`	`87`	`self.assertFileSha256Equal(`
`88`		`- filename, "a73acae23590c7a8d4365c888c1f12f0399b7af27169ea99fc7a00f402833926"`
	`88`	`+ filename, "ef5afd9f6c3ff569ef7e5b2799d3a2ec9675d029414f341e0abd7254d6b9a25d"`
`89`	`89`	`)`
`90`	`90`
`91`	`91`	`def test_py_package_wheel(self):`
`@@ -110,7 +110,7 @@ def test_py_package_wheel(self):`
`110`	`110`	`],`
`111`	`111`	`)`
`112`	`112`	`self.assertFileSha256Equal(`
`113`		`- filename, "a76001500453dbd1d778821dcaba165d56db502c854cef9381dd3f8f89caee11"`
	`113`	`+ filename, "39bec133cf79431e8d057eae550cd91aa9dfbddfedb53d98ebd36e3ade2753d0"`
`114`	`114`	`)`
`115`	`115`
`116`	`116`	`def test_customized_wheel(self):`
`@@ -206,7 +206,7 @@ def test_customized_wheel(self):`
`206`	`206`	`second = second.main:s""",`
`207`	`207`	`)`
`208`	`208`	`self.assertFileSha256Equal(`
`209`		`- filename, "941c0d79f4ca67cfa0028248bd0606db7fc69953ff9c7c73ac26a3e6d3c23587"`
	`209`	`+ filename, "685f68fc6665f53c9b769fd1ba12cce9937ab7f40ef4e60c82ef2de8653935de"`
`210`	`210`	`)`
`211`	`211`
`212`	`212`	`def test_filename_escaping(self):`
`@@ -278,7 +278,7 @@ def test_custom_package_root_wheel(self):`
`278`	`278`	`for line in record_contents.splitlines():`
`279`	`279`	`self.assertFalse(line.startswith("/"))`
`280`	`280`	`self.assertFileSha256Equal(`
`281`		`- filename, "7bd959b7efe9e325b30a6559177a1a4f22ac7a68fade310845916276110e9287"`
	`281`	`+ filename, "2fbfc3baaf6fccca0f97d02316b8344507fe6c8136991a66ee5f162235adb19f"`
`282`	`282`	`)`
`283`	`283`
`284`	`284`	`def test_custom_package_root_multi_prefix_wheel(self):`
`@@ -312,7 +312,7 @@ def test_custom_package_root_multi_prefix_wheel(self):`
`312`	`312`	`for line in record_contents.splitlines():`
`313`	`313`	`self.assertFalse(line.startswith("/"))`
`314`	`314`	`self.assertFileSha256Equal(`
`315`		`- filename, "caf51e22bdcd3c6c766c8903319ce717daeb6caac577d14e16326a8597981854"`
	`315`	`+ filename, "3e67971ca1e8a9ba36a143df7532e641f5661c56235e41d818309316c955ba58"`
`316`	`316`	`)`
`317`	`317`
`318`	`318`	`def test_custom_package_root_multi_prefix_reverse_order_wheel(self):`
`@@ -346,7 +346,7 @@ def test_custom_package_root_multi_prefix_reverse_order_wheel(self):`
`346`	`346`	`for line in record_contents.splitlines():`
`347`	`347`	`self.assertFalse(line.startswith("/"))`
`348`	`348`	`self.assertFileSha256Equal(`
`349`		`- filename, "9e8c0baa408b829dec691a5e8d3bc040be0bbfcc95c0eee19e1e5ffadea4a059"`
	`349`	`+ filename, "372ef9e11fb79f1952172993718a326b5adda192d94884b54377c34b44394982"`
`350`	`350`	`)`
`351`	`351`
`352`	`352`	`def test_python_requires_wheel(self):`
`@@ -371,7 +371,7 @@ def test_python_requires_wheel(self):`
`371`	`371`	`""",`
`372`	`372`	`)`
`373`	`373`	`self.assertFileSha256Equal(`
`374`		`- filename, "b47f3eaf4f9fa4685a58c7415ba1feddd39635ae26c18473504f7d7e62e8ce07"`
	`374`	`+ filename, "10a325ba8f77428b5cfcff6345d508f5eb77c140889eb62490d7382f60d4ebfe"`
`375`	`375`	`)`
`376`	`376`
`377`	`377`	`def test_python_abi3_binary_wheel(self):`
`@@ -436,7 +436,7 @@ def test_rule_creates_directory_and_is_included_in_wheel(self):`
`436`	`436`	`],`
`437`	`437`	`)`
`438`	`438`	`self.assertFileSha256Equal(`
`439`		`- filename, "d8e874b807e5574bd11a9312c58ce7fe7055afb80412d0d0e7ed21fc9223cd53"`
	`439`	`+ filename, "85e44c43cc19ccae9fe2e1d629230203aa11791bed1f7f68a069fb58d1c93cd2"`
`440`	`440`	`)`
`441`	`441`
`442`	`442`	`def test_rule_expands_workspace_status_keys_in_wheel_metadata(self):`