Skip to content

Commit 8936d9e

Browse files
cushoncopybara-github
authored andcommitted
Automated Code Change
PiperOrigin-RevId: 871745600 Change-Id: I15401ea89ed186edc7e0778851c4f9a4b9b370a6
1 parent cbcf83c commit 8936d9e

3 files changed

Lines changed: 9 additions & 11 deletions

File tree

rules/android_binary/impl.bzl

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515

1616
load("//providers:providers.bzl", "AndroidDexInfo", "AndroidFeatureFlagSet", "AndroidIdlInfo", "AndroidInstrumentationInfo", "AndroidLibraryResourceClassJarProvider", "AndroidOptimizationInfo", "AndroidPreDexJarInfo", "ApkInfo", "BaselineProfileProvider", "DataBindingV2Info", "ProguardMappingInfo", "StarlarkAndroidDexInfo", "StarlarkAndroidResourcesInfo", "StarlarkApkInfo")
1717
load("//rules:acls.bzl", "acls")
18+
load("//rules:add_constraints.bzl", "add_constraints")
1819
load("//rules:apk_packaging.bzl", _apk_packaging = "apk_packaging")
1920
load("//rules:baseline_profiles.bzl", _baseline_profiles = "baseline_profiles")
2021
load("//rules:common.bzl", "common")
@@ -231,11 +232,7 @@ def _process_jvm(ctx, db_ctx, packaged_resources_ctx, proto_ctx, stamp_ctx, **_u
231232
strict_deps = "DEFAULT",
232233
java_toolchain = common.get_java_toolchain(ctx),
233234
)
234-
if getattr(java_common, "add_constraints", None):
235-
java_info = java_common.add_constraints(
236-
java_info,
237-
constraints = ["android"],
238-
)
235+
java_info = add_constraints(java_info, constraints = ["android"])
239236

240237
java_infos = [packaged_resources_ctx.r_java]
241238
if proto_ctx.java_info:

rules/android_local_test/impl.bzl

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
"""Bazel rule for Android local test."""
1515

1616
load("//providers:providers.bzl", "AndroidFilteredJdepsInfo")
17+
load("//rules:add_constraints.bzl", "add_constraints")
1718
load("//rules:attrs.bzl", "attrs")
1819
load("//rules:common.bzl", "common")
1920
load("//rules:java.bzl", "java")
@@ -160,11 +161,7 @@ def _process_jvm(ctx, resources_ctx, **_unused_sub_ctxs):
160161
plugins = utils.collect_providers(JavaPluginInfo, ctx.attr.plugins),
161162
java_toolchain = common.get_java_toolchain(ctx),
162163
)
163-
if getattr(java_common, "add_constraints", None):
164-
java_info = java_common.add_constraints(
165-
java_info,
166-
constraints = ["android"],
167-
)
164+
java_info = add_constraints(java_info, constraints = ["android"])
168165

169166
# TODO(timpeut): some conformance tests require a filtered JavaInfo
170167
# with no transitive_ deps.

rules/resources.bzl

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515

1616
load("//providers:providers.bzl", "AndroidLibraryResourceClassJarProvider", "ResourcesNodeInfo", "StarlarkAndroidResourcesInfo")
1717
load("//rules:acls.bzl", "acls")
18+
load("//rules:add_constraints.bzl", "add_constraints")
1819
load("//rules:min_sdk_version.bzl", _min_sdk_version = "min_sdk_version")
1920
load("//rules:visibility.bzl", "PROJECT_VISIBILITY")
20-
load("@rules_java//java/common:java_common.bzl", "java_common")
2121
load("@rules_java//java/common:java_info.bzl", "JavaInfo")
2222
load("@bazel_skylib//rules:common_settings.bzl", "BuildSettingInfo")
2323
load(":attrs.bzl", _attrs = "attrs")
@@ -839,6 +839,8 @@ def _package(
839839
source_jar = r_java,
840840
)
841841

842+
java_info = add_constraints(java_info, constraints = ["android"])
843+
842844
packaged_resources_ctx[_R_JAVA] = java_info
843845
packaged_resources_ctx[_DATA_BINDING_LAYOUT_INFO] = data_binding_layout_info
844846

@@ -1607,6 +1609,8 @@ def _process_starlark(
16071609

16081610
packages_to_r_txts_depset.setdefault(java_package, []).append(depset([out_aapt2_r_txt]))
16091611

1612+
java_info = add_constraints(java_info, constraints = ["android"])
1613+
16101614
resources_ctx[_R_JAVA] = java_info
16111615
resources_ctx[_DATA_BINDING_LAYOUT_INFO] = data_binding_layout_info
16121616

0 commit comments

Comments
 (0)