Skip to content

Commit e2320f5

Browse files
timpeutcopybara-github
authored andcommitted
Avoid using .pop() with a default value.
PiperOrigin-RevId: 857274669 Change-Id: I034d29d38264e863e12f7cd40304e1006d29ff49
1 parent e6e58a6 commit e2320f5

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

rules/android_binary/rule.bzl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ def android_binary_macro(**attrs):
140140
# higher than 21.
141141
if acls.in_drop_multidex_attrs(target_fqn):
142142
for attr in ["multidex", "main_dex_list", "main_dex_list_opts", "main_dex_proguard_specs"]:
143-
attrs.pop(attr, default = None)
143+
if attr in attrs:
144+
attrs.pop(attr)
144145

145146
android_binary(**sanitize_attrs(attrs))

0 commit comments

Comments
 (0)