Skip to content

Commit c9f5957

Browse files
committed
refactor: apply PR review suggestions
- Remove stale fullscreen documentation from camera screen config - Use modern CSS syntax (inset, rgb color notation) - Replace Unicode fullscreen glyph with FontAwesome faExpand icon
1 parent 2188651 commit c9f5957

3 files changed

Lines changed: 8 additions & 8 deletions

File tree

packages/documentation/docs/user-guide/features/sofie-views-and-screens.mdx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,8 +254,7 @@ The Configurable Screens section uses collapsible accordion panels that let you
254254
**Camera Screen Configuration**
255255
- Filter by specific Source Layer IDs (e.g., cameras, DVEs)
256256
- Filter by Studio Labels to show only relevant cameras
257-
- Enable fullscreen mode for mobile devices
258-
- Generates URL with `sourceLayerIds`, `studioLabels`, and `fullscreen` parameters
257+
- Generates URL with `sourceLayerIds` and `studioLabels` parameters
259258

260259
**Prompter Configuration**
261260
- Configure display options (mirroring, font size, margins, read marker position)

packages/webui/src/client/ui/ClockView/FullscreenOverlay.scss

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
11
.fullscreen-overlay {
22
position: fixed;
3-
top: 0;
4-
left: 0;
5-
right: 0;
6-
bottom: 0;
3+
inset: 0;
74
width: 100%;
85
height: 100%;
9-
background-color: rgba(0, 0, 0, 0.7);
6+
background-color: rgb(0 0 0 / 0.7);
107
display: flex;
118
align-items: center;
129
justify-content: center;

packages/webui/src/client/ui/ClockView/FullscreenOverlay.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ import { useState, useEffect, useCallback } from 'react'
22
import { useLocation } from 'react-router-dom'
33
import { parse as queryStringParse } from 'query-string'
44
import { useTranslation } from 'react-i18next'
5+
import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
6+
import { faExpand } from '@fortawesome/free-solid-svg-icons'
57
import { catchError } from '../../lib/lib.js'
68

79
import './FullscreenOverlay.scss'
@@ -59,7 +61,9 @@ export function FullscreenOverlay(): JSX.Element | null {
5961
aria-label={t('Click or press Enter for fullscreen')}
6062
>
6163
<div className="fullscreen-overlay__content">
62-
<div className="fullscreen-overlay__icon"></div>
64+
<div className="fullscreen-overlay__icon">
65+
<FontAwesomeIcon icon={faExpand} />
66+
</div>
6367
<div className="fullscreen-overlay__text">{t('Click anywhere for fullscreen')}</div>
6468
</div>
6569
</button>

0 commit comments

Comments
 (0)