Merge pull request Sofie-Automation#1710 from evs-broadcast/fix/abPlaybackLookaheads

Fix for AB playback lookahead player assignment

Author: scriptorian

packages/job-worker/src/playout/abPlayback/__tests__/abPlaybackResolver.spec.ts

@@ -639,6 +639,56 @@ describe('resolveAbAssignmentsFromRequests', () => {
 		expectGotPlayer(res, 'd', undefined)
 	})
 
+	test('Autonext lookahead assignment with more clips than players', () => {
+		const requests: SessionRequest[] = [
+			// first part
+			{
+				id: 'a',
+				name: 'a',
+				start: 1000,
+				end: 5000,
+				playerId: 1,
+				pieceNames: ['p1'],
+			},
+			// second part
+			{
+				id: 'b',
+				name: 'b',
+				start: 5000,
+				end: 10000,
+				playerId: 2,
+				pieceNames: ['p2'],
+			},
+			// third part
+			{
+				id: 'c',
+				name: 'c',
+				start: 10000,
+				end: 15000,
+				playerId: 1,
+				pieceNames: ['p3'],
+			},
+			// lookaheads (in order of future use)
+			{
+				id: 'z',
+				name: 'z',
+				start: 0,
+				end: 100,
+				lookaheadRank: 1,
+				pieceNames: [],
+			},
+		]
+
+		const res = resolveAbAssignmentsFromRequests(resolverOptions, TWO_SLOTS, requests, 5100)
+		expect(res).toBeTruthy()
+		expect(res.failedOptional).toEqual([])
+		expect(res.failedRequired).toEqual([])
+		expectGotPlayer(res, 'a', 1)
+		expectGotPlayer(res, 'b', 2)
+		expectGotPlayer(res, 'c', 1)
+		expectGotPlayer(res, 'z', 2)
+	})
+
 	test('Preserve on-air optional over a required', () => {
 		const requests: SessionRequest[] = [
 			// current part

packages/job-worker/src/playout/abPlayback/abPlaybackResolver.ts

@@ -361,6 +361,8 @@ function assignPlayersForLookahead(
 		Array.from(lastSessionPerSlot.entries()),
 		(session) => session[1] < safeNow
 	)
+	// We want to assign the ones that are clear soonest first, as they are more likely to be ready in time
+	playersClearSoon.sort((endA, endB) => endA[1] - endB[1])
 
 	// Assign the players which are clear right now
 	const playersClearNowIds = new Set(playersClearNow.map((p) => p[0]))