Add TODO comments to key factories

Author: peterdettman

core/src/main/java/org/bouncycastle/crypto/util/PrivateKeyFactory.java

@@ -152,8 +152,16 @@ else if (algOID.equals(X9ObjectIdentifiers.id_dsa))
 
             return new DSAPrivateKeyParameters(derX.getValue(), parameters);
         }
+        /*
+         * TODO id-ecDH (SECObjectIdentifiers.ecdh) and/or id-ecMQV (SECObjectIdentifiers.ecmqv) could be supported if
+         * we could properly restrict usage of the resulting key.
+         */
         else if (algOID.equals(X9ObjectIdentifiers.id_ecPublicKey))
         {
+            /*
+             * TODO Consistency checks in case parameters and/or public key are specified at both the
+             * PrivateKeyInfo and ECPrivateKey levels?
+             */
             ECPrivateKey ecPrivateKey = ECPrivateKey.getInstance(keyInfo.parsePrivateKey());
 
             X962Parameters parameters = X962Parameters.getInstance(algId.getParameters().toASN1Primitive());

core/src/main/java/org/bouncycastle/crypto/util/PublicKeyFactory.java

@@ -81,6 +81,10 @@ public class PublicKeyFactory
         converters.put(X9ObjectIdentifiers.id_dsa, new DSAConverter());
         converters.put(OIWObjectIdentifiers.dsaWithSHA1, new DSAConverter());
         converters.put(OIWObjectIdentifiers.elGamalAlgorithm, new ElGamalConverter());
+        /*
+         * TODO id-ecDH (SECObjectIdentifiers.ecdh) and/or id-ecMQV (SECObjectIdentifiers.ecmqv) could be supported if
+         * we could properly restrict usage of the resulting key.
+         */
         converters.put(X9ObjectIdentifiers.id_ecPublicKey, new ECConverter());
         converters.put(CryptoProObjectIdentifiers.gostR3410_2001, new GOST3410_2001Converter());
         converters.put(RosstandartObjectIdentifiers.id_tc26_gost_3410_12_256, new GOST3410_2012Converter());