fixed mldsa docs (again, hopefully for the last time)

Author: ounsworth

crypto/mldsa/src/lib.rs

@@ -93,8 +93,8 @@
 #![forbid(unsafe_code)]
 #![allow(incomplete_features)] // needed because currently generic_const_exprs is experimental
 #![feature(generic_const_exprs)]
-#![feature(int_roundings)]
-#![feature(inherent_associated_types)]
+// #![feature(int_roundings)]
+// #![feature(inherent_associated_types)]
 #![feature(adt_const_params)]
 
 // These are because I'm matching variable names exactly against FIPS 204, for example both 'K' and 'k',

crypto/mldsa/src/mldsa.rs

@@ -1427,7 +1427,7 @@ impl<
     /// Input: Signature 𝜎 ∈ 𝔹𝜆/4+ℓ⋅32⋅(1+bitlen (𝛾1−1))+𝜔+𝑘.
     fn verify_mu_internal(
         pk: &PK,
-        mu: &[u8; MU_LEN],
+        mu: &[u8; 64],
         sig: &[u8; SIG_LEN],
     ) -> bool {
         // 1: (𝜌, 𝐭1) ← pkDecode(𝑝𝑘)
@@ -1678,7 +1678,7 @@ pub trait MLDSATrait<
     /// Input: Signature 𝜎 ∈ 𝔹𝜆/4+ℓ⋅32⋅(1+bitlen (𝛾1−1))+𝜔+𝑘.
     fn verify_mu_internal(
         pk: &PK,
-        mu: &[u8; MU_LEN],
+        mu: &[u8; 64],
         sig: &[u8; SIG_LEN],
     ) -> bool;
 }

crypto/mldsa/tests/bc_test_data.rs

@@ -8,11 +8,13 @@ use bouncycastle_sha3::SHAKE256;
 
 #[cfg(test)]
 mod bc_test_data {
+    #![allow(dead_code)]
+
     use std::{fs};
     use bouncycastle_core_interface::errors::SignatureError;
     use bouncycastle_hex as hex;
     use bouncycastle_core_interface::key_material::{KeyMaterial, KeyMaterial256, KeyType};
-    use bouncycastle_core_interface::traits::{Hash, PHSignature, SecurityStrength, Signature, SignaturePrivateKey, SignaturePublicKey};
+    use bouncycastle_core_interface::traits::{Hash, SecurityStrength, Signature, SignaturePrivateKey, SignaturePublicKey};
     use bouncycastle_mldsa::{HashMLDSA44_with_SHA512, HashMLDSA65_with_SHA512, HashMLDSA87_with_SHA512, MLDSA44PrivateKey, MLDSA44PublicKey, MLDSA65PrivateKey, MLDSA65PublicKey, MLDSA87PrivateKey, MLDSA87PublicKey, MLDSAPrivateKeyTrait, MLDSATrait, MLDSA44, MLDSA65, MLDSA87};
     use bouncycastle_sha2::SHA512;
     use crate::BustedMuBuilder;

crypto/mldsa/tests/hash_mldsa_tests.rs

@@ -8,7 +8,6 @@ mod hash_mldsa_tests {
     use bouncycastle_hex as hex;
     use bouncycastle_core_interface::key_material::{KeyMaterial256, KeyType};
     use bouncycastle_core_interface::traits::{Hash};
-    use bouncycastle_core_test_framework::DUMMY_SEED_1024;
     use bouncycastle_core_test_framework::signature::TestFrameworkSignature;
     use bouncycastle_mldsa::{HashMLDSA44_with_SHA256, HashMLDSA44_with_SHA512, HashMLDSA65_with_SHA256, HashMLDSA65_with_SHA512, HashMLDSA87_with_SHA256, HashMLDSA87_with_SHA512, MLDSA44PrivateKey, MLDSA44PublicKey, MLDSA65PrivateKey, MLDSA65PublicKey, MLDSA87PrivateKey, MLDSA87PublicKey, MLDSATrait, MLDSA44, MLDSA65, MLDSA87};
     use bouncycastle_mldsa::{MLDSA44_SIG_LEN, MLDSA65_SIG_LEN, MLDSA87_SIG_LEN};