Fix shredding users with their own attributes failing without a resolver

The @objects loop in RT::User::__DependsOn included Attributes, causing
all attributes where Creator/LastUpdatedBy matched the user being shredded
to be added as VARIABLE (resolvable) dependencies. This required a
resolver to be registered, which is only done when the replace_relations
option is set. As a result, shredding a user with a RecentlyViewedTickets
attribute (or any own attribute) always failed with "Couldn't find
resolver for dependency".

The user's own attributes are already handled as direct DEPENDS_ON
(delete) dependencies via $self->Attributes in RT::Record::__DependsOn,
so they don't need to appear as VARIABLE dependencies too.

Author: sunnavy

lib/RT/User.pm

@@ -3180,7 +3180,6 @@ sub __DependsOn {
         ACL
         Articles
         Attachments
-        Attributes
         CachedGroupMembers
         Classes
         CustomFieldValues
@@ -3215,6 +3214,23 @@ sub __DependsOn {
             push @var_objs, $objs;
         }
     }
+
+    # Attributes of other objects (not owned by this user) that reference this
+    # user in Creator/LastUpdatedBy. The user's own attributes are already
+    # handled as direct DEPENDS_ON dependencies via $self->Attributes, so
+    # exclude them to avoid a duplicate VARIABLE dependency without a resolver.
+    for my $method (qw(Creator LastUpdatedBy)) {
+        my $objs = RT::Attributes->new( $self->CurrentUser );
+        $objs->Limit( FIELD => $method, VALUE => $self->id );
+        $objs->Limit( FIELD => 'ObjectType', OPERATOR => '!=', VALUE => ref $self );
+        push @var_objs, $objs;
+
+        my $other_user_attrs = RT::Attributes->new( $self->CurrentUser );
+        $other_user_attrs->Limit( FIELD => $method,      VALUE    => $self->id );
+        $other_user_attrs->Limit( FIELD => 'ObjectType', VALUE    => ref $self );
+        $other_user_attrs->Limit( FIELD => 'ObjectId',   OPERATOR => '!=', VALUE => $self->id );
+        push @var_objs, $other_user_attrs;
+    }
     $deps->_PushDependencies(
         BaseObject => $self,
         Flags => RT::Shredder::Constants::DEPENDS_ON | RT::Shredder::Constants::VARIABLE,