Skip to content

Commit 00366ae

Browse files
Update codegen (buildpacks-community#1848)
* Update codegen script to use kube_codegen Signed-off-by: Tom Kennedy <tom.kennedy@broadcom.com> * Run codegenerator Signed-off-by: Tom Kennedy <tom.kennedy@broadcom.com> * Update openapi codegen Signed-off-by: Tom Kennedy <tom.kennedy@broadcom.com> --------- Signed-off-by: Tom Kennedy <tom.kennedy@broadcom.com>
1 parent a947fa9 commit 00366ae

24 files changed

Lines changed: 67 additions & 121 deletions

api/openapi-spec/swagger.json

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5704,8 +5704,7 @@
57045704
"kpack.build.v1alpha2.BuildStatus": {
57055705
"type": "object",
57065706
"required": [
5707-
"lifecycleVersion",
5708-
"lifecycleCommit"
5707+
"lifecycleVersion"
57095708
],
57105709
"properties": {
57115710
"buildMetadata": {
@@ -5734,10 +5733,6 @@
57345733
"latestImage": {
57355734
"type": "string"
57365735
},
5737-
"lifecycleCommit": {
5738-
"type": "string",
5739-
"default": ""
5740-
},
57415736
"lifecycleVersion": {
57425737
"type": "string",
57435738
"default": ""

go.sum

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -489,12 +489,8 @@ github.com/go-gl/glfw/v3.3/glfw v0.0.0-20191125211704-12ad95a8df72/go.mod h1:tQ2
489489
github.com/go-gl/glfw/v3.3/glfw v0.0.0-20200222043503-6f7a984d4dc4/go.mod h1:tQ2UAYgL5IevRw8kRxooKSPJfGvJ9fJQFa0TUsXzTg8=
490490
github.com/go-ini/ini v1.67.0 h1:z6ZrTEZqSWOTyH2FlglNbNgARyHG8oLW9gMELqKr06A=
491491
github.com/go-ini/ini v1.67.0/go.mod h1:ByCAeIL28uOIIG0E3PJtZPDL8WnHpFKFOtgjp+3Ies8=
492-
github.com/go-jose/go-jose/v3 v3.0.3 h1:fFKWeig/irsp7XD2zBxvnmA/XaRWp5V3CBsZXJF7G7k=
493-
github.com/go-jose/go-jose/v3 v3.0.3/go.mod h1:5b+7YgP7ZICgJDBdfjZaIt+H/9L9T/YQrVfLAMboGkQ=
494492
github.com/go-jose/go-jose/v3 v3.0.4 h1:Wp5HA7bLQcKnf6YYao/4kpRpVMp/yf6+pJKV8WFSaNY=
495493
github.com/go-jose/go-jose/v3 v3.0.4/go.mod h1:5b+7YgP7ZICgJDBdfjZaIt+H/9L9T/YQrVfLAMboGkQ=
496-
github.com/go-jose/go-jose/v4 v4.0.1 h1:QVEPDE3OluqXBQZDcnNvQrInro2h0e4eqNbnZSWqS6U=
497-
github.com/go-jose/go-jose/v4 v4.0.1/go.mod h1:WVf9LFMHh/QVrmqrOfqun0C45tMe3RoiKJMPvgWwLfY=
498494
github.com/go-jose/go-jose/v4 v4.0.5 h1:M6T8+mKZl/+fNNuFHvGIzDz7BTLQPIounk/b9dw3AaE=
499495
github.com/go-jose/go-jose/v4 v4.0.5/go.mod h1:s3P1lRrkT8igV8D9OjyL4WRyHvjB6a4JSllnOrmmBOA=
500496
github.com/go-kit/kit v0.8.0/go.mod h1:xBxKIO96dXMWWy0MnWVtmwkA9/13aqxPnvrjFYMA2as=

hack/openapi-codegen.sh

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,16 @@ ROOT=$(realpath $(dirname ${BASH_SOURCE})/..)
99
cd "$ROOT"
1010

1111
go run k8s.io/kube-openapi/cmd/openapi-gen \
12-
-h ./hack/boilerplate/boilerplate.go.txt \
13-
-i github.com/pivotal/kpack/pkg/apis/build/v1alpha1,github.com/pivotal/kpack/pkg/apis/build/v1alpha2,github.com/pivotal/kpack/pkg/apis/core/v1alpha1 \
14-
-p ./pkg/openapi \
15-
-o ./
12+
--go-header-file ./hack/boilerplate/boilerplate.go.txt \
13+
--output-pkg openapi \
14+
--output-dir ./pkg/openapi \
15+
github.com/pivotal/kpack/pkg/apis/build/v1alpha1 github.com/pivotal/kpack/pkg/apis/build/v1alpha2 github.com/pivotal/kpack/pkg/apis/core/v1alpha1
1616

1717
# VolatileTime has custom json encoding/decoding that does not map to a proper json schema. Use a basic string instead.
18-
sed -i.old 's/Ref\: ref(\"github.com\/pivotal\/kpack\/pkg\/apis\/core\/v1alpha1.VolatileTime\"),/Type: []string{\"string\"}, Format: \"\",/g' pkg/openapi/openapi_generated.go
19-
sed -i.old 's/Ref\: ref(\"github.com\/pivotal\/kpack\/pkg\/apis\/core\/v1alpha2.VolatileTime\"),/Type: []string{\"string\"}, Format: \"\",/g' pkg/openapi/openapi_generated.go
18+
sed -i.old 's/Ref\: ref(\"github.com\/pivotal\/kpack\/pkg\/apis\/core\/v1alpha1.VolatileTime\"),/Type: []string{\"string\"}, Format: \"\",/g' pkg/openapi/generated.openapi.go
19+
sed -i.old 's/Ref\: ref(\"github.com\/pivotal\/kpack\/pkg\/apis\/core\/v1alpha2.VolatileTime\"),/Type: []string{\"string\"}, Format: \"\",/g' pkg/openapi/generated.openapi.go
2020

2121
go run ./hack/openapi/main.go 1> ./api/openapi-spec/swagger.json
22+
rm -f pkg/openapi/generated.openapi.go.old
2223

2324
cd -

hack/update-codegen.sh

Lines changed: 12 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -6,28 +6,18 @@ set -o pipefail
66

77
SCRIPT_ROOT=$(realpath $(dirname ${BASH_SOURCE})/..)
88

9-
pushd $SCRIPT_ROOT
10-
go mod vendor
11-
popd
12-
trap 'rm -rf $SCRIPT_ROOT/vendor' EXIT
9+
CODEGEN_PKG=$(go list -m -mod=readonly -f "{{.Dir}}" k8s.io/code-generator)
10+
source "${CODEGEN_PKG}"/kube_codegen.sh
1311

14-
CODEGEN_PKG=${CODEGEN_PKG:-$(cd "${SCRIPT_ROOT}"; ls -d -1 ./vendor/k8s.io/code-generator 2>/dev/null || echo ../code-generator)}
12+
kube::codegen::gen_helpers \
13+
--boilerplate "${SCRIPT_ROOT}"/hack/boilerplate/boilerplate.go.txt \
14+
"${SCRIPT_ROOT}/pkg/apis"
1515

16-
TMP_DIR="$(mktemp -d)"
17-
trap 'rm -rf ${TMP_DIR} && rm -rf $SCRIPT_ROOT/vendor' EXIT
18-
export GOPATH=${GOPATH:-${TMP_DIR}}
16+
kube::codegen::gen_client \
17+
--boilerplate "${SCRIPT_ROOT}"/hack/boilerplate/boilerplate.go.txt \
18+
--output-dir "${SCRIPT_ROOT}/pkg/client" \
19+
--output-pkg "github.com/pivotal/kpack/pkg/client" \
20+
--with-watch \
21+
"${SCRIPT_ROOT}/pkg/apis"
1922

20-
TMP_REPO_PATH="${TMP_DIR}/src/github.com/pivotal/kpack"
21-
mkdir -p "$(dirname "${TMP_REPO_PATH}")" && ln -s "${SCRIPT_ROOT}" "${TMP_REPO_PATH}"
22-
23-
bash "${CODEGEN_PKG}"/generate-groups.sh "deepcopy,client,informer,lister" \
24-
github.com/pivotal/kpack/pkg/client github.com/pivotal/kpack/pkg/apis \
25-
"build:v1alpha1,v1alpha2" \
26-
--output-base "${TMP_DIR}/src" \
27-
--go-header-file "${SCRIPT_ROOT}"/hack/boilerplate/boilerplate.go.txt
28-
29-
bash "${CODEGEN_PKG}"/generate-groups.sh "deepcopy" \
30-
github.com/pivotal/kpack/pkg/client github.com/pivotal/kpack/pkg/apis \
31-
"core:v1alpha1" \
32-
--output-base "${TMP_DIR}/src" \
33-
--go-header-file "${SCRIPT_ROOT}"/hack/boilerplate/boilerplate.go.txt
23+
go mod tidy

pkg/client/clientset/versioned/doc.go

Lines changed: 0 additions & 20 deletions
This file was deleted.

pkg/client/clientset/versioned/typed/build/v1alpha1/fake/fake_build.go

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/client/clientset/versioned/typed/build/v1alpha1/fake/fake_builder.go

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/client/clientset/versioned/typed/build/v1alpha1/fake/fake_clusterbuilder.go

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/client/clientset/versioned/typed/build/v1alpha1/fake/fake_clusterstack.go

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/client/clientset/versioned/typed/build/v1alpha1/fake/fake_clusterstore.go

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)