Skip to content

Commit c32283a

Browse files
author
Bohan Chen
committed
skip slsa e2e tests by default
we shouldnt test an experimental feature by default Signed-off-by: Bohan Chen <bohanc@vmware.com>
1 parent 82b764b commit c32283a

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ jobs:
409409
export GIT_BASIC_PASSWORD="${{ secrets.E2E_PRIVATE_REPO_PASSWORD }}"
410410
export GIT_SSH_PRIVATE_KEY="${{ secrets.E2E_PRIVATE_REPO_PRIVATE_KEY }}"
411411
412-
make e2e
412+
E2E_SLSA="true" make e2e
413413
kapp delete -a kpack -y
414414
415415
- name: Run tests with Istio

test/slsa_test.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import (
1212
"encoding/json"
1313
"encoding/pem"
1414
"fmt"
15+
"os"
1516
"strings"
1617
"testing"
1718

@@ -41,9 +42,10 @@ import (
4142
)
4243

4344
func TestSlsa(t *testing.T) {
44-
t.Cleanup(func() {
45-
fmt.Println("TestSlsa cleanup")
46-
})
45+
if testSlsa, _ := os.LookupEnv("E2E_SLSA"); testSlsa != "true" {
46+
t.Skip("E2E_SLSA not set, skipping")
47+
}
48+
4749
spec.Run(t, "SLSA", testSlsaBuild)
4850
}
4951

0 commit comments

Comments
 (0)