Minor improvements

Author: Mattia Roccoberton

README.md

@@ -6,16 +6,14 @@ Features:
 
 - set conditional checks on fields
 - trigger some actions on other fields
-- create links to load some content in a dialogs
+- create links to load some content in a dialog
 
-The easiest way to show how this plugin works is looking the examples (below).
+The easiest way to show how this plugin works is looking the examples [below](#examples-of-dynamic-fields).
 
 ## Install
 
 - Add to your Gemfile: `gem 'activeadmin_dynamic_fields'`
 - Execute bundle
-- Add at the end of your ActiveAdmin styles (_app/assets/stylesheets/active_admin.scss_):
-`@import 'activeadmin/dynamic_fields';`
 - Add at the end of your ActiveAdmin javascripts (_app/assets/javascripts/active_admin.js_):
 `//= require activeadmin/dynamic_fields`
 
@@ -106,7 +104,7 @@ Prepare the content dialog - in Active Admin Author config:
 ActiveAdmin.register Author do
   # ...
   member_action :dialog do
-    content  = '<dl>'
+    content  = '<dl style="margin: 12px">'
     [:name, :age, :created_at].each do |field|
       content += "<dt>#{Author.human_attribute_name(field)}:</dt><dd>#{resource[field]}</dd>"
     end

app/assets/javascripts/activeadmin/dynamic_fields.js

@@ -1,4 +1,4 @@
-
+// Evaluate a condition
 function dfEvalCondition( el, args ) {
   if( args.fn ) {
     if( args.fn && window[args.fn] ) return !window[args.fn]( el );
@@ -25,6 +25,7 @@ function dfEvalCondition( el, args ) {
   return undefined;
 }
 
+// Prepare a field
 function dfSetupField( el ) {
   var action = el.data( 'action' );
   var target, args = {};
@@ -82,13 +83,26 @@ function dfSetupField( el ) {
   }
 }
 
+// Set the value of an element
 function dfSetValue( el, val ) {
   if( el.attr('type') != 'checkbox' ) el.val( val );
   else el.prop('checked', val == '1');
   el.trigger( 'change' );
 }
 
+// Init
 $(document).ready( function() {
+  // Setup dynamic fields
+  $('.active_admin .input [data-if], .active_admin .input [data-function], .active_admin .input [data-eq], .active_admin .input [data-not]').each( function() {
+    dfSetupField( $(this) );
+  });
+  // Setup dynamic fields for has many associations
+  $('.active_admin .has_many_container').on( 'has_many_add:after', function( e, fieldset, container ) {
+    $('.active_admin .input [data-if], .active_admin .input [data-function], .active_admin .input [data-eq], .active_admin .input [data-not]').each( function() {
+      dfSetupField( $(this) );
+    });
+  });
+  // Open content in dialog
   $('.active_admin [data-df-dialog]').on( 'click', function( event ) {
     event.preventDefault();
     if( $('#df-dialog').length == 0 ) $('body').append( '<div id="df-dialog"></div>' );
@@ -101,14 +115,7 @@ $(document).ready( function() {
       $('#df-dialog').dialog({ modal: true });
     });
   });
-
-  $('.active_admin .input [data-if], .active_admin .input [data-function], .active_admin .input [data-eq], .active_admin .input [data-not]').each( function() {
-    dfSetupField( $(this) );
-  });
-
-  $('.active_admin .has_many_container').on( 'has_many_add:after', function( e, fieldset, container ) {
-    $('.active_admin .input [data-if], .active_admin .input [data-function], .active_admin .input [data-eq], .active_admin .input [data-not]').each( function() {
-      dfSetupField( $(this) );
-    });
+  $('.active_admin [data-df-icon]').each( function() {
+    $(this).append( ' &raquo;' );  // ' &bullet;'
   });
 });

app/assets/stylesheets/activeadmin/_dynamic_fields.sass

@@ -1,5 +1,5 @@
 module ActiveAdmin
   module DynamicFields
-    VERSION = '0.1.0'
+    VERSION = '0.1.2'
   end
 end