Merge pull request #12 from blocknotes/v1.0.0

v1.0.0

Author: blocknotes

.fasterer.yml

@@ -2,5 +2,6 @@
 exclude_paths:
   - bin/*
   - db/schema.rb
+  - gemfiles/**/*
   - spec/dummy/**/*
   - vendor/**/*

.github/workflows/specs_rails60.yml

@@ -0,0 +1,40 @@
+---
+name: Specs Rails 6.0
+
+on:
+  push:
+    branches: [master]
+  pull_request:
+    branches: [master]
+
+jobs:
+  tests:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        ruby: ['2.6', '2.7']
+        gemfile: ['rails60_activeadmin22', 'rails60_activeadmin']
+
+    env:
+      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v2
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+
+      - name: Run tests
+        run: bundle exec rspec --profile
+
+      - name: On failure, archive screenshots as artifacts
+        uses: actions/upload-artifact@v2
+        if: failure()
+        with:
+          name: test-failed-screenshots
+          path: spec/dummy/tmp/screenshots

.github/workflows/specs_rails61.yml

@@ -0,0 +1,40 @@
+---
+name: Specs Rails 6.1
+
+on:
+  push:
+    branches: [master]
+  pull_request:
+    branches: [master]
+
+jobs:
+  tests:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        ruby: ['2.6', '2.7', '3.0']
+        gemfile: ['rails61_activeadmin29', 'rails61_activeadmin']
+
+    env:
+      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v2
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+
+      - name: Run tests
+        run: bundle exec rspec --profile
+
+      - name: On failure, archive screenshots as artifacts
+        uses: actions/upload-artifact@v2
+        if: failure()
+        with:
+          name: test-failed-screenshots
+          path: spec/dummy/tmp/screenshots

.github/workflows/specs.yml .github/workflows/specs_rails70.yml.github/workflows/specs.yml renamed to .github/workflows/specs_rails70.yml

@@ -1,5 +1,5 @@
 ---
-name: Specs
+name: Specs Rails 7.0
 
 on:
   push:
@@ -8,15 +8,19 @@ on:
     branches: [master]
 
 jobs:
-  test:
+  tests:
     runs-on: ubuntu-latest
 
     strategy:
       matrix:
-        ruby: ['2.5', '2.6', '2.7']
+        ruby: ['2.7', '3.0']
+        gemfile: ['rails70_activeadmin']
+
+    env:
+      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
 
     steps:
-      - name: Checkout
+      - name: Checkout repository
         uses: actions/checkout@v2
 
       - name: Set up Ruby
@@ -26,9 +30,9 @@ jobs:
           bundler-cache: true
 
       - name: Run tests
-        run: bundle exec rake
+        run: bundle exec rspec --profile
 
-      - name: Archive screenshots for failed tests
+      - name: On failure, archive screenshots as artifacts
         uses: actions/upload-artifact@v2
         if: failure()
         with:

.rubocop.yml

@@ -6,25 +6,7 @@ AllCops:
   Exclude:
     - bin/*
     - db/schema.rb
+    - gemfiles/**/*
     - spec/dummy/**/*
     - vendor/**/*
   NewCops: enable
-
-Gemspec/RequiredRubyVersion:
-  Enabled: false
-
-Naming/FileName:
-  Enabled: false
-
-Layout/LineLength:
-  Enabled: true
-  Max: 120
-
-Style/HashEachMethods:
-  Enabled: true
-
-Style/HashTransformKeys:
-  Enabled: true
-
-Style/HashTransformValues:
-  Enabled: true

Appraisals

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+appraise 'rails52-activeadmin20' do
+  gem 'activeadmin', '~> 2.0.0'
+  gem 'rails', '~> 5.2.0'
+end
+
+appraise 'rails60-activeadmin22' do
+  gem 'activeadmin', '~> 2.2.0'
+  gem 'rails', '~> 6.0.0'
+  gem 'selenium-webdriver', require: false
+end
+
+appraise 'rails60-activeadmin' do
+  gem 'activeadmin'
+  gem 'rails', '~> 6.0.0'
+  gem 'selenium-webdriver', require: false
+end
+
+appraise 'rails61-activeadmin29' do
+  gem 'activeadmin', '~> 2.9.0'
+  gem 'rails', '~> 6.1.0'
+end
+
+appraise 'rails61-activeadmin' do
+  gem 'activeadmin'
+  gem 'rails', '~> 6.1.0'
+end
+
+appraise 'rails70-activeadmin' do
+  gem 'activeadmin'
+  gem 'rails', '~> 7.0.0'
+  gem 'sprockets-rails'
+end

CHANGELOG.md

@@ -0,0 +1,32 @@
+# medium-editor for ActiveAdmin
+
+An Active Admin plugin to use Medium Editor.
+
+## v1.0.0 - 2022-04-18
+
+- Set minimum Ruby version to 2.6.0
+- Remove `sassc` dependency
+- Enable Ruby 3.0 specs support
+- Enable Rails 7.0 specs support
+- Internal improvements
+
+## v0.2.14 - 2021-03-20
+
+- Fix editor loading with Turbolinks
+- Specs improvements
+
+## v0.2.12 - 2020-09-09
+
+- JS refactoring
+- Minor specs improvements
+- README changes
+
+## v0.2.9 - 2020-09-04
+
+- Reset some styles manually to the defaults to render better the elements in the editor
+
+## v0.2.8 - 2020-09-03
+
+- Update MediumEditor to commit `d113a744`
+- Add specs for editor in nested resources
+- Add Rubocop and remove SimpleCov gems

Gemfile

@@ -5,14 +5,15 @@ source 'https://rubygems.org'
 gemspec
 
 group :development, :test do
-  gem 'activestorage', '~> 6.0'
-  gem 'capybara', '~> 3.33'
-  gem 'puma', '~> 4.3'
-  gem 'rspec_junit_formatter', '~> 0.4'
-  gem 'rspec-rails', '~> 4.0'
-  gem 'selenium-webdriver', '~> 3.142'
-  gem 'sprockets-rails', '~> 3.2'
-  gem 'sqlite3', '~> 1.4'
+  gem 'puma'
+  gem 'sassc'
+  gem 'sqlite3'
+
+  # Testing
+  gem 'capybara'
+  gem 'cuprite'
+  gem 'rspec_junit_formatter'
+  gem 'rspec-rails'
 
   # Linters
   gem 'fasterer'

README.md

@@ -1,11 +1,15 @@
 # Active Admin Medium Editor
-[![gem version](https://badge.fury.io/rb/activeadmin_medium_editor.svg)](https://badge.fury.io/rb/activeadmin_medium_editor) [![Gem downloads](https://badgen.net/rubygems/dt/activeadmin_medium_editor)](https://rubygems.org/gems/activeadmin_medium_editor) [![linters](https://github.com/blocknotes/activeadmin_medium_editor/actions/workflows/linters.yml/badge.svg)](https://github.com/blocknotes/activeadmin_medium_editor/actions/workflows/linters.yml) [![specs](https://github.com/blocknotes/activeadmin_medium_editor/actions/workflows/specs.yml/badge.svg)](https://github.com/blocknotes/activeadmin_medium_editor/actions/workflows/specs.yml)
+[![gem version](https://badge.fury.io/rb/activeadmin_medium_editor.svg)](https://badge.fury.io/rb/activeadmin_medium_editor)
+[![Gem downloads](https://badgen.net/rubygems/dt/activeadmin_medium_editor)](https://rubygems.org/gems/activeadmin_medium_editor)
+[![linters](https://github.com/blocknotes/activeadmin_medium_editor/actions/workflows/linters.yml/badge.svg)](https://github.com/blocknotes/activeadmin_medium_editor/actions/workflows/linters.yml)
+[![specs Rails 6.1](https://github.com/blocknotes/activeadmin_medium_editor/actions/workflows/specs_rails61.yml/badge.svg)](https://github.com/blocknotes/activeadmin_medium_editor/actions/workflows/specs_rails61.yml)
+[![specs Rails 7.0](https://github.com/blocknotes/activeadmin_medium_editor/actions/workflows/specs_rails70.yml/badge.svg)](https://github.com/blocknotes/activeadmin_medium_editor/actions/workflows/specs_rails70.yml)
 
 An Active Admin plugin to use [medium-editor](https://github.com/yabwe/medium-editor), a compact and clean WYSIWYG editor.
 
 **IMPORTANT NOTICE**: while I like the Medium Editor idea of having floating buttons, it looks like that they are slow to release new stable versions. Some editor bugs are related to this problem unfortunately.
 
-![screenshot](screenshot.png)
+![screenshot](extra/screenshot.png)
 
 ## Usage
 
@@ -15,7 +19,8 @@ An Active Admin plugin to use [medium-editor](https://github.com/yabwe/medium-ed
 
 ## Install
 
-- After installing Active Admin, add to your Gemfile: `gem 'activeadmin_medium_editor'` (and execute *bundle*)
+- After installing Active Admin, add to your Gemfile: `gem 'activeadmin_medium_editor'`
+- Add also a SASS/SCSS gem to your Gemfile (ex. `gem 'sassc'`)
 - Add at the end of your Active Admin styles (_app/assets/stylesheets/active_admin.scss_):
 ```scss
 @import 'activeadmin/medium_editor/medium_editor';
@@ -59,6 +64,10 @@ f.input :description, as: :medium_editor, input_html: { data: { options: { toolb
 
 For details about the buttons' effect please refer to medium-editor documentation.
 
+## Changelog
+
+The changelog is available [here](CHANGELOG.md).
+
 ## Do you like it? Star it!
 
 If you use this component just star it. A developer is more motivated to improve a project when there is some interest. My other [Active Admin components](https://github.com/blocknotes?utf8=✓&tab=repositories&q=activeadmin&type=source).
@@ -67,7 +76,7 @@ Or consider offering me a coffee, it's a small thing but it is greatly appreciat
 
 ## Contributors
 
-- [Mattia Roccoberton](http://blocknot.es): author
+- [Mattia Roccoberton](https://blocknot.es): author
 - The good guys that opened issues and pull requests from time to time
 
 ## License

activeadmin_medium_editor.gemspec

@@ -14,9 +14,18 @@ Gem::Specification.new do |spec|
   spec.email         = 'mat@blocknot.es'
   spec.homepage      = 'https://github.com/blocknotes/activeadmin_medium_editor'
 
+  spec.required_ruby_version = '>= 2.6.0'
+
+  spec.metadata['homepage_uri']    = spec.homepage
+  spec.metadata['changelog_uri']   = 'https://github.com/blocknotes/activeadmin_medium_editor/blob/master/CHANGELOG.md'
+  spec.metadata['source_code_uri'] = spec.homepage
+
+  spec.metadata['rubygems_mfa_required'] = 'true'
+
   spec.files         = Dir['{app,lib}/**/*', 'LICENSE.txt', 'Rakefile', 'README.md']
   spec.require_paths = ['lib']
 
   spec.add_runtime_dependency 'activeadmin', '~> 2.0'
-  spec.add_runtime_dependency 'sassc', '~> 2.4'
+
+  spec.add_development_dependency 'appraisal', '~> 2.4'
 end