chore(settings): improve convert_value error handling

Author: blocknotes

lib/tiny_admin/settings.rb

@@ -109,12 +109,18 @@ def convert_value(key, value)
         value.each_key do |key2|
           path = [key, key2]
           if (DEFAULTS[path].is_a?(Class) || DEFAULTS[path].is_a?(Module)) && self[key][key2].is_a?(String)
-            self[key][key2] = Object.const_get(self[key][key2])
+            self[key][key2] = resolve_class(self[key][key2], setting: "#{key}.#{key2}")
           end
         end
       elsif value.is_a?(String) && (DEFAULTS[[key]].is_a?(Class) || DEFAULTS[[key]].is_a?(Module))
-        self[key] = Object.const_get(self[key])
+        self[key] = resolve_class(self[key], setting: key.to_s)
       end
     end
+
+    def resolve_class(class_name, setting:)
+      Object.const_get(class_name)
+    rescue NameError => e
+      raise NameError, "TinyAdmin: invalid class '#{class_name}' for setting '#{setting}' - #{e.message}"
+    end
   end
 end

spec/lib/tiny_admin/settings_spec.rb

@@ -59,6 +59,16 @@
       settings[:root_path] = "/admin"
       expect(settings[:root_path]).to eq("/admin")
     end
+
+    it "raises a descriptive error for invalid class names" do
+      expect { settings[:helper_class] = "NonExistent::Klass" }
+        .to raise_error(NameError, /TinyAdmin: invalid class 'NonExistent::Klass' for setting 'helper_class'/)
+    end
+
+    it "raises a descriptive error for invalid nested class names" do
+      expect { settings[:authentication] = { plugin: "NonExistent::Auth" } }
+        .to raise_error(NameError, /TinyAdmin: invalid class 'NonExistent::Auth' for setting 'authentication.plugin'/)
+    end
   end
 
   describe "dynamic option methods" do