fix: Detect static expressions better.

Now all non-static expressions are also allowed as
initializers. They are just a hiden lazy LET

Author: boriel

src/api/check.py

@@ -160,7 +160,7 @@ def check_call_arguments(lineno: int, id_: str, args: symbols.ARGLIST, filename:
             return False
 
         if param.byref:
-            if not isinstance(arg.value, (symbols.ID, symbols.ARRAYLOAD)):
+            if not isinstance(arg.value, symbols.ID | symbols.ARRAYLOAD):
                 errmsg.error(
                     lineno, "Expected a variable name, not an expression (parameter By Reference)", fname=arg.filename
                 )
@@ -310,11 +310,31 @@ def is_CONST(*p: symbols.SYMBOL) -> bool:
     return is_SYMBOL("CONSTEXPR", *p)
 
 
+def _is_static_unary(x: symbols.SYMBOL) -> bool:
+    if x.token != "UNARY":
+        return False
+
+    if x.operator != "ADDRESS":
+        return False
+
+    if x.operand.token == "LABEL":
+        return True
+
+    if x.operand.token in ("ID", "VAR"):
+        return x.operand.scope == SCOPE.global_
+
+    if x.operand.token == "ARRAYACCESS":
+        return is_static(*(arg.value for arg in x.operand.args))
+
+    return False
+
+
 def is_static(*p: symbols.SYMBOL) -> bool:
     """A static value (does not change at runtime)
     which is known at compile time
     """
-    return all(is_CONST(x) or is_number(x) or is_const(x) for x in p)
+    assert all(isinstance(x, symbols.SYMBOL) for x in p)
+    return all(is_CONST(x) or is_number(x) or is_const(x) or _is_static_unary(x) for x in p)
 
 
 def is_number(*p):

src/zxbc/zxbparser.py

@@ -246,7 +246,7 @@ def make_builtin(
     type_: sym.TYPE | None = None,
 ) -> sym.BUILTIN | sym.NUMBER:
     """Wrapper: returns a Builtin function node.
-    Can be a Symbol, tuple or list of Symbols
+    Can be a Symbol, tuple, or list of Symbols
     If operand is an iterable, they will be expanded.
     """
     if operands is None:
@@ -736,9 +736,8 @@ def p_var_decl_ini(p):
     if expr is None:
         return
 
-    if not is_static(expr):
-        if isinstance(expr, sym.UNARY):
-            expr = make_constexpr(p.lineno(4), expr)  # Delayed constant evaluation
+    if is_static(expr) and isinstance(expr, sym.UNARY):
+        expr = make_constexpr(p.lineno(4), expr)  # Delayed constant evaluation
 
     if typedef.implicit:
         typedef = sym.TYPEREF(expr.type_, p.lexer.lineno, implicit=True)