[REVIEW ONLY] Fix brackets issue #2872- "Windows: Brackets may fail to launch on a very clean OS image"

[core-ai-bot]

Issue by bchintx
Thursday Feb 20, 2014 at 23:46 GMT
Originally opened as adobe#424

---

Fix brackets issue #2872- "Windows: Brackets may fail to launch on a very clean OS image"

Adds Microsoft C runtime library merge module to the WiX script used to produce the Windows installer .msi.

---

bchintx included the following code: https://github.com/adobe/brackets-shell/pull/424/commits

[core-ai-bot]

Comment by bchintx
Thursday Feb 20, 2014 at 23:47 GMT

---

I still need to confirm that this merge module alone is sufficient. I need to build a clean Windows machine on which to test this. Unfortunately, the standard virtual machine images that we have for testing appear to already have the C runtime libraries installed.

[core-ai-bot]

Comment by JeffryBooher
Wednesday Jun 04, 2014 at 17:41 GMT

---

@bchintx should you close this or maybe test it on a clean vm and see if it's actually needed?

[core-ai-bot]

Comment by bchintx
Wednesday Jun 04, 2014 at 21:38 GMT

---

@JeffryBooher I've been meaning to build a new Windows machine to test this. Unfortunately, our VMs are not viable test platforms since they already have the C runtime libraries installed.