refac

Author: richardelms

bugsnag/src/main/java/com/bugsnag/BugsnagAppender.java

@@ -19,6 +19,7 @@
 import java.net.Proxy;
 import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.Collection;
 import java.util.Collections;
 import java.util.HashSet;
 import java.util.List;
@@ -262,12 +263,7 @@ private Bugsnag createBugsnag() {
             bugsnag.setRedactedKeys(redactedKeys.toArray(new String[0]));
         }
 
-        Pattern[] discardPatterns = new Pattern[discardClasses.size()];
-        int idx = 0;
-        for (String pattern : discardClasses) {
-            discardPatterns[idx++] = Pattern.compile(pattern);
-        }
-        bugsnag.setDiscardClasses(discardPatterns);
+        bugsnag.setDiscardClasses(compileDiscardPatterns(discardClasses));
 
         if (!enabledReleaseStages.isEmpty()) {
             bugsnag.setEnabledReleaseStages(enabledReleaseStages.toArray(new String[0]));
@@ -298,6 +294,21 @@ public boolean onError(Report report) {
         return bugsnag;
     }
 
+    /**
+     * Compiles a collection of pattern strings into an array of Pattern objects.
+     *
+     * @param patternStrings the collection of pattern strings to compile
+     * @return an array of compiled Pattern objects
+     */
+    private Pattern[] compileDiscardPatterns(Collection<String> patternStrings) {
+        Pattern[] patterns = new Pattern[patternStrings.size()];
+        int idx = 0;
+        for (String pattern : patternStrings) {
+            patterns[idx++] = Pattern.compile(pattern);
+        }
+        return patterns;
+    }
+
     /**
      * Add a callback to execute code before/after every notification to Bugsnag.
      *
@@ -417,12 +428,7 @@ public void setDiscardClass(String discardClass) {
         this.discardClasses.add(discardClass);
 
         if (bugsnag != null) {
-            Pattern[] discardPatterns = new Pattern[this.discardClasses.size()];
-            int idx = 0;
-            for (String pattern : this.discardClasses) {
-                discardPatterns[idx++] = Pattern.compile(pattern);
-            }
-            bugsnag.setDiscardClasses(discardPatterns);
+            bugsnag.setDiscardClasses(compileDiscardPatterns(this.discardClasses));
         }
     }
 
@@ -433,12 +439,7 @@ public void setDiscardClasses(String discardClasses) {
         this.discardClasses.addAll(split(discardClasses));
 
         if (bugsnag != null) {
-            Pattern[] discardPatterns = new Pattern[this.discardClasses.size()];
-            int idx = 0;
-            for (String pattern : this.discardClasses) {
-                discardPatterns[idx++] = Pattern.compile(pattern);
-            }
-            bugsnag.setDiscardClasses(discardPatterns);
+            bugsnag.setDiscardClasses(compileDiscardPatterns(this.discardClasses));
         }
     }