Skip to content

Commit 218ea9b

Browse files
authored
Build Android binaries with a larger page size (#12246)
Apparently Google says we should do this. Also apparently Google's version of the NDK doesn't do this by default. Thread the needle by manually passing it. Closes #12220
1 parent fe12d38 commit 218ea9b

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

ci/build-build-matrix.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,10 @@ const array = [
6868
"build": "aarch64-android",
6969
"os": ubuntu,
7070
"target": "aarch64-linux-android",
71+
// See https://developer.android.com/guide/practices/page-sizes
72+
// for some more commentary, but apparently Google recommends passing this
73+
// linker flag.
74+
"env": { "RUSTFLAGS": "-Clink-arg=-z -Clink-arg=max-page-size=16384" },
7175
},
7276
{
7377
"build": "x86_64-android",

0 commit comments

Comments
 (0)