-
-
Notifications
You must be signed in to change notification settings - Fork 21
disconnect paths silently swallow errors #351
Copy link
Copy link
Open
Labels
bluetoothBluetooth device/adapter managementBluetooth device/adapter managementbugSomething isn't workingSomething isn't workingnmrsChanges to nmrsChanges to nmrsvpnChanges to VPN surfaceChanges to VPN surface
Metadata
Metadata
Assignees
Labels
bluetoothBluetooth device/adapter managementBluetooth device/adapter managementbugSomething isn't workingSomething isn't workingnmrsChanges to nmrsChanges to nmrsvpnChanges to VPN surfaceChanges to VPN surface
several disconnect/deactivation paths discard errors and return
Ok(()), making it impossible for callers to know if the operation actually succeeded.disconnect_vpn—core/vpn.rs:282-286:if
deactivate_connectionfails, it logs a warning and returnsOk(()). caller thinks vpn disconnected when it may not have.bluetooth disconnect —
core/bluetooth.rs:226-227:dbus error from
Disconnectis fully discarded.ensure_disconnected—core/connection.rs:535-558:deactivates all active connections (including vpn, wired — not just wifi) when switching wifi, and swallows per-connection deactivation failures with
warn!. this is also overbroad — it tears down non-wifi connections as a side effect.