Added Timespan for easily tracking lock time.

Author: cajuncoding

SqlAppLockHelper.Common/SqlAppLockHelper.Common.csproj

@@ -6,13 +6,17 @@
     <Authors>BBernard / CajunCoding</Authors>
     <Company>CajunCoding</Company>
     <Product>SqlAppLockHelper</Product>
-    <Description>The Common libraries for SqlAppLockHelper; You should install SqlAppLockHelper.SystemData or SqlAppLockHelper.MicrosoftData depending on which SqlClient liberaries are in use in your project.</Description>
+    <Description>The Common libraries for SqlAppLockHelper; a library for easily using Sql Server built in support for robust distributed mutex / applicaiton locking capabilities. You should install SqlAppLockHelper.SystemData or SqlAppLockHelper.MicrosoftData depending on which SqlClient liberaries are in use in your project.</Description>
     <Copyright>Copyright © 2020</Copyright>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
     <PackageProjectUrl>https://github.com/cajuncoding/SqlAppLockHelper</PackageProjectUrl>
     <RepositoryUrl>https://github.com/cajuncoding/SqlAppLockHelper</RepositoryUrl>
     <PackageTags>sp_getapplock, sp_releaseapplock, distributed-locking, distributed-lock-algorithm, app-locking, application-locking, sql, sqlserver, sql-server, sqlclient, locking, application-lock, application-lock-system, transactional-outbox-pattern, azurefunctions, azure-functions, serverless</PackageTags>
-    <PackageReleaseNotes>Initial release of Async/Sync support for System.Data &amp; Microsoft.Data namespace.</PackageReleaseNotes>
+    <PackageReleaseNotes>- Improve stability for Disposing, removing unnecessary exception warnings as locks are released when Connections are disposed/closed. Added explicit Release() &amp; ReleaseAsync() methods, updated tests, and added Timespan for easily tracking lock time.
+
+Prior Release Notes:
+- Initial release of Async/Sync support for System.Data &amp; Microsoft.Data namespace.</PackageReleaseNotes>
+    <Version>1.0.1</Version>
   </PropertyGroup>
 
 </Project>

SqlAppLockHelper.Common/SqlServerAppLock.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Text;
 using System.Threading.Tasks;
 
@@ -11,13 +12,16 @@ public class SqlServerAppLock : IDisposable, IAsyncDisposable
         //      namespaces, reducing duplication.
         private Func<ValueTask> _releaseActionAsync = null;
         private Action _releaseAction = null;
+        private Stopwatch _lockTimer = new Stopwatch();
 
         public string LockName { get; }
 
         public SqlServerAppLockScope LockScope { get; }
 
         public SqlServerAppLockAcquisitionResult LockAcquisitionResult { get; }
 
+        public TimeSpan LockElapsedTime => _lockTimer.Elapsed;
+
         public SqlServerAppLock(
             string lockName, 
             SqlServerAppLockScope scope, 
@@ -32,6 +36,10 @@ public SqlServerAppLock(
             LockScope = scope;
             LockAcquisitionResult = lockAcquisitionResult;
 
+            //Start the Lock Timer ONLY if Lock was Acquired!
+            if(this.IsLockAcquired)
+                _lockTimer.Start();
+
             //Initialize Sync & Async callbacks for Disposal!
             //NOTE: Using Delegates here allows this class to be independent of Microsoft.Data/System.Data
             //      namespaces, reducing duplication.
@@ -56,6 +64,8 @@ public async Task ReleaseAsync()
             {
                 await _releaseActionAsync.Invoke();
                 _releaseActionAsync = null;
+
+                _lockTimer.Stop();
             }
         }
 
@@ -66,8 +76,12 @@ public async Task ReleaseAsync()
         /// </summary>
         public void Release()
         {
-            _releaseAction?.Invoke();
-            _releaseAction = null;
+            if (_releaseAction != null)
+            {
+                _releaseAction.Invoke();
+                _releaseAction = null;
+                _lockTimer.Stop();
+            }
         }
 
         /// <summary>
@@ -83,6 +97,7 @@ public void Dispose()
                 Release();
             }
 
+            _lockTimer.Stop();
             IsDisposed = true;
         }
 
@@ -99,6 +114,7 @@ public async ValueTask DisposeAsync()
                 await ReleaseAsync();
             }
 
+            _lockTimer.Stop();
             IsDisposed = true;
         }
     }

SqlAppLockHelper.Tests/MicrosoftDataConnectionAppLockTests.cs

@@ -40,6 +40,10 @@ public async Task TestAsyncConnectionAppLockAcquisitionExceptionsDisabled()
             Assert.AreEqual(appLockFailWhileLocked.LockAcquisitionResult, SqlServerAppLockAcquisitionResult.FailedDueToTimeout);
             Assert.IsFalse(string.IsNullOrWhiteSpace(appLockFailWhileLocked.LockName));
 
+            //Check App Lock Elapsed Timers!
+            Assert.IsTrue(appLock.LockElapsedTime.TotalMilliseconds > 0);
+            Assert.IsTrue(appLockFailWhileLocked.LockElapsedTime.TotalMilliseconds == 0);
+
             //Force Release the Lock!
             await appLock.DisposeAsync();
 
@@ -56,6 +60,7 @@ public async Task TestAsyncConnectionAppLockAcquisitionExceptionsDisabled()
             Assert.IsNotNull(appLockAfterRelease);
             Assert.AreEqual(appLockAfterRelease.LockAcquisitionResult, SqlServerAppLockAcquisitionResult.AcquiredImmediately);
             Assert.IsFalse(string.IsNullOrWhiteSpace(appLockAfterRelease.LockName));
+            Assert.IsTrue(appLockAfterRelease.LockElapsedTime.TotalMilliseconds > 0);
         }
 
         [TestMethod]

SqlAppLockHelper.Tests/SystemDataConnectionAppLockTests.cs

@@ -40,6 +40,10 @@ public async Task TestAsyncConnectionAppLockAcquisitionExceptionsDisabled()
             Assert.AreEqual(appLockFailWhileLocked.LockAcquisitionResult, SqlServerAppLockAcquisitionResult.FailedDueToTimeout);
             Assert.IsFalse(string.IsNullOrWhiteSpace(appLockFailWhileLocked.LockName));
 
+            //Check App Lock Elapsed Timers!
+            Assert.IsTrue(appLock.LockElapsedTime.TotalMilliseconds > 0);
+            Assert.IsTrue(appLockFailWhileLocked.LockElapsedTime.TotalMilliseconds == 0);
+
             //Force Release the Lock!
             await appLock.DisposeAsync();
 
@@ -56,6 +60,7 @@ public async Task TestAsyncConnectionAppLockAcquisitionExceptionsDisabled()
             Assert.IsNotNull(appLockAfterRelease);
             Assert.AreEqual(appLockAfterRelease.LockAcquisitionResult, SqlServerAppLockAcquisitionResult.AcquiredImmediately);
             Assert.IsFalse(string.IsNullOrWhiteSpace(appLockAfterRelease.LockName));
+            Assert.IsTrue(appLockAfterRelease.LockElapsedTime.TotalMilliseconds > 0);
         }
 
         [TestMethod]