Skip to content

Commit 49875d5

Browse files
committed
Added Changes in Acheivement Controller and Interview Service
1 parent 16d8edf commit 49875d5

4 files changed

Lines changed: 3 additions & 45 deletions

File tree

src/controllers/achievement.controller.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,6 @@ import { ApiError } from "../utils/apiError";
77
export const getAchievements = async (req: Request, res: Response) => {
88
const achievements = await achievementService.getAchievements();
99

10-
if (!achievements || achievements.length === 0) {
11-
throw new ApiError("No achievements found", 404);
12-
}
13-
1410
res.status(200).json({
1511
success: true,
1612
count: achievements.length,

src/routes/index.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@ import progressRouter from './progress'
1111
export default function routes(upload: Multer, supabase: SupabaseClient) {
1212
const router = Router();
1313

14-
// router.use('/members', membersRouter(upload, supabase))
1514

1615
router.use('/projects', projectsRouter(upload, supabase))
17-
// router.use('/projects', projectsRouter(upload, supabase))
16+
1817
router.use('/achievements' ,acheivementsRouter(upload, supabase));
18+
1919
router.use('/interviews', interviewRouter(upload, supabase));
20-
// … mount other routers, just write xyzRouter() if the routes in that router don't need multer or supabase
20+
2121

2222
router.use('/topics',topicRouter());
2323

src/services/interview.service.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { prisma } from "../db/client"
2-
// import { InterviewCreateInput, InterviewUpdateInput } from "../types/interview.types";
32

43
export const getInterviews = async () => {
54
return await prisma.interviewExperience.findMany({

tests/Achievement.test.ts

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -187,43 +187,6 @@ describe('getAchievements', () => {
187187
});
188188

189189

190-
describe('getAchievements', () => {
191-
it('should return 200 and all achievements', async () => {
192-
const req: any = {};
193-
194-
const res: any = {
195-
status: jest.fn().mockReturnThis(),
196-
json: jest.fn(),
197-
};
198-
199-
const mockAchievements = [
200-
{
201-
id: 1,
202-
title: 'Maze Master',
203-
description: 'Completed the final maze',
204-
achievedAt: new Date('2025-07-19T10:00:00.000Z'),
205-
imageUrl: 'https://example.com/maze.png',
206-
createdById: 'admin_123',
207-
createdAt: new Date(),
208-
updatedById: null,
209-
updatedAt: new Date(),
210-
},
211-
];
212-
213-
jest.spyOn(achievementService, 'getAchievements').mockResolvedValue(mockAchievements);
214-
215-
await getAchievements(req, res);
216-
217-
expect(res.status).toHaveBeenCalledWith(200);
218-
expect(res.json).toHaveBeenCalledWith({
219-
success: true,
220-
count: mockAchievements.length,
221-
data: mockAchievements,
222-
});
223-
});
224-
});
225-
226-
227190
describe('getAchievementById', () => {
228191
it('should return 200 and the achievement with given ID', async () => {
229192
const req: any = {

0 commit comments

Comments
 (0)