optimize the code

Author: samrth07

src/config/index.ts

@@ -1,5 +1,3 @@
-console.log(process.env.DIRECT_URL)
-
 export default {
   PORT: process.env.PORT,
   DATABASE_URL: process.env.DATABASE_URL!,

src/controllers/project.controller.ts

@@ -1,11 +1,12 @@
 import * as projectService from "../services/project.service";
 import { Request ,  Response } from "express";
 import { ApiError } from "../utils/apiError";
+import { error } from "console";
 
 export const getProjects = async ( req : Request , res : Response ) => {
 
         try {
-                const projects = await projectService.getPrjects();
+                const projects = await projectService.getProjects();
                 res.status(200).json(projects);
         } catch (error) {
                 throw new ApiError( "No project found !!!" , 500)
@@ -17,6 +18,7 @@ export const getProjectById = async ( req : Request , res : Response ) => {
         try{
             const projectId = parseInt( req.params.projectId );
             if( !projectId ) throw new ApiError( " Field is missing !!!" , 400);
+
             const project = await projectService.getProjectById( projectId );
             res.status(200).json(project);
 
@@ -28,13 +30,9 @@ export const getProjectById = async ( req : Request , res : Response ) => {
 export const createProject = async ( req : Request , res : Response ) => {
 
         try {
-                    const projectContent = {
-                        name: req.body.name,
-                        imageUrl: req.body.imageUrl,
-                        githubUrl: req.body.githubUrl,
-                        deployUrl: req.body.deployUrl,
-                        adminId: req.AdminId,
-                    };
+                    const projectContent = req.body;
+
+                    if( !projectContent.name || !projectContent.githubUrl) throw new ApiError( " Field is missing !!!" , 400);
 
                 const project = await projectService.createProject(projectContent);
                 res.status(200).json(project);
@@ -66,12 +64,10 @@ export const deleteProjects = async ( req : Request , res : Response ) => {
              const projectId = parseInt(req.params.projectId);
             if( !projectId ) throw new ApiError( " Send The project id " , 400);
 
-
             const deleted = await projectService.deleteProjects( projectId );
             res.status(200).json(deleted)
 
     } catch (error) {
-        console.log(error)
             throw new ApiError( error as string , 500);
     }
 
@@ -81,7 +77,6 @@ export const getMembersByProjectId = async ( req : Request , res : Response ) =>
 
     try {
                 const projectId = parseInt( req.params.ProjectId );
-
                 if( !projectId ) throw new ApiError( " Project Id required !!! " , 400);  
 
                 const members = await projectService.getMembersByProjectId(projectId);
@@ -98,15 +93,19 @@ export const getMembersByProjectId = async ( req : Request , res : Response ) =>
 export const addMembers = async ( req : Request , res : Response ) => {
 
     try {
-            const data = {
-                projectId : parseInt ( req.params.projectId ),
-                memberId :  req.body.memberId 
-            }
+                const  projectId = parseInt( req.params.projectId );
+                const memberData = req.body.memberId;
+                if( !projectId || memberData.length === 0) throw new ApiError(" field is missing " , 400);
+
+                const data  = memberData.map( (memberId: string) => ({
+                projectId,
+                memberId
+            }))
 
              const member = await projectService.addMembers( data );
-            res.status(200).json(member)
+            res.status(200).json(member);
+
     } catch (error) {
-        console.log(error)
           throw new ApiError( error as string , 500);
     }
 }

src/services/project.service.ts

@@ -1,15 +1,15 @@
 import { prisma } from "../db/client";
 
 
-export const getPrjects = async () => {
+export const getProjects = async () => {
         return await prisma.project.findMany({})
 };
 
 
 
 export const getProjectById = async ( projectId : number ) => {
 
-        return await prisma.project.findFirst({
+        return await prisma.project.findUniqueOrThrow({
             where : {
                 id : projectId
             }
@@ -24,7 +24,7 @@ export const createProject = async ( projectContent : projectContent ) => {
             imageUrl : projectContent.imageUrl,
             githubUrl : projectContent.githubUrl,
             deployUrl : projectContent.deployUrl,
-        }
+        },
     })
    };
 
@@ -59,11 +59,9 @@ export const getMembersByProjectId = async ( projectId : number ) => {
 
 export const addMembers = async ( addMembersData : addMembersData ) => {
 
-    return await prisma.memberProject.create({
-        data :{
-            memberId : addMembersData.memberId,
-            projectId : addMembersData.projectId,
-        }
+    return await prisma.memberProject.createMany({
+        data : addMembersData,
+        skipDuplicates : true
     })
 }
 

src/types/project.d.ts

@@ -6,9 +6,9 @@ declare global {
 
     type projectContent = {
         name: string,
-        imageUrl: string,
+        imageUrl: string ?,
         githubUrl: string,
-        deployUrl: string,
+        deployUrl: string?,
     }
 
     type addMembersData = {