Some fixes in update acheivement controller

Author: Sherin-2711

src/controllers/achievement.controller.ts

@@ -73,6 +73,7 @@ export const createAchievement = async (req: Request, res: Response) => {
 
 export const updateAchievementById = async (req: Request, res: Response) => {
   const achievementId = parseInt(req.params.achievementId);
+
   if (!achievementId || isNaN(achievementId)) {
     throw new ApiError("Invalid achievement ID", 400);
   }
@@ -81,7 +82,7 @@ export const updateAchievementById = async (req: Request, res: Response) => {
   let imageUrl: string | undefined;
 
   let achievementData = req.body.achievementData;
-  if (typeof achievementData === 'string') {
+  if (typeof achievementData === "string") {
     try {
       achievementData = JSON.parse(achievementData);
     } catch (e) {
@@ -95,33 +96,31 @@ export const updateAchievementById = async (req: Request, res: Response) => {
     throw new ApiError("updatedById is required", 400);
   }
 
-  
   const existingAchievement = await achievementService.getAchievementById(achievementId);
   if (!existingAchievement) {
     throw new ApiError("Achievement not found", 404);
   }
-  
+
   if (file) {
-    imageUrl = await uploadImage(supabase, file, 'achievements', existingAchievement.imageUrl );
+    imageUrl = await uploadImage(supabase, file, "achievements", existingAchievement.imageUrl);
   }
-  
+
+  const { memberIds: _, ...updatePayload } = achievementData;
+
   if (imageUrl) {
-    achievementData.imageUrl = imageUrl;
-  }
-  
-    if (
-      !title &&
-      !description &&
-      !achievedAt &&
-      !imageUrl &&
-      (!Array.isArray(memberIds) || memberIds.length === 0)
-    ) {
-      throw new ApiError("At least one field must be provided for update", 400);
-    }
-    
+    updatePayload.imageUrl = imageUrl;
+  }
+
+  const hasSomethingToUpdate =
+    title || description || achievedAt || imageUrl || (Array.isArray(memberIds) && memberIds.length > 0);
+
+  if (!hasSomethingToUpdate) {
+    throw new ApiError("At least one field (title, description, achievedAt, image, or memberIds) must be provided for update", 400);
+  }
+
   const updatedAchievement = await achievementService.updateAchievementById(
     achievementId,
-    achievementData
+    updatePayload
   );
 
   if (Array.isArray(memberIds) && memberIds.length > 0) {