Improvements

Author: amaitland

CefSharp.OutOfProcess.Core/IChromiumWebBrowser.cs

@@ -7,7 +7,7 @@ namespace CefSharp.OutOfProcess
     /// <summary>
     /// OutOfProcess ChromiumWebBrowser
     /// </summary>
-    public interface IChromiumWebBrowser
+    public interface IChromiumWebBrowser : IDisposable
     {
         /// <summary>
         /// Occurs when the browser address changed.
@@ -97,6 +97,11 @@ public interface IChromiumWebBrowser
         /// </summary>
         event EventHandler<RequestEventArgs> NetworkRequestServedFromCache;
 
+        /// <summary>
+        /// Fired for top level page lifecycle events such as navigation, load, paint, etc.
+        /// </summary>
+        event EventHandler<LifecycleEventArgs> LifecycleEvent;
+
         /// <summary>
         /// Raised when a <see cref="NetworkResponse"/> is received.
         /// </summary>

CefSharp.OutOfProcess.Core/OutOfProcessHost.cs

@@ -34,21 +34,55 @@ private OutOfProcessHost(string path)
             _outofProcessFilePath = path;
         }
 
+        /// <summary>
+        /// UI Thread assocuated with this <see cref="OutOfProcessHost"/>
+        /// </summary>
+        public int UiThreadId
+        {
+            get { return _uiThreadId; }
+        }
+
+        /// <summary>
+        /// Thread Id of the UI Thread running in the Browser Process
+        /// </summary>
+        public int RemoteUiThreadId
+        {
+            get { return _remoteuiThreadId; }
+        }
+
+        /// <summary>
+        /// CefSharp Version
+        /// </summary>
         public string CefSharpVersion
         {
             get { return _cefSharpVersion; }
         }
 
+        /// <summary>
+        /// Cef Version
+        /// </summary>
         public string CefVersion
         {
             get { return _cefVersion; }
         }
 
+        /// <summary>
+        /// Chromium Version
+        /// </summary>
         public string ChromiumVersion
         {
             get { return _chromiumVersion; }
         }
 
+        /// <summary>
+        /// Sends an IPC message to the Browser Process instructing it
+        /// to create a new Out of process browser
+        /// </summary>
+        /// <param name="browser">The <see cref="IChromiumWebBrowserInternal"/> that will host the browser</param>
+        /// <param name="handle">handle used to host the control</param>
+        /// <param name="url"></param>
+        /// <param name="id"></param>
+        /// <returns></returns>
         public bool CreateBrowser(IChromiumWebBrowserInternal browser, IntPtr handle, string url, out int id)
         {
             id = _browserIdentifier++;

CefSharp.OutOfProcess.WinForms/ChromiumWebBrowser.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Drawing;
-using System.Net;
 using System.Threading.Tasks;
 using System.Windows.Forms;
 using CefSharp.OutOfProcess.Internal;
@@ -19,6 +18,7 @@ public class ChromiumWebBrowser : Control, IChromiumWebBrowserInternal
         private int _id;
         private IDevToolsContext _devToolsContext;
         private OutOfProcessConnectionTransport _devToolsContextConnectionTransport;
+        private bool _devToolsReady;
 
         /// <inheritdoc/>
         public event EventHandler DOMContentLoaded;
@@ -56,6 +56,8 @@ public class ChromiumWebBrowser : Control, IChromiumWebBrowserInternal
         public event EventHandler<StatusMessageEventArgs> StatusMessage;
         /// <inheritdoc/>
         public event EventHandler<ConsoleEventArgs> ConsoleMessage;
+        /// <inheritdoc/>
+        public event EventHandler<LifecycleEventArgs> LifecycleEvent;
 
         public ChromiumWebBrowser(OutOfProcessHost host, string initialAddress)
         {
@@ -81,6 +83,22 @@ protected override Size DefaultSize
             get { return new Size(640, 480); }
         }
 
+        /// <summary>
+        /// DevToolsContext - provides communication with the underlying browser
+        /// </summary>
+        public IDevToolsContext DevToolsContext
+        {
+            get
+            {
+                if (_devToolsReady)
+                {
+                    return _devToolsContext;
+                }
+
+                return default;
+            }
+        }
+
         /// <inheritdoc/>
         public bool IsBrowserInitialized => _browserHwnd != IntPtr.Zero;
 
@@ -104,8 +122,8 @@ protected override void OnHandleCreated(EventArgs e)
 
             _devToolsContextConnectionTransport = new OutOfProcessConnectionTransport(_id, _host);
 
-            var connection = Connection.Attach(_devToolsContextConnectionTransport);
-            _devToolsContext = DevToolsContext.CreateForOutOfProcess(connection);
+            var connection = DevToolsConnection.Attach(_devToolsContextConnectionTransport);
+            _devToolsContext = Puppeteer.DevToolsContext.CreateForOutOfProcess(connection);
         }
 
         /// <inheritdoc/>
@@ -239,6 +257,8 @@ void IChromiumWebBrowserInternal.OnDevToolsMessage(string jsonMsg)
         /// <inheritdoc/>
         void IChromiumWebBrowserInternal.OnDevToolsReady()
         {
+            _devToolsReady = true;
+
             var ctx = (DevToolsContext)_devToolsContext;
 
             ctx.DOMContentLoaded += DOMContentLoaded;