Added more linting tests

olehermanse · claude · olehermanse · commit f64432e29ef3 · 2026-03-30T18:53:24.000+02:00
Co-authored-by: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
Signed-off-by: Ole Herman Schumacher Elgesem &lt;ole.elgesem@northern.tech&gt;
diff --git a/tests/lint/003_deprecated_promise_type.cf b/tests/lint/003_deprecated_promise_type.cf
@@ -0,0 +1,5 @@
+bundle agent main
+{
+  vars:
+    "x" string => "value";
+}
diff --git a/tests/lint/003_deprecated_promise_type.output.txt b/tests/lint/003_deprecated_promise_type.output.txt
@@ -0,0 +1,7 @@
+
+{
+  defaults:
+  ^-------^
+Deprecation: Promise type 'defaults' is deprecated at tests/lint/003_deprecated_promise_type.x.cf:3:3
+FAIL: tests/lint/003_deprecated_promise_type.x.cf (1 errors)
+Failure, 1 errors in total.
diff --git a/tests/lint/003_deprecated_promise_type.x.cf b/tests/lint/003_deprecated_promise_type.x.cf
@@ -0,0 +1,5 @@
+bundle agent main
+{
+  defaults:
+    "x" string => "value";
+}
diff --git a/tests/lint/004_bundle_name_lowercase.cf b/tests/lint/004_bundle_name_lowercase.cf
@@ -0,0 +1,5 @@
+bundle agent my_bundle
+{
+  reports:
+    "Hello";
+}
diff --git a/tests/lint/004_bundle_name_lowercase.output.txt b/tests/lint/004_bundle_name_lowercase.output.txt
@@ -0,0 +1,6 @@
+
+bundle agent MyBundle
+             ^------^
+Convention: Bundle name should be lowercase at tests/lint/004_bundle_name_lowercase.x.cf:1:14
+FAIL: tests/lint/004_bundle_name_lowercase.x.cf (1 errors)
+Failure, 1 errors in total.
diff --git a/tests/lint/004_bundle_name_lowercase.x.cf b/tests/lint/004_bundle_name_lowercase.x.cf
@@ -0,0 +1,5 @@
+bundle agent MyBundle
+{
+  reports:
+    "Hello";
+}
diff --git a/tests/lint/005_bundle_type.cf b/tests/lint/005_bundle_type.cf
@@ -0,0 +1,5 @@
+bundle common my_bundle
+{
+  vars:
+    "x" string => "value";
+}
diff --git a/tests/lint/005_bundle_type.output.txt b/tests/lint/005_bundle_type.output.txt
@@ -0,0 +1,6 @@
+
+bundle notavalidtype my_bundle
+       ^-----------^
+Error: Bundle type must be one of (agent, common, monitor, server, edit_line, edit_xml), not 'notavalidtype' at tests/lint/005_bundle_type.x.cf:1:8
+FAIL: tests/lint/005_bundle_type.x.cf (1 errors)
+Failure, 1 errors in total.
diff --git a/tests/lint/005_bundle_type.x.cf b/tests/lint/005_bundle_type.x.cf
@@ -0,0 +1,5 @@
+bundle notavalidtype my_bundle
+{
+  reports:
+    "Hello";
+}
diff --git a/tests/lint/006_syntax_error.cf b/tests/lint/006_syntax_error.cf
@@ -0,0 +1,5 @@
+bundle agent main
+{
+  reports:
+    "Valid syntax";
+}
diff --git a/tests/lint/006_syntax_error.output.txt b/tests/lint/006_syntax_error.output.txt
@@ -0,0 +1,7 @@
+
+{
+  reports
+  ^-----^
+Error: Syntax error at tests/lint/006_syntax_error.x.cf:3:3
+FAIL: tests/lint/006_syntax_error.x.cf (1 errors)
+Failure, 1 errors in total.
diff --git a/tests/lint/006_syntax_error.x.cf b/tests/lint/006_syntax_error.x.cf
@@ -0,0 +1,5 @@
+bundle agent main
+{
+  reports
+    "Missing colon after promise type";
+}
diff --git a/tests/lint/007_empty_file.output.txt b/tests/lint/007_empty_file.output.txt
@@ -0,0 +1,3 @@
+Error: Empty policy file 'tests/lint/007_empty_file.x.cf'
+FAIL: tests/lint/007_empty_file.x.cf (1 errors)
+Failure, 1 errors in total.
diff --git a/tests/lint/007_empty_file.x.cf b/tests/lint/007_empty_file.x.cf

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +bundle agent main
 +{
 +  vars:
 +    "x" string => "value";
 +}