Stop ignoring PHPCS warnings

Fix or ignore existing warnings

Author: gabriel-detassigny

php/class-delivery.php

@@ -1115,8 +1115,8 @@ function ( $tag ) use ( $content ) {
 				continue; // We should not deliver disabled items.
 			}
 
-			$base           = $type . ':' . $url;
-			$public_id      = ! is_admin() ? $relation['public_id'] . '.' . $relation['format'] : null;
+			$base      = $type . ':' . $url;
+			$public_id = ! is_admin() ? $relation['public_id'] . '.' . $relation['format'] : null;
 			// Get merged transformations including overlays.
 			$merged_transformations = Relate::get_transformations( $relation['post_id'], true );
 

php/class-utils.php

@@ -368,11 +368,11 @@ protected static function upgrade_install() {
 	protected static function get_upgrade_sequence() {
 		$upgrade_sequence = array();
 		$sequences        = array(
-			'3.0.0'  => array(
+			'3.0.0' => array(
 				'range'  => array( '3.0.0' ),
 				'method' => array( 'Cloudinary\Utils', 'upgrade_3_0_1' ),
 			),
-			'3.1.9'  => array(
+			'3.1.9' => array(
 				'range'  => array( '3.0.1', '3.1.9' ),
 				'method' => array( 'Cloudinary\Utils', 'upgrade_3_1_9' ),
 			),
@@ -1384,12 +1384,12 @@ public static function get_transformations_title( $context ) {
 	/**
 	 * Get inline SVG content safely.
 	 *
-	 * @param string $file_path The absolute or relative path to the SVG file.
-	 * @param bool   $echo      Whether to echo the SVG content or return it. Default true.
+	 * @param string $file_path      The absolute or relative path to the SVG file.
+	 * @param bool   $output_content Whether to echo the SVG content or return it. Default true.
 	 *
 	 * @return string|void The SVG content if $echo is false, void otherwise.
 	 */
-	public static function get_inline_svg( $file_path, $echo = true ) {
+	public static function get_inline_svg( $file_path, $output_content = true ) {
 		// If relative path, make it absolute from plugin root.
 		if ( ! file_exists( $file_path ) ) {
 			$plugin_dir = dirname( __DIR__ );
@@ -1402,7 +1402,7 @@ public static function get_inline_svg( $file_path, $echo = true ) {
 		}
 
 		// Get the SVG content.
-		$svg_content = file_get_contents( $file_path ); // phpcs:ignore WordPress.WP.AlternativeFunctions.file_get_contents_file_get_contents
+		$svg_content = file_get_contents( $file_path ); // phpcs:ignore WordPress.WP.AlternativeFunctions.file_get_contents_file_get_contents, WordPressVIPMinimum.Performance.FetchingRemoteData.FileGetContentsUnknown
 
 		if ( false === $svg_content ) {
 			return '';
@@ -1411,7 +1411,7 @@ public static function get_inline_svg( $file_path, $echo = true ) {
 		// Sanitize SVG content to prevent XSS attacks.
 		$svg_content = self::sanitize_svg( $svg_content );
 
-		if ( $echo ) {
+		if ( $output_content ) {
 			echo $svg_content; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- Sanitized by sanitize_svg.
 		} else {
 			return $svg_content;

php/ui/component/class-crops.php

@@ -279,7 +279,7 @@ protected function make_input( $name, $value ) {
 		$control['children']['input']  = $check;
 		$control['children']['slider'] = $slider;
 
-		$label          = $this->get_part( 'span' );
+		$label                        = $this->get_part( 'span' );
 		$label['attributes']['class'] = 'cld-input-on-off-control-label';
 		$label['content']             = __( 'Disable', 'cloudinary' );
 

phpcs.xml.dist

@@ -25,8 +25,6 @@
         <severity>5</severity>
     </rule>
 
-	<config name="ignore_warnings_on_exit" value="1" /><!-- Ignore warnings for now. -->
-
 	<file>.</file><!-- Lint all PHP files by default. -->
 
 	<arg name="basepath" value="." /><!-- Show file paths relative to the project root. -->