Implement volume detach (#33)

Author: René Moser

CHANGELOG.md

@@ -1,6 +1,13 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+## v1.1.0 (unreleased)
+
+### Minor changes
+
+- cloudscale-sdk updated to 0.5.0.
+- Add option `--detach` for volumes to detach.
+
 ## v1.0.1 (2020-10-09)
 
 Maintenance release.

cloudscale_cli/commands/volume.py

@@ -1,3 +1,4 @@
+import sys
 import click
 
 @click.group()
@@ -57,13 +58,22 @@ def cmd_create(cloudscale, name, server_uuids, size_gb, volume_type, zone, tags)
 @click.argument('uuid', required=True)
 @click.option('--name')
 @click.option('--server-uuids', multiple=True)
+@click.option('--detach', is_flag=True)
 @click.option('--size-gb', type=int)
 @click.option('--tag', 'tags', multiple=True)
 @click.option('--clear-tag', 'clear_tags', multiple=True)
 @click.option('--clear-all-tags', is_flag=True)
 @volume.command("update")
 @click.pass_obj
-def cmd_update(cloudscale, uuid, name, server_uuids, size_gb, tags, clear_tags, clear_all_tags):
+def cmd_update(cloudscale, uuid, name, server_uuids, size_gb, detach, tags, clear_tags, clear_all_tags):
+    # Unhandle server_uuids if not set
+    if not detach and not server_uuids:
+        server_uuids = None
+
+    elif server_uuids and detach:
+        click.echo("Error: --server-uuids and --detach are mutually exclusive", err=True)
+        sys.exit(1)
+
     cloudscale.cmd_update(
         uuid=uuid,
         tags=tags,

cloudscale_cli/version.py

@@ -1 +1 @@
-__version__ = '1.0.1'
+__version__ = '1.1.0'

requirements.txt

@@ -1,4 +1,4 @@
-cloudscale-sdk>=0.4.0
+cloudscale-sdk>=0.5.0
 click>=7.0.0
 tabulate
 pygments

tests/test_volume.py

@@ -228,3 +228,41 @@ def test_volume_missing_api_key():
         'list',
     ])
     assert result.exit_code == 1
+
+def test_volume_error_detach_server_uuids_mutually_exclusive():
+    uuid = "2db69ba3-1864-4608-853a-0771b6885a3a"
+    server_uuids = "2db69ba3-1864-4608-853a-0771b6885a3a"
+    runner = CliRunner()
+    result = runner.invoke(cli, [
+        '-a', 'token',
+        'volume',
+        'update',
+        uuid,
+        '--detach',
+        '--server-uuids',
+        server_uuids,
+    ])
+    assert result.exit_code == 1
+
+@responses.activate
+def test_volume_detach():
+    uuid = "2db69ba3-1864-4608-853a-0771b6885a3a"
+    responses.add(
+        responses.PATCH,
+        CLOUDSCALE_API_URL + '/volumes/' + uuid,
+        json=VOLUME_RESP,
+        status=204)
+    responses.add(
+        responses.GET,
+        CLOUDSCALE_API_URL + '/volumes/' + uuid,
+        json=VOLUME_RESP,
+        status=200)
+    runner = CliRunner()
+    result = runner.invoke(cli, [
+        '-a', 'token',
+        'volume',
+        'update',
+        uuid,
+        '--detach',
+    ])
+    assert result.exit_code == 0