Revert "Disable verify goal and e2e error message changes"

This reverts commit 2de8137.

Author: sgarg-CS

cloudsql-mysql-plugin/src/e2e-test/resources/errorMessage.properties

@@ -1,9 +1,9 @@
-errorMessageInvalidSourceDatabase=SQL Error occurred, sqlState: '42000', errorCode: '1049'
+errorMessageInvalidSourceDatabase=SQL error while getting query schema
 errorMessageInvalidImportQuery=Import Query select must contain the string '$CONDITIONS'. if Number of Splits is not set\
   \ to 1. Include '$CONDITIONS' in the Import Query
 errorMessageCloudMySqlInvalidReferenceName=Invalid reference name 
 errorMessageBlankUsername=Username is required when password is given.
-errorMessageBlankPassword=SQL Error occurred, sqlState: '28000', errorCode: '1045', errorMessage: SQL Exception occurred:
+errorMessageBlankPassword=SQL error while getting query schema
 errorMessageInvalidFetchSize=Invalid fetch size. Fetch size must be a positive integer.
 errorMessageBlankSplitBy=Split-By Field Name must be specified if Number of Splits is not set to 1. Specify the Split-by Field Name.
 errorMessageInvalidNumberOfSplits=Invalid value for Number of Splits '0'. Must be at least 1. Specify a Number of Splits no less than 1.
@@ -12,7 +12,7 @@ errorMessageNumberOfSplits=Split-By Field Name must be specified if Number of Sp
 errorMessageBoundingQuery=Bounding Query must be specified if Number of Splits is not set to 1. Specify the Bounding Query.
 errorMessageInvalidSinkDatabase=Error encountered while configuring the stage: 'URLDecoder: Illegal hex characters in escape (%) pattern - For input string: "$^"'
 errorMessageInvalidTableName=Table 'Invalidtable' does not exist. Ensure table 'Invalidtable' is set correctly and 
-errorMessageConnectionName=Connection Name must be in the format <PROJECT_ID>:<REGION>:<INSTANCE_NAME> to connect to a public CloudSQL MySQL instance.
+errorMessageConnectionName=Connection Name must be in the format <PROJECT_ID>:<REGION>:<INSTANCE_NAME> to connect to a public CloudSQL PostgreSQL instance.
 validationSuccessMessage=No errors found.
 validationErrorMessage=COUNT ERROR found
 errorLogsMessageInvalidTableName=Spark program 'phase-1' failed with error: Errors were encountered during validation. \

cloudsql-postgresql-plugin/src/e2e-test/resources/errorMessage.properties

@@ -15,7 +15,7 @@ errorMessageBlankPassword=SQL error while getting query schema:
 errorMessageInvalidPassword=SQL error while getting query schema: FATAL: password authentication failed for user
 errorMessageInvalidSourceHost=SQL error while getting query schema: The connection attempt failed.
 errorMessageInvalidTableName=Table 'table' does not exist. Ensure table '"table"' is set correctly and that the
-errorMessageInvalidSinkDatabase=Error encountered while configuring the stage: 'SQL Error occurred, sqlState: '3D000', errorCode: '0',
+errorMessageInvalidSinkDatabase=Exception while trying to validate schema of database table
 errorLogsMessageInvalidBoundingQuery=Spark program 'phase-1' failed with error: The column index is out of range: 1, \
   number of columns: 0.. Please check the system logs for more details.
 errorMessageConnectionName=Connection Name must be in the format <PROJECT_ID>:<REGION>:<INSTANCE_NAME> to connect to \

mssql-plugin/src/e2e-test/resources/errorMessage.properties

@@ -1,18 +1,18 @@
 validationSuccessMessage=No errors found.
-errorMessageInvalidSourceDatabase=SQL Error occurred, sqlState: 'S0001', errorCode: '4060',
+errorMessageInvalidSourceDatabase=SQL error while getting query schema
 errorMessageInvalidImportQuery=Import Query select must contain the string '$CONDITIONS'.
 errorMessageMssqlInvalidReferenceName=Invalid reference name 'invalidRef&^*&&*'.
 errorMessageBlankUsername=Username is required when password is given.
-errorMessageBlankPassword=SQL Error occurred, sqlState: 'S0001', errorCode: '18456',
+errorMessageBlankPassword=SQL error while getting query schema
 errorMessageInvalidFetchSize=Invalid fetch size. Fetch size must be a positive integer.
 errorMessageBlankSplitBy=Split-By Field Name must be specified if Number of Splits is not set to 1.
 errorMessageInvalidNumberOfSplits=Invalid value for Number of Splits '0'. Must be at least 1.
 errorMessageNumberOfSplitNotNumber=Unable to create config for batchsource
 errorMessageBoundingQuery=Bounding Query must be specified if Number of Splits is not set to 1.
 errorMessagenumofSplit=Split-By Field Name must be specified if Number of Splits is not set to 1.
-errorMessageInvalidSinkDatabase=Error encountered while configuring the stage: 'SQL Error occurred, sqlState: 'S0001', errorCode: '4060',
+errorMessageInvalidSinkDatabase=Exception while trying to validate schema of database table
 errorMessageInvalidSinkTableName=Table 'Table123@' does not exist.
-errormessageBlankHost=Error encountered while configuring the stage: 'SQL Error occurred, sqlState: '08S01', errorCode: '0',
+errormessageBlankHost=Exception while trying to validate schema of database table
 errorMessageInvalidTableName=Spark program 'phase-1' failed with error: Errors were encountered during validation. \
   Table 'Table123@' does not exist.. Please check the system logs for more details.
 errorMessageInvalidCredentials=Spark program 'phase-1' failed with error: Unable to create config for batchsink SqlServer \

mysql-plugin/src/e2e-test/resources/errorMessage.properties

@@ -2,12 +2,12 @@ validationSuccessMessage=No errors found.
 invalid.username.message=SQL error while getting query schema:
 invalidtableName.error.message=Table '123#' does not exist. Ensure table '123#' is set correctly 
 invalidreferenceName.error.message=Invalid reference name
-invalid.host.message=Error encountered while configuring the stage: 'SQL Error occurred, sqlState: '08S01', errorCode: '0',
+invalid.host.message=Exception while trying to validate schema of database table 
 invalid.password.message=SQL error while getting query schema:
 invalid.databasename.message=SQL error while getting query schema:
 invalid.query.message=SQL error while getting query schema:
 numberofsplits.error.message=Unable to create config for batchsource Mysql 'numSplits' is invalid
 boundingQuery.error.message=Bounding Query must be specified if Number of Splits is not set to 1. 
 splitfield.error.message=Split-By Field Name must be specified if Number of Splits is not set to 1
-invalid.sink.database.message=Error encountered while configuring the stage: 'SQL Error occurred, sqlState: '42000', errorCode: '1049',
+invalid.sink.database.message=Exception while trying to validate schema
 blank.username.message=Username is required when password is given.

oracle-plugin/src/e2e-test/features/source/OracleRunTime.feature

@@ -296,7 +296,7 @@ Feature: Oracle - Verify data transfer from Oracle source to BigQuery sink
     Then Close the Plugin Properties page
     Then Save the pipeline
     Then Preview and run the pipeline
-    Then Wait till pipeline preview is in running state and check if any error occurs
+    Then Wait till pipeline preview is in running state
     Then Verify the preview run status of pipeline in the logs is "failed"
 
   @ORACLE_SOURCE_TEST @BQ_SINK_TEST

oracle-plugin/src/e2e-test/resources/errorMessage.properties

@@ -7,12 +7,13 @@ errorMessageInvalidNumberOfSplits=Invalid value for Number of Splits '0'. Must b
 errorMessageNumberOfSplitNotNumber=Unable to create config for batchsource Oracle 'numSplits' is invalid: Value of field\
   \ class io.cdap.plugin.db.config.AbstractDBSpecificSourceConfig.numSplits is expected to be a number.
 errorMessageInvalidFetchSize=Invalid fetch size. Fetch size must be a positive integer.
-errorMessageInvalidSourceDatabase=SQL Error occurred, sqlState: '08006', errorCode: '12514',
+errorMessageInvalidSourceDatabase=SQL error while getting query schema: Listener refused the connection with the following \
+  error: ORA-12514, TNS:listener does not currently know of service requested in connect descriptor
 errorMessageInvalidImportQuery=Import Query select must contain the string '$CONDITIONS'. if Number of Splits is not set\
   \ to 1. Include '$CONDITIONS' in the Import Query
 errorMessageBlankUsername=Username is required when password is given.
-errorMessageInvalidTableName=Error encountered while configuring the stage: 'SQL Error occurred, sqlState: '08006', errorCode: '17002',
-errorMessageInvalidSinkDatabase=Error encountered while configuring the stage: 'SQL Error occurred, sqlState: '08006', errorCode: '17002'
-errorMessageInvalidHost=Error encountered while configuring the stage: 'SQL Error occurred, sqlState: '08006', errorCode: '17002',
+errorMessageInvalidTableName=Exception while trying to validate schema of database table '"table"' for connection
+errorMessageInvalidSinkDatabase=Exception while trying to validate schema of database table '"TARGETTABLE_
+errorMessageInvalidHost=Exception while trying to validate schema of database table '"table"' for connection
 errorLogsMessageInvalidBoundingQuery=Spark program 'phase-1' failed with error: ORA-00936: missing expression . \
   Please check the system logs for more details.

pom.xml

@@ -650,8 +650,7 @@
               <execution>
                 <goals>
                   <goal>integration-test</goal>
-                  <!-- Commented out verify goal to allow Cucumber reports to generate correctly even when tests fail-->
-                  <!-- <goal>verify</goal> -->
+                  <goal>verify</goal>
                 </goals>
               </execution>
             </executions>
@@ -706,7 +705,7 @@
         <dependency>
           <groupId>io.cdap.tests.e2e</groupId>
           <artifactId>cdap-e2e-framework</artifactId>
-          <version>0.5.0-SNAPSHOT</version>
+          <version>0.3.0</version>
           <scope>test</scope>
         </dependency>
         <!-- https://mvnrepository.com/artifact/io.netty/netty-all -->

postgresql-plugin/src/e2e-test/resources/errorMessage.properties

@@ -16,7 +16,7 @@ errorMessageBlankPassword=SQL error while getting query schema: The server reque
 errorMessageInvalidPassword=SQL error while getting query schema: FATAL: password authentication failed for user
 errorMessageInvalidSourceHost=SQL error while getting query schema: The connection attempt failed.
 errorMessageInvalidTableName=Table 'table' does not exist. Ensure table '"table"' is set correctly and that the
-errorMessageInvalidSinkDatabase=Error encountered while configuring the stage: 'SQL Error occurred, sqlState: '3D000', errorCode: '0',
-errorMessageInvalidHost=Error encountered while configuring the stage: 'SQL Error occurred, sqlState: '08001', errorCode: '0',
+errorMessageInvalidSinkDatabase=Exception while trying to validate schema of database table '"targettable_
+errorMessageInvalidHost=Exception while trying to validate schema of database table '"table"' for connection 
 errorLogsMessageInvalidBoundingQuery=Spark program 'phase-1' failed with error: The column index is out of range: 1, \
   number of columns: 0.. Please check the system logs for more details.