Rename Sync.PullRequest -> Sync.GithubPullRequest to follow conventions

Author: begedin

…/github/sync/pull_request/body_parser.ex …/sync/github_pull_request/body_parser.exlib/code_corps/github/sync/pull_request/body_parser.ex renamed to lib/code_corps/github/sync/github_pull_request/body_parser.ex lib/code_corps/github/sync/pull_request/body_parser.ex renamed to lib/code_corps/github/sync/github_pull_request/body_parser.ex

@@ -1,12 +1,12 @@
-defmodule CodeCorps.GitHub.Sync.PullRequest.BodyParser do
+defmodule CodeCorps.GitHub.Sync.GithubPullRequest.BodyParser do
   @moduledoc ~S"""
   In charge of extracting ids from markdown content, paired to a predefined list
   of keywords.
   """
 
   @doc ~S"""
-  Searchs for GitHub closing keyword format inside a content string. Returns all
-  unique ids matched, as integers.
+  Searches for GitHub closing keyword format inside a content string.
+  Returns all unique ids matched, as integers.
   """
   @spec extract_closing_ids(String.t) :: list(integer)
   def extract_closing_ids(content) when is_binary(content) do

…github/sync/pull_request/pull_request.ex …ithub_pull_request/gitub_pull_request.exlib/code_corps/github/sync/pull_request/pull_request.ex renamed to lib/code_corps/github/sync/github_pull_request/gitub_pull_request.ex lib/code_corps/github/sync/pull_request/pull_request.ex renamed to lib/code_corps/github/sync/github_pull_request/gitub_pull_request.ex

@@ -1,4 +1,4 @@
-defmodule CodeCorps.GitHub.Sync.PullRequest do
+defmodule CodeCorps.GitHub.Sync.GithubPullRequest do
   @moduledoc ~S"""
   In charge of finding a pull request to link with a `GithubPullRequest` record
   when processing a GitHub Pull Request payload.
@@ -56,7 +56,7 @@ defmodule CodeCorps.GitHub.Sync.PullRequest do
   defp create_pull_request(params) do
     %GithubPullRequest{}
     |> GithubPullRequest.create_changeset(params)
-    |> Repo.insert
+    |> Repo.insert()
   end
 
   @spec update_pull_request(GithubPullRequest.t(), map) :: linking_result

lib/code_corps/github/sync/sync.ex

@@ -139,7 +139,7 @@ defmodule CodeCorps.GitHub.Sync do
       end)
       |> Multi.run(:github_pull_request, fn %{repo: github_repo, fetch_pull_request: pr_payload} ->
         pr_payload
-        |> Sync.PullRequest.create_or_update_pull_request(github_repo)
+        |> Sync.GithubPullRequest.create_or_update_pull_request(github_repo)
       end)
       |> Multi.run(:github_issue, fn %{repo: github_repo, github_pull_request: github_pull_request} ->
         issue_payload
@@ -394,7 +394,7 @@ defmodule CodeCorps.GitHub.Sync do
       end)
       |> Multi.run(:github_pull_request, fn %{repo: github_repo} ->
         pr_payload
-        |> Sync.PullRequest.create_or_update_pull_request(github_repo)
+        |> Sync.GithubPullRequest.create_or_update_pull_request(github_repo)
       end)
       |> Multi.run(:github_issue, fn %{fetch_issue: issue_payload, repo: github_repo, github_pull_request: github_pull_request} ->
         issue_payload
@@ -465,7 +465,7 @@ defmodule CodeCorps.GitHub.Sync do
     with {:ok, repo} <- repo |> mark_repo("fetching_pull_requests"),
          {:ok, pr_payloads} <- repo |> API.Repository.pulls |> sync_step(:fetch_pull_requests),
          {:ok, repo} <- repo |> mark_repo("syncing_github_pull_requests", %{syncing_pull_requests_count: pr_payloads |> Enum.count}),
-         {:ok, pull_requests} <- pr_payloads |> Enum.map(&Sync.PullRequest.create_or_update_pull_request(&1, repo)) |> ResultAggregator.aggregate |> sync_step(:sync_pull_requests),
+         {:ok, pull_requests} <- pr_payloads |> Enum.map(&Sync.GithubPullRequest.create_or_update_pull_request(&1, repo)) |> ResultAggregator.aggregate |> sync_step(:sync_pull_requests),
          {:ok, repo} <- repo |> mark_repo("fetching_issues"),
          {:ok, issue_payloads} <- repo |> API.Repository.issues |> sync_step(:fetch_issues),
          {:ok, repo} <- repo |> mark_repo("syncing_github_issues", %{syncing_issues_count: issue_payloads |> Enum.count}),

…b/sync/pull_request/body_parser_test.exs …github_pull_request/body_parser_test.exstest/lib/code_corps/github/sync/pull_request/body_parser_test.exs renamed to test/lib/code_corps/github/sync/github_pull_request/body_parser_test.exs test/lib/code_corps/github/sync/pull_request/body_parser_test.exs renamed to test/lib/code_corps/github/sync/github_pull_request/body_parser_test.exs

@@ -1,10 +1,10 @@
-defmodule CodeCorps.GitHub.Sync.PullRequest.BodyParserTest do
+defmodule CodeCorps.GitHub.Sync.GithubPullRequest.BodyParserTest do
   @moduledoc false
 
   use ExUnit.Case, async: true
 
   alias CodeCorps.{
-    GitHub.Sync.PullRequest.BodyParser
+    GitHub.Sync.GithubPullRequest.BodyParser
   }
 
   describe "extract_closing_ids/1" do

…/sync/pull_request/pull_request_test.exs …ull_request/github_pull_request_test.exstest/lib/code_corps/github/sync/pull_request/pull_request_test.exs renamed to test/lib/code_corps/github/sync/github_pull_request/github_pull_request_test.exs test/lib/code_corps/github/sync/pull_request/pull_request_test.exs renamed to test/lib/code_corps/github/sync/github_pull_request/github_pull_request_test.exs

@@ -1,4 +1,4 @@
-defmodule CodeCorps.GitHub.Sync.PullRequestTest do
+defmodule CodeCorps.GitHub.Sync.GithubPullRequestTest do
   @moduledoc false
 
   use CodeCorps.DbAccessCase
@@ -18,7 +18,7 @@ defmodule CodeCorps.GitHub.Sync.PullRequestTest do
       %{"pull_request" => attrs} = @payload
       github_repo = insert(:github_repo)
       {:ok, %GithubPullRequest{} = created_pull_request} =
-        Sync.PullRequest.create_or_update_pull_request(attrs, github_repo)
+        Sync.GithubPullRequest.create_or_update_pull_request(attrs, github_repo)
 
       assert Repo.one(GithubPullRequest)
 
@@ -40,7 +40,7 @@ defmodule CodeCorps.GitHub.Sync.PullRequestTest do
       pull_request = insert(:github_pull_request, github_id: pull_request_id, github_repo: github_repo)
 
       {:ok, %GithubPullRequest{} = updated_pull_request} =
-        Sync.PullRequest.create_or_update_pull_request(attrs, github_repo)
+        Sync.GithubPullRequest.create_or_update_pull_request(attrs, github_repo)
 
       assert updated_pull_request.id == pull_request.id
       assert updated_pull_request.github_repo_id == github_repo.id
@@ -52,7 +52,7 @@ defmodule CodeCorps.GitHub.Sync.PullRequestTest do
       github_repo = insert(:github_repo)
 
       {:error, changeset} =
-        Sync.PullRequest.create_or_update_pull_request(attrs, github_repo)
+        Sync.GithubPullRequest.create_or_update_pull_request(attrs, github_repo)
       refute changeset.valid?
     end
   end