Remove JaResource for StripeConnectSubscriptions (#1041)

Author: landongrindheim

lib/code_corps/policy/policy.ex

@@ -54,6 +54,10 @@ defmodule CodeCorps.Policy do
     do: Policy.StripeConnectPlan.show?(current_user, stripe_connect_plan)
   defp can?(%User{} = current_user, :create, %StripeConnectPlan{}, %{} = params),
     do: Policy.StripeConnectPlan.create?(current_user, params)
+  defp can?(%User{} = current_user, :show, %StripeConnectSubscription{} = stripe_connect_subscription, %{}),
+    do: Policy.StripeConnectSubscription.show?(current_user, stripe_connect_subscription)
+  defp can?(%User{} = current_user, :create, %StripeConnectSubscription{}, %{} = params),
+    do: Policy.StripeConnectSubscription.create?(current_user, params)
   defp can?(%User{} = current_user, :create, %Skill{}, %{}), do: Policy.Skill.create?(current_user)
   defp can?(%User{} = current_user, :show, %StripePlatformCard{} = stripe_platform_card, %{}),
     do: Policy.StripePlatformCard.show?(current_user, stripe_platform_card)
@@ -106,8 +110,5 @@ defmodule CodeCorps.Policy do
     def can?(%User{} = user, :delete, %ProjectGithubRepo{} = project_github_repo), do: Policy.ProjectGithubRepo.delete?(user, project_github_repo)
 
     def can?(%User{} = user, :create, Role), do: Policy.Role.create?(user)
-
-    def can?(%User{} = user, :show, %StripeConnectSubscription{} = stripe_connect_subscription), do: Policy.StripeConnectSubscription.show?(user, stripe_connect_subscription)
-    def can?(%User{} = user, :create, %Changeset{ data: %StripeConnectSubscription{}} = changeset), do: Policy.StripeConnectSubscription.create?(user, changeset)
   end
 end

lib/code_corps/policy/stripe_connect_subscription.ex

@@ -1,15 +1,16 @@
 defmodule CodeCorps.Policy.StripeConnectSubscription do
-  alias CodeCorps.StripeConnectSubscription
-  alias CodeCorps.User
-  alias Ecto.Changeset
+  alias CodeCorps.{StripeConnectSubscription, User}
 
-  def create?(user, subscription), do: user |> owns?(subscription)
+  @spec create?(User.t, map) :: boolean
+  def create?(user, params), do: user |> owns?(params)
+
+  @spec show?(User.t, StripeConnectSubscription.t) :: boolean
   def show?(user, subscription), do: user |> owns?(subscription)
 
-  defp owns?(%User{id: current_user_id}, %Changeset{changes: %{user_id: user_id}}) do
+  defp owns?(%User{id: current_user_id}, %StripeConnectSubscription{user_id: user_id}) do
     current_user_id == user_id
   end
-  defp owns?(%User{id: current_user_id}, %StripeConnectSubscription{user_id: user_id}) do
+  defp owns?(%User{id: current_user_id}, %{"user_id" =>  user_id}) do
     current_user_id == user_id
   end
   defp owns?(_, _), do: false

lib/code_corps_web/controllers/stripe_connect_subscription_controller.ex

@@ -1,19 +1,28 @@
 defmodule CodeCorpsWeb.StripeConnectSubscriptionController do
   use CodeCorpsWeb, :controller
-  use JaResource
 
-  alias CodeCorps.StripeConnectSubscription
+  alias CodeCorps.{StripeConnectSubscription, User}
   alias CodeCorps.StripeService.StripeConnectSubscriptionService
 
-  plug :load_and_authorize_resource, model: StripeConnectSubscription, only: [:show], preload: [:user]
-  plug :load_and_authorize_changeset, model: StripeConnectSubscription, only: [:create]
+  action_fallback CodeCorpsWeb.FallbackController
+  plug CodeCorpsWeb.Plug.DataToAttributes
+  plug CodeCorpsWeb.Plug.IdsToIntegers
 
-  plug JaResource
-
-  @spec model :: module
-  def model, do: CodeCorps.StripeConnectSubscription
+  @spec show(Conn.t, map) :: Conn.t
+  def show(%Conn{} = conn, %{"id" => id} = params) do
+    with %User{} = current_user <- conn |> Guardian.Plug.current_resource,
+         %StripeConnectSubscription{} = subscription <- StripeConnectSubscription |> Repo.get(id),
+         {:ok, :authorized} <- current_user |> Policy.authorize(:show, subscription, params) do
+      conn |> render("show.json-api", data: subscription)
+    end
+  end
 
-  def handle_create(_conn, attributes) do
-    attributes |> StripeConnectSubscriptionService.find_or_create
+  @spec create(Plug.Conn.t, map) :: Conn.t
+  def create(%Conn{} = conn, %{} = params) do
+    with %User{} = current_user <- conn |> Guardian.Plug.current_resource,
+         {:ok, :authorized} <- current_user |> Policy.authorize(:create, %StripeConnectSubscription{}, params),
+         {:ok, %StripeConnectSubscription{} = subscription} <- StripeConnectSubscriptionService.find_or_create(params) do
+      conn |> put_status(:created) |> render("show.json-api", data: subscription)
+    end
   end
 end

test/lib/code_corps/policy/stripe_connect_subscription_test.exs

@@ -2,23 +2,22 @@ defmodule CodeCorps.Policy.StripeConnectSubscriptionTest do
   use CodeCorps.PolicyCase
 
   import CodeCorps.Policy.StripeConnectSubscription, only: [create?: 2, show?: 2]
-  import CodeCorps.StripeConnectSubscription, only: [create_changeset: 2]
-
-  alias CodeCorps.StripeConnectSubscription
 
   describe "create?" do
     test "returns true if user is creating their own record" do
       user = insert(:user)
-      changeset = %StripeConnectSubscription{} |> create_changeset(%{user_id: user.id})
+      stripe_connect_subscription = insert(:stripe_connect_subscription, user: user)
+      params = %{"id" => stripe_connect_subscription.id, "user_id" => user.id}
 
-      assert create?(user, changeset)
+      assert create?(user, params)
     end
 
     test "returns false if user is creating someone else's record" do
       user = build(:user)
-      changeset = %StripeConnectSubscription{} |> create_changeset(%{user_id: -1})
+      stripe_connect_subscription = insert(:stripe_connect_subscription)
+      params = %{"id" => stripe_connect_subscription.id, "user_id" => -1}
 
-      refute create?(user, changeset)
+      refute create?(user, params)
     end
   end