Merge pull request #1227 from code-corps/add-overall-status-to-task

Add overall status to task

Author: joshsmith

lib/code_corps_web/views/task_view.ex

@@ -4,8 +4,9 @@ defmodule CodeCorpsWeb.TaskView do
   use JaSerializer.PhoenixView
 
   attributes [
-    :archived, :body, :created_at, :created_from, :inserted_at, :markdown,
-    :modified_at, :modified_from, :number, :order, :status, :title, :updated_at
+    :archived, :body, :created_at, :created_from, :has_github_pull_request,
+    :inserted_at, :markdown, :modified_at, :modified_from, :number, :order,
+    :overall_status, :status, :title, :updated_at
   ]
 
   has_one :github_issue, type: "github-issue", field: :github_issue_id
@@ -18,4 +19,21 @@ defmodule CodeCorpsWeb.TaskView do
 
   has_many :comments, serializer: CodeCorpsWeb.CommentView, identifiers: :always
   has_many :task_skills, serializer: CodeCorpsWeb.TaskSkillView, identifiers: :always
+
+  def has_github_pull_request(%{
+    github_pull_request: %CodeCorps.GithubPullRequest{}
+  }), do: true
+  def has_github_pull_request(%{github_pull_request: nil}), do: false
+
+  def overall_status(%{
+    github_pull_request: %CodeCorps.GithubPullRequest{merged: merged, state: state}
+  }, _conn) do
+    case merged do
+      true -> "merged"
+      false -> state
+    end
+  end
+  def overall_status(%{github_pull_request: nil, status: status}, _conn) do
+    status
+  end
 end

test/lib/code_corps_web/views/task_view_test.exs

@@ -1,4 +1,6 @@
 defmodule CodeCorpsWeb.TaskViewTest do
+  @moduledoc false
+
   use CodeCorpsWeb.ViewCase
 
   test "renders all attributes and relationships properly" do
@@ -20,12 +22,14 @@ defmodule CodeCorpsWeb.TaskViewTest do
           "body" => task.body,
           "created-at" => task.created_at,
           "created-from" => task.created_from,
+          "has-github-pull-request" => true,
           "inserted-at" => task.inserted_at,
           "markdown" => task.markdown,
           "modified-at" => task.modified_at,
           "modified-from" => task.modified_from,
           "number" => task.number,
           "order" => task.order,
+          "overall-status" => "open",
           "status" => task.status,
           "title" => task.title,
           "updated-at" => task.updated_at
@@ -100,4 +104,65 @@ defmodule CodeCorpsWeb.TaskViewTest do
 
     assert rendered_json == expected_json
   end
+
+  describe "has-github-pull-request" do
+    test "when pull request exists" do
+      github_pull_request = insert(:github_pull_request)
+      github_issue = insert(:github_issue, github_pull_request: github_pull_request)
+      task = insert(:task, github_issue: github_issue)
+      task = CodeCorpsWeb.TaskController.preload(task)
+      rendered_json = render(CodeCorpsWeb.TaskView, "show.json-api", data: task)
+      assert rendered_json["data"]["attributes"]["has-github-pull-request"]
+    end
+
+    test "when no pull request exists" do
+      task = insert(:task)
+      task = CodeCorpsWeb.TaskController.preload(task)
+      rendered_json = render(CodeCorpsWeb.TaskView, "show.json-api", data: task)
+      refute rendered_json["data"]["attributes"]["has-github-pull-request"]
+    end
+  end
+
+  describe "overall-status" do
+    test "when pull request is open" do
+      github_pull_request = insert(:github_pull_request, merged: false, state: "open")
+      github_issue = insert(:github_issue, github_pull_request: github_pull_request)
+      task = insert(:task, github_issue: github_issue)
+      task = CodeCorpsWeb.TaskController.preload(task)
+      rendered_json = render(CodeCorpsWeb.TaskView, "show.json-api", data: task)
+      assert rendered_json["data"]["attributes"]["overall-status"] == "open"
+    end
+
+    test "when pull request is closed" do
+      github_pull_request = insert(:github_pull_request, merged: false, state: "closed")
+      github_issue = insert(:github_issue, github_pull_request: github_pull_request)
+      task = insert(:task, github_issue: github_issue)
+      task = CodeCorpsWeb.TaskController.preload(task)
+      rendered_json = render(CodeCorpsWeb.TaskView, "show.json-api", data: task)
+      assert rendered_json["data"]["attributes"]["overall-status"] == "closed"
+    end
+
+    test "when pull request is merged" do
+      github_pull_request = insert(:github_pull_request, merged: false, state: "merged")
+      github_issue = insert(:github_issue, github_pull_request: github_pull_request)
+      task = insert(:task, github_issue: github_issue)
+      task = CodeCorpsWeb.TaskController.preload(task)
+      rendered_json = render(CodeCorpsWeb.TaskView, "show.json-api", data: task)
+      assert rendered_json["data"]["attributes"]["overall-status"] == "merged"
+    end
+
+    test "when task is open" do
+      task = insert(:task, status: "open")
+      task = CodeCorpsWeb.TaskController.preload(task)
+      rendered_json = render(CodeCorpsWeb.TaskView, "show.json-api", data: task)
+      assert rendered_json["data"]["attributes"]["overall-status"] == "open"
+    end
+
+    test "when task is closed" do
+      task = insert(:task, status: "closed")
+      task = CodeCorpsWeb.TaskController.preload(task)
+      rendered_json = render(CodeCorpsWeb.TaskView, "show.json-api", data: task)
+      assert rendered_json["data"]["attributes"]["overall-status"] == "closed"
+    end
+  end
 end