Add GithubIssueAssignee

Author: joshsmith

lib/code_corps/model/github_issue.ex

@@ -25,6 +25,7 @@ defmodule CodeCorps.GithubIssue do
     belongs_to :github_user, CodeCorps.GithubUser
 
     has_many :github_comments, CodeCorps.GithubComment
+    has_many :github_issue_assignees, CodeCorps.GithubIssueAssignee
     has_one :task, CodeCorps.Task
 
     timestamps()

lib/code_corps/model/github_issue_assignee.ex

@@ -0,0 +1,22 @@
+defmodule CodeCorps.GithubIssueAssignee do
+  use Ecto.Schema
+  import Ecto.Changeset
+
+
+  schema "github_issue_assignees" do
+    belongs_to :github_issue, CodeCorps.GithubIssue
+    belongs_to :github_user, CodeCorps.GithubUser
+
+    timestamps()
+  end
+
+  @doc false
+  def changeset(struct, attrs) do
+    struct
+    |> cast(attrs, [:github_issue_id, :github_user_id])
+    |> validate_required([:github_issue_id, :github_user_id])
+    |> assoc_constraint(:github_issue)
+    |> assoc_constraint(:github_user)
+    |> unique_constraint(:github_user, name: :github_issue_assignees_github_issue_id_github_user_id_index)
+  end
+end

lib/code_corps/policy/github_repo.ex

@@ -4,7 +4,7 @@ defmodule CodeCorps.Policy.GithubRepo do
   """
   import CodeCorps.Policy.Helpers, only: [get_project: 1, administered_by?: 2]
 
-  alias CodeCorps.{GithubAppInstallation, GithubRepo, User}
+  alias CodeCorps.{GithubRepo, User}
 
   def update?(%User{} = user, %GithubRepo{project_id: nil}, %{"project_id" => _} = params) do
     params |> get_project |> administered_by?(user)

priv/repo/migrations/20171119004204_create_github_issue_assignees.exs

@@ -0,0 +1,16 @@
+defmodule CodeCorps.Repo.Migrations.CreateGithubIssueAssignees do
+  use Ecto.Migration
+
+  def change do
+    create table(:github_issue_assignees) do
+      add :github_issue_id, references(:github_issues, on_delete: :nothing)
+      add :github_user_id, references(:github_users, on_delete: :nothing)
+
+      timestamps()
+    end
+
+    create index(:github_issue_assignees, [:github_issue_id])
+    create index(:github_issue_assignees, [:github_user_id])
+    create unique_index(:github_issue_assignees, [:github_issue_id, :github_user_id])
+  end
+end

priv/repo/structure.sql

@@ -309,6 +309,38 @@ CREATE SEQUENCE github_events_id_seq
 ALTER SEQUENCE github_events_id_seq OWNED BY github_events.id;
 
 
+--
+-- Name: github_issue_assignees; Type: TABLE; Schema: public; Owner: -
+--
+
+CREATE TABLE github_issue_assignees (
+    id bigint NOT NULL,
+    github_issue_id bigint,
+    github_user_id bigint,
+    inserted_at timestamp without time zone NOT NULL,
+    updated_at timestamp without time zone NOT NULL
+);
+
+
+--
+-- Name: github_issue_assignees_id_seq; Type: SEQUENCE; Schema: public; Owner: -
+--
+
+CREATE SEQUENCE github_issue_assignees_id_seq
+    START WITH 1
+    INCREMENT BY 1
+    NO MINVALUE
+    NO MAXVALUE
+    CACHE 1;
+
+
+--
+-- Name: github_issue_assignees_id_seq; Type: SEQUENCE OWNED BY; Schema: public; Owner: -
+--
+
+ALTER SEQUENCE github_issue_assignees_id_seq OWNED BY github_issue_assignees.id;
+
+
 --
 -- Name: github_issues; Type: TABLE; Schema: public; Owner: -
 --
@@ -1788,6 +1820,13 @@ ALTER TABLE ONLY github_comments ALTER COLUMN id SET DEFAULT nextval('github_com
 ALTER TABLE ONLY github_events ALTER COLUMN id SET DEFAULT nextval('github_events_id_seq'::regclass);
 
 
+--
+-- Name: github_issue_assignees id; Type: DEFAULT; Schema: public; Owner: -
+--
+
+ALTER TABLE ONLY github_issue_assignees ALTER COLUMN id SET DEFAULT nextval('github_issue_assignees_id_seq'::regclass);
+
+
 --
 -- Name: github_issues id; Type: DEFAULT; Schema: public; Owner: -
 --
@@ -2096,6 +2135,14 @@ ALTER TABLE ONLY github_events
     ADD CONSTRAINT github_events_pkey PRIMARY KEY (id);
 
 
+--
+-- Name: github_issue_assignees github_issue_assignees_pkey; Type: CONSTRAINT; Schema: public; Owner: -
+--
+
+ALTER TABLE ONLY github_issue_assignees
+    ADD CONSTRAINT github_issue_assignees_pkey PRIMARY KEY (id);
+
+
 --
 -- Name: github_issues github_issues_pkey; Type: CONSTRAINT; Schema: public; Owner: -
 --
@@ -2456,6 +2503,27 @@ CREATE UNIQUE INDEX github_events_github_delivery_id_index ON github_events USIN
 CREATE INDEX github_events_status_index ON github_events USING btree (status);
 
 
+--
+-- Name: github_issue_assignees_github_issue_id_github_user_id_index; Type: INDEX; Schema: public; Owner: -
+--
+
+CREATE UNIQUE INDEX github_issue_assignees_github_issue_id_github_user_id_index ON github_issue_assignees USING btree (github_issue_id, github_user_id);
+
+
+--
+-- Name: github_issue_assignees_github_issue_id_index; Type: INDEX; Schema: public; Owner: -
+--
+
+CREATE INDEX github_issue_assignees_github_issue_id_index ON github_issue_assignees USING btree (github_issue_id);
+
+
+--
+-- Name: github_issue_assignees_github_user_id_index; Type: INDEX; Schema: public; Owner: -
+--
+
+CREATE INDEX github_issue_assignees_github_user_id_index ON github_issue_assignees USING btree (github_user_id);
+
+
 --
 -- Name: github_issues_github_id_index; Type: INDEX; Schema: public; Owner: -
 --
@@ -3341,6 +3409,22 @@ ALTER TABLE ONLY github_comments
     ADD CONSTRAINT github_comments_github_user_id_fkey FOREIGN KEY (github_user_id) REFERENCES github_users(id);
 
 
+--
+-- Name: github_issue_assignees github_issue_assignees_github_issue_id_fkey; Type: FK CONSTRAINT; Schema: public; Owner: -
+--
+
+ALTER TABLE ONLY github_issue_assignees
+    ADD CONSTRAINT github_issue_assignees_github_issue_id_fkey FOREIGN KEY (github_issue_id) REFERENCES github_issues(id);
+
+
+--
+-- Name: github_issue_assignees github_issue_assignees_github_user_id_fkey; Type: FK CONSTRAINT; Schema: public; Owner: -
+--
+
+ALTER TABLE ONLY github_issue_assignees
+    ADD CONSTRAINT github_issue_assignees_github_user_id_fkey FOREIGN KEY (github_user_id) REFERENCES github_users(id);
+
+
 --
 -- Name: github_issues github_issues_github_pull_request_id_fkey; Type: FK CONSTRAINT; Schema: public; Owner: -
 --
@@ -3801,5 +3885,5 @@ ALTER TABLE ONLY users
 -- PostgreSQL database dump complete
 --
 
-INSERT INTO "schema_migrations" (version) VALUES (20160723215749), (20160804000000), (20160804001111), (20160805132301), (20160805203929), (20160808143454), (20160809214736), (20160810124357), (20160815125009), (20160815143002), (20160816020347), (20160816034021), (20160817220118), (20160818000944), (20160818132546), (20160820113856), (20160820164905), (20160822002438), (20160822004056), (20160822011624), (20160822020401), (20160822044612), (20160830081224), (20160830224802), (20160911233738), (20160912002705), (20160912145957), (20160918003206), (20160928232404), (20161003185918), (20161019090945), (20161019110737), (20161020144622), (20161021131026), (20161031001615), (20161121005339), (20161121014050), (20161121043941), (20161121045709), (20161122015942), (20161123081114), (20161123150943), (20161124085742), (20161125200620), (20161126045705), (20161127054559), (20161205024856), (20161207112519), (20161209192504), (20161212005641), (20161214005935), (20161215052051), (20161216051447), (20161218005913), (20161219160401), (20161219163909), (20161220141753), (20161221085759), (20161226213600), (20161231063614), (20170102130055), (20170102181053), (20170104113708), (20170104212623), (20170104235423), (20170106013143), (20170115035159), (20170115230549), (20170121014100), (20170131234029), (20170201014901), (20170201025454), (20170201035458), (20170201183258), (20170220032224), (20170224233516), (20170226050552), (20170228085250), (20170308214128), (20170308220713), (20170308222552), (20170313130611), (20170318032449), (20170318082740), (20170324194827), (20170424215355), (20170501225441), (20170505224222), (20170526095401), (20170602000208), (20170622205732), (20170626231059), (20170628092119), (20170628213609), (20170629183404), (20170630140136), (20170706132431), (20170707213648), (20170711122252), (20170717092127), (20170725060612), (20170727052644), (20170731130121), (20170814131722), (20170913114958), (20170921014405), (20170925214512), (20170925230419), (20170926134646), (20170927100300), (20170928234412), (20171003134956), (20171003225853), (20171006063358), (20171006161407), (20171012215106), (20171012221231), (20171016125229), (20171016125516), (20171016223356), (20171016235656), (20171017235433), (20171019191035), (20171025184225), (20171026010933), (20171027061833), (20171028011642), (20171028173508), (20171030182857), (20171031232023), (20171031234356), (20171101023309), (20171104013543), (20171106045740), (20171106050209), (20171106103153), (20171106200036), (20171109231538), (20171110001134), (20171114010851), (20171114033357), (20171114225214), (20171114225713), (20171114232534), (20171115201624), (20171115225358);
+INSERT INTO "schema_migrations" (version) VALUES (20160723215749), (20160804000000), (20160804001111), (20160805132301), (20160805203929), (20160808143454), (20160809214736), (20160810124357), (20160815125009), (20160815143002), (20160816020347), (20160816034021), (20160817220118), (20160818000944), (20160818132546), (20160820113856), (20160820164905), (20160822002438), (20160822004056), (20160822011624), (20160822020401), (20160822044612), (20160830081224), (20160830224802), (20160911233738), (20160912002705), (20160912145957), (20160918003206), (20160928232404), (20161003185918), (20161019090945), (20161019110737), (20161020144622), (20161021131026), (20161031001615), (20161121005339), (20161121014050), (20161121043941), (20161121045709), (20161122015942), (20161123081114), (20161123150943), (20161124085742), (20161125200620), (20161126045705), (20161127054559), (20161205024856), (20161207112519), (20161209192504), (20161212005641), (20161214005935), (20161215052051), (20161216051447), (20161218005913), (20161219160401), (20161219163909), (20161220141753), (20161221085759), (20161226213600), (20161231063614), (20170102130055), (20170102181053), (20170104113708), (20170104212623), (20170104235423), (20170106013143), (20170115035159), (20170115230549), (20170121014100), (20170131234029), (20170201014901), (20170201025454), (20170201035458), (20170201183258), (20170220032224), (20170224233516), (20170226050552), (20170228085250), (20170308214128), (20170308220713), (20170308222552), (20170313130611), (20170318032449), (20170318082740), (20170324194827), (20170424215355), (20170501225441), (20170505224222), (20170526095401), (20170602000208), (20170622205732), (20170626231059), (20170628092119), (20170628213609), (20170629183404), (20170630140136), (20170706132431), (20170707213648), (20170711122252), (20170717092127), (20170725060612), (20170727052644), (20170731130121), (20170814131722), (20170913114958), (20170921014405), (20170925214512), (20170925230419), (20170926134646), (20170927100300), (20170928234412), (20171003134956), (20171003225853), (20171006063358), (20171006161407), (20171012215106), (20171012221231), (20171016125229), (20171016125516), (20171016223356), (20171016235656), (20171017235433), (20171019191035), (20171025184225), (20171026010933), (20171027061833), (20171028011642), (20171028173508), (20171030182857), (20171031232023), (20171031234356), (20171101023309), (20171104013543), (20171106045740), (20171106050209), (20171106103153), (20171106200036), (20171109231538), (20171110001134), (20171114010851), (20171114033357), (20171114225214), (20171114225713), (20171114232534), (20171115201624), (20171115225358), (20171119004204);
 

test/lib/code_corps/model/github_issue_assignee_test.exs

@@ -0,0 +1,45 @@
+defmodule CodeCorps.GithubIssueAssigneeTest do
+  @moduledoc false
+
+  use CodeCorps.ModelCase
+
+  alias CodeCorps.GithubIssueAssignee
+
+  describe "changeset/2" do
+    @required_attrs ~w(github_issue_id github_user_id)
+
+    test "requires #{@required_attrs}" do
+      changeset = GithubIssueAssignee.changeset(%GithubIssueAssignee{}, %{})
+
+      assert_validation_triggered(changeset, :github_issue_id, :required)
+      assert_validation_triggered(changeset, :github_user_id, :required)
+    end
+
+    test "ensures associated GithubIssue record exists" do
+      github_user = insert(:github_user)
+      changeset = GithubIssueAssignee.changeset(%GithubIssueAssignee{}, %{github_issue_id: -1, github_user_id: github_user.id})
+
+      {:error, response_changeset} = Repo.insert(changeset)
+      assert_error_message(response_changeset, :github_issue, "does not exist")
+    end
+
+    test "ensures associated GithubUser record exists" do
+      github_issue = insert(:github_issue)
+      changeset = GithubIssueAssignee.changeset(%GithubIssueAssignee{}, %{github_issue_id: github_issue.id, github_user_id: -1})
+
+      {:error, response_changeset} = Repo.insert(changeset)
+      assert_error_message(response_changeset, :github_user, "does not exist")
+    end
+
+    test "ensures uniqueness of GithubUser/GithubIssue combination" do
+      github_issue = insert(:github_issue)
+      github_user = insert(:github_user)
+      insert(:github_issue_assignee, github_issue: github_issue, github_user: github_user)
+
+      changeset = GithubIssueAssignee.changeset(%GithubIssueAssignee{}, %{github_issue_id: github_issue.id, github_user_id: github_user.id})
+
+      {:error, response_changeset} = Repo.insert(changeset)
+      assert_error_message(response_changeset, :github_user, "has already been taken")
+    end
+  end
+end

test/support/factories.ex

@@ -67,6 +67,13 @@ defmodule CodeCorps.Factories do
     }
   end
 
+  def github_issue_assignee_factory do
+    %CodeCorps.GithubIssueAssignee{
+      github_issue: build(:github_issue),
+      github_user: build(:github_user)
+    }
+  end
+
   def github_pull_request_factory do
     %CodeCorps.GithubPullRequest{
       body: "Here's a change!",