Remove JaResource from PreviewController (#1061)

Author: landongrindheim

lib/code_corps/policy/policy.ex

@@ -49,6 +49,7 @@ defmodule CodeCorps.Policy do
     %OrganizationGithubAppInstallation{} = organization_github_app_installation, %{}),
       do: Policy.OrganizationGithubAppInstallation.delete?(user, organization_github_app_installation)
   defp can?(%User{} = user, :create, %OrganizationGithubAppInstallation{}, %{} = params), do: Policy.OrganizationGithubAppInstallation.create?(user, params)
+  defp can?(%User{} = current_user, :create, %Preview{}, %{} = params), do: Policy.Preview.create?(current_user, params)
   defp can?(%User{} = current_user, :create, %ProjectCategory{}, %{} = params), do: Policy.ProjectCategory.create?(current_user, params)
   defp can?(%User{} = current_user, :delete, %ProjectCategory{} = project_category, %{}), do: Policy.ProjectCategory.delete?(current_user, project_category)
   defp can?(%User{} = current_user, :create, %ProjectGithubRepo{}, %{} = params), do: Policy.ProjectGithubRepo.create?(current_user, params)
@@ -105,8 +106,6 @@ defmodule CodeCorps.Policy do
 
     def can?(%User{} = user, :create, %Changeset{data: %GithubAppInstallation{}} = changeset), do: Policy.GithubAppInstallation.create?(user, changeset)
 
-    def can?(%User{} = user, :create, %Changeset{data: %Preview{}} = changeset), do: Policy.Preview.create?(user, changeset)
-
     def can?(%User{} = user, :create, Role), do: Policy.Role.create?(user)
   end
 end

lib/code_corps/policy/preview.ex

@@ -1,7 +1,7 @@
 defmodule CodeCorps.Policy.Preview do
   alias CodeCorps.User
-  alias Ecto.Changeset
 
-  def create?(%User{} = user, %Changeset{changes: %{user_id: author_id}}), do: user.id == author_id
-  def create?(%User{}, %Changeset{}), do: false
+  @spec create?(User.t, map) :: boolean
+  def create?(%User{} = user, %{"user_id" => author_id}), do: user.id == author_id
+  def create?(%User{}, %{}), do: false
 end

lib/code_corps_web/controllers/preview_controller.ex

@@ -1,16 +1,18 @@
 defmodule CodeCorpsWeb.PreviewController do
   use CodeCorpsWeb, :controller
-  use JaResource
 
-  alias CodeCorps.Preview
+  alias CodeCorps.{Preview, User}
 
-  plug :load_and_authorize_changeset, model: Preview, only: [:create]
-  plug JaResource
+  action_fallback CodeCorpsWeb.FallbackController
+  plug CodeCorpsWeb.Plug.DataToAttributes
+  plug CodeCorpsWeb.Plug.IdsToIntegers
 
-  @spec model :: module
-  def model, do: CodeCorps.Preview
-
-  def handle_create(_conn, attributes) do
-    Preview.create_changeset(%Preview{}, attributes)
+  @spec create(Plug.Conn.t, map) :: Conn.t
+  def create(%Conn{} = conn, %{} = params) do
+    with %User{} = current_user <- conn |> Guardian.Plug.current_resource,
+         {:ok, :authorized} <- current_user |> Policy.authorize(:create, %Preview{}, params),
+         {:ok, %Preview{} = preview} <- %Preview{} |> Preview.create_changeset(params) |> Repo.insert do
+      conn |> put_status(:created) |> render("show.json-api", data: preview)
+    end
   end
 end

test/lib/code_corps/policy/preview_test.exs

@@ -2,21 +2,19 @@ defmodule CodeCorps.Policy.PreviewTest do
   use CodeCorps.PolicyCase
 
   import CodeCorps.Policy.Preview, only: [create?: 2]
-  import CodeCorps.Preview, only: [create_changeset: 2]
-
-  alias CodeCorps.Preview
 
   describe "create?" do
     test "returns true if user is creating their own record" do
       user = insert(:user)
-      changeset = %Preview{} |> create_changeset(%{markdown: "markdown", user_id: user.id})
-      assert create?(user, changeset)
+
+      params = %{"markdown" => "markdown", "user_id" => user.id}
+      assert create?(user, params)
     end
 
     test "returns false if user is creating someone else's record" do
       [user, another_user] = insert_pair(:user)
-      changeset = %Preview{} |> create_changeset(%{markdown: "markdown", user_id: another_user.id})
-      refute create?(user, changeset)
+      params = %{"markdown" => "markdown", "user_id" => another_user.id}
+      refute create?(user, params)
     end
   end
 end