Merge pull request #1339 from code-corps/1317-update-conversation-for-conversation-part

Update conversation for new conversation part

Author: joshsmith

lib/code_corps/messages/conversation_parts.ex

@@ -4,23 +4,48 @@ defmodule CodeCorps.Messages.ConversationParts do
   i.e. a reply to the `CodeCorps.Conversation` by any participant.
   """
 
-  import Ecto.Changeset, only: [assoc_constraint: 2, cast: 3, validate_required: 2,
-                                validate_inclusion: 3]
+  import Ecto.Changeset, only: [
+    assoc_constraint: 2,
+    cast: 3,
+    validate_required: 2,
+    validate_inclusion: 3
+  ]
 
   alias CodeCorps.{
+    Conversation,
     ConversationPart,
+    Messages,
     Repo
   }
   alias CodeCorpsWeb.ConversationChannel
+  alias Ecto.{
+    Changeset,
+    Multi
+  }
 
-  @spec create(map) :: ConversationPart.t | Ecto.Changeset.t
-  def create(attrs) do
-    with {:ok, %ConversationPart{} = conversation_part} <- %ConversationPart{} |> create_changeset(attrs) |> Repo.insert() do
+  @spec create(map) :: {:ok, ConversationPart.t} | {:error, Changeset.t}
+  def create(%{"conversation_id" => id} = attrs) do
+    with %Conversation{} = conversation <- Repo.get(Conversation, id),
+         {:ok, %ConversationPart{} = conversation_part} <- do_create(attrs, conversation) do
       ConversationChannel.broadcast_new_conversation_part(conversation_part)
       {:ok, conversation_part}
     end
   end
 
+  @spec do_create(map, Conversation.t) :: {:ok, Conversation.t} | {:error, Changeset.t}
+  defp do_create(attrs, conversation) do
+    Multi.new
+    |> Multi.insert(:conversation_part, create_changeset(%ConversationPart{}, attrs))
+    |> Multi.update(:conversation, Messages.Conversations.part_added_changeset(conversation))
+    |> Repo.transaction()
+    |> marshall_result()
+  end
+
+  @spec marshall_result(tuple) :: {:ok, ConversationPart.t} | {:error, Changeset.t}
+  defp marshall_result({:ok, %{conversation_part: %ConversationPart{} = conversation_part}}), do: {:ok, conversation_part}
+  defp marshall_result({:error, :conversation_part, %Changeset{} = changeset, _steps}), do: {:error, changeset}
+  defp marshall_result({:error, :conversation, %Changeset{} = changeset, _steps}), do: {:error, changeset}
+
   @doc false
   @spec create_changeset(ConversationPart.t, map) :: Ecto.Changeset.t
   def create_changeset(%ConversationPart{} = conversation_part, attrs) do

lib/code_corps/messages/conversations.ex

@@ -16,4 +16,16 @@ defmodule CodeCorps.Messages.Conversations do
     |> Changeset.validate_required([:user_id])
     |> Changeset.assoc_constraint(:user)
   end
+
+  @doc false
+  @spec part_added_changeset(Conversation.t) :: Ecto.Changeset.t
+  def part_added_changeset(%Conversation{} = conversation) do
+    params = %{
+      status: "open",
+      updated_at: Ecto.DateTime.utc()
+    }
+
+    conversation
+    |> Changeset.cast(params, [:status, :updated_at])
+  end
 end

test/lib/code_corps/messages/conversations_test.exs

@@ -0,0 +1,24 @@
+defmodule CodeCorps.Messages.ConversationsTest do
+  @moduledoc false
+
+  use CodeCorps.DbAccessCase
+
+  alias CodeCorps.{
+    Conversation, Messages
+  }
+
+  describe "part_added_changeset/1" do
+    test "sets the updated_at to the current time" do
+      old_updated_at = Timex.now |> Timex.shift(days: -5)
+      conversation = %Conversation{updated_at: old_updated_at}
+      changeset = conversation |> Messages.Conversations.part_added_changeset()
+      assert changeset.changes[:updated_at] > old_updated_at
+    end
+
+    test "sets status to open" do
+      conversation = %Conversation{status: "closed"}
+      changeset = conversation |> Messages.Conversations.part_added_changeset()
+      assert changeset.changes[:status] == "open"
+    end
+  end
+end

test/lib/code_corps/messages/messages_test.exs

@@ -14,6 +14,12 @@ defmodule CodeCorps.MessagesTest do
     records |> Enum.map(&Map.get(&1, :id)) |> Enum.sort
   end
 
+  defp json_map(attrs) do
+    attrs
+    |> Poison.encode!
+    |> Poison.decode!
+  end
+
   describe "list" do
     test "returns all records by default" do
       insert_list(3, :message)
@@ -249,15 +255,15 @@ defmodule CodeCorps.MessagesTest do
 
   describe "add_part/1" do
     test "creates a conversation part" do
-      conversation = insert(:conversation)
+      conversation = insert(:conversation, updated_at: Timex.now |> Timex.shift(minutes: -5))
       user = insert(:user)
       attrs = %{
         author_id: user.id,
         body: "Test body",
         conversation_id: conversation.id
       }
 
-      {:ok, %ConversationPart{} = conversation_part} = Messages.add_part(attrs)
+      {:ok, %ConversationPart{} = conversation_part} = Messages.add_part(attrs |> json_map())
 
       conversation_part =
         conversation_part
@@ -266,6 +272,7 @@ defmodule CodeCorps.MessagesTest do
       assert conversation_part.author_id == user.id
       assert conversation_part.body == "Test body"
       assert conversation_part.conversation_id == conversation.id
+      assert conversation_part.updated_at == conversation_part.conversation.updated_at
     end
 
     test "broadcasts event on phoenix channel" do
@@ -278,7 +285,7 @@ defmodule CodeCorps.MessagesTest do
       }
 
       CodeCorpsWeb.Endpoint.subscribe("conversation:#{conversation.id}")
-      {:ok, %ConversationPart{id: id}} = Messages.add_part(attrs)
+      {:ok, %ConversationPart{id: id}} = Messages.add_part(attrs |> json_map())
       assert_broadcast("new:conversation-part", %{id: ^id})
       CodeCorpsWeb.Endpoint.unsubscribe("conversation:#{conversation.id}")
     end
@@ -295,7 +302,7 @@ defmodule CodeCorps.MessagesTest do
         conversation_id: conversation.id
       }
 
-      {:ok, %ConversationPart{} = part} = Messages.add_part(attrs)
+      {:ok, %ConversationPart{} = part} = Messages.add_part(attrs |> json_map())
 
       part = part |> Repo.preload([:author, conversation: [message: [[project: :organization]]]])
 
@@ -317,7 +324,7 @@ defmodule CodeCorps.MessagesTest do
         conversation_id: conversation.id
       }
 
-      {:ok, %ConversationPart{} = part} = Messages.add_part(attrs)
+      {:ok, %ConversationPart{} = part} = Messages.add_part(attrs |> json_map())
 
       part = part |> Repo.preload([:author, conversation: [message: [[project: :organization]]]])