Merge pull request #1015 from code-corps/949-set-github-user-avatar

Set GitHub user's avatar

Author: joshsmith

lib/code_corps/accounts/accounts.ex

@@ -5,14 +5,15 @@ defmodule CodeCorps.Accounts do
   All actions to accounts should go through here.
   """
 
+  alias Task.Supervisor, as: TaskSupervisor
   alias CodeCorps.{
     Accounts.Changesets,
     Comment,
     GitHub.Adapters,
     GithubAppInstallation,
+    Task,
     User,
-    Repo,
-    Task
+    Repo
   }
   alias Ecto.{Changeset, Multi}
 
@@ -23,6 +24,16 @@ defmodule CodeCorps.Accounts do
   """
   @spec create_from_github(map) :: {:ok, User.t} | {:error, Changeset.t}
   def create_from_github(%{} = attrs) do
+    with {:ok, user} <- do_create_from_github(attrs) do
+      user |> upload_github_photo_async
+      {:ok, user}
+    else
+      error -> error
+    end
+  end
+
+  @spec do_create_from_github(map) :: {:ok, User.t} | {:error, Changeset.t}
+  defp do_create_from_github(%{} = attrs) do
     %User{}
     |> Changesets.create_from_github_changeset(attrs)
     |> Repo.insert
@@ -56,6 +67,20 @@ defmodule CodeCorps.Accounts do
     end
   end
 
+  defp upload_github_photo_async(%User{} = user) do
+    TaskSupervisor.start_child(:background_processor, fn -> upload_github_photo(user) end)
+  end
+
+  defp upload_github_photo(%User{github_avatar_url: github_avatar_url} = user) do
+    [ok: %Cloudex.UploadedImage{public_id: cloudinary_public_id}] =
+      github_avatar_url
+      |> CodeCorps.Cloudex.Uploader.upload()
+
+    user
+    |> Changeset.change(%{cloudinary_public_id: cloudinary_public_id})
+    |> Repo.update!
+  end
+
   @spec associate_installations(User.t) :: {:ok, list(GithubAppInstallation.t)}
   defp associate_installations(%User{id: user_id, github_id: github_id}) do
     updates = [set: [user_id: user_id]]

lib/code_corps/cloudex/cloudex_test.ex

@@ -13,4 +13,14 @@ defmodule CloudexTest do
       "https://placehold.it/500x500"
     end
   end
+
+  @spec upload(String.t) :: Cloudex.UploadedImage.t
+  def upload(_url) do
+    [ok: %Cloudex.UploadedImage{public_id: fake_cloudinary_id()}]
+  end
+
+  defp fake_cloudinary_id do
+    :crypto.strong_rand_bytes(5)
+    |> Base.encode64
+  end
 end

lib/code_corps/cloudex/uploader.ex

@@ -0,0 +1,8 @@
+defmodule CodeCorps.Cloudex.Uploader do
+
+  @cloudex Application.get_env(:code_corps, :cloudex)
+
+  def upload(url) do
+    @cloudex.upload(url)
+  end
+end

lib/code_corps/github/event/issues/user_linker.ex

@@ -17,7 +17,7 @@ defmodule CodeCorps.GitHub.Event.Issues.UserLinker do
   }
 
   @typep linking_result :: {:ok, User.t} |
-                           {:error, Ecto.Changeset.t}
+                           {:error, Ecto.Changeset.t} |
                            {:error, :multiple_users}
 
   @doc ~S"""
@@ -47,7 +47,8 @@ defmodule CodeCorps.GitHub.Event.Issues.UserLinker do
   defp match_users(
     %{
       "issue" => %{"number" => github_issue_number},
-      "repository" =>%{"id" => github_repo_id}}) do
+      "repository" =>%{"id" => github_repo_id}
+    }) do
 
     query = from u in User,
       distinct: u.id,

lib/code_corps/presenters/image_presenter.ex

@@ -2,13 +2,13 @@ defmodule CodeCorps.Presenters.ImagePresenter do
   alias CodeCorps.{Project, User}
   alias CodeCorps.Cloudex.CloudinaryUrl
 
-  @logo_options %{crop: "fill", height: 500, width: 500}
+  @large_options %{crop: "fill", height: 500, width: 500}
 
   def large(%Project{} = project), do: do_large(project, "project")
   def large(%User{} = user), do: do_large(user, "user")
 
   defp do_large(%{cloudinary_public_id: cloudinary_id, default_color: color}, type),
-    do: cloudinary_image(cloudinary_id, @logo_options, "large", color, type)
+    do: cloudinary_image(cloudinary_id, @large_options, "large", color, type)
 
   @thumb_options %{crop: "fill", height: 100, width: 100}
 

test/lib/code_corps/accounts/accounts_test.exs

@@ -1,6 +1,7 @@
 defmodule CodeCorps.AccountsTest do
   @moduledoc false
 
+  use CodeCorps.BackgroundProcessingCase
   use CodeCorps.DbAccessCase
 
   alias CodeCorps.{Accounts, User, GitHub.TestHelpers}
@@ -13,6 +14,8 @@ defmodule CodeCorps.AccountsTest do
         |> TestHelpers.load_endpoint_fixture
         |> Accounts.create_from_github
 
+      wait_for_supervisor()
+
       assert user.id
       assert user.default_color
       assert user.sign_up_context == "github"
@@ -29,8 +32,22 @@ defmodule CodeCorps.AccountsTest do
         payload
         |> Accounts.create_from_github
 
+      wait_for_supervisor()
+
       assert changeset.errors[:email] == {"has already been taken", []}
     end
+
+    test "uploads photo from GitHub avatar" do
+      {:ok, %User{} = user} =
+        "user"
+        |> TestHelpers.load_endpoint_fixture
+        |> Accounts.create_from_github
+
+      wait_for_supervisor()
+
+      user = Repo.get(User, user.id)
+      assert user.cloudinary_public_id
+    end
   end
 
   describe "update_from_github_oauth/3" do

test/lib/code_corps/cloudex/uploader_test.exs

@@ -0,0 +1,12 @@
+defmodule CodeCorps.Cloudex.UploaderTest do
+  alias CodeCorps.Cloudex.Uploader
+  use ExUnit.Case, async: true
+
+  test "returns the public_id" do
+    [ok: %Cloudex.UploadedImage{public_id: public_id}] =
+      "https://placehold.it/500x500"
+      |> Uploader.upload
+
+    assert public_id
+  end
+end