Merge pull request #1022 from code-corps/update-github-user-avatar

When updating user from Github, add avatar if none exists

Author: joshsmith

lib/code_corps/accounts/accounts.ex

@@ -61,15 +61,17 @@ defmodule CodeCorps.Accounts do
 
     case Repo.transaction(multi) do
       {:ok, %{user: %User{} = user, installations: installations}} ->
+        user |> upload_github_photo_async
         {:ok, user |> Map.put(:github_app_installations, installations)}
       {:error, :user, %Changeset{} = changeset, _actions_done} ->
         {:error, changeset}
     end
   end
 
-  defp upload_github_photo_async(%User{} = user) do
+  defp upload_github_photo_async(%User{cloudinary_public_id: nil} = user) do
     TaskSupervisor.start_child(:background_processor, fn -> upload_github_photo(user) end)
   end
+  defp upload_github_photo_async(%User{} = user), do: user
 
   defp upload_github_photo(%User{github_avatar_url: github_avatar_url} = user) do
     [ok: %Cloudex.UploadedImage{public_id: cloudinary_public_id}] =

test/lib/code_corps/accounts/accounts_test.exs

@@ -75,10 +75,40 @@ defmodule CodeCorps.AccountsTest do
         user
         |> Accounts.update_from_github_oauth(params, token)
 
+      wait_for_supervisor()
+
       assert user.id
       assert user.github_auth_token == token
       assert user.sign_up_context == "default"
       assert user.type == "user"
     end
+
+    test "does not update their image if it already exists" do
+      user = insert(:user, cloudinary_public_id: "123")
+      params = TestHelpers.load_endpoint_fixture("user")
+
+      {:ok, %User{} = user} =
+        user
+        |> Accounts.update_from_github_oauth(params, "random_token")
+
+      wait_for_supervisor()
+      user = Repo.get(User, user.id)
+
+      assert user.cloudinary_public_id === "123"
+    end
+
+    test "updates their image if does not exist" do
+      user = insert(:user, cloudinary_public_id: nil)
+      params = TestHelpers.load_endpoint_fixture("user")
+
+      {:ok, %User{} = user} =
+        user
+        |> Accounts.update_from_github_oauth(params, "random_token")
+
+      wait_for_supervisor()
+      user = Repo.get(User, user.id)
+
+      assert user.cloudinary_public_id
+    end
   end
 end