Merge pull request #615 from code-corps/remove-pagination-from-tasks

Remove pagination from tasks

Author: joshsmith

test/controllers/task_controller_test.exs

@@ -201,59 +201,4 @@ defmodule CodeCorps.TaskControllerTest do
       assert conn |> request_update |> json_response(403)
     end
   end
-
-  describe "pagination" do
-    test "specifying a page size works", %{conn: conn} do
-      project_1 = insert(:project)
-      user = insert(:user)
-      insert_list(3, :task, project: project_1, user: user)
-
-      path = conn |> task_path(:index)
-      json =
-        conn
-        |> get(path, page: %{page_size: 2})
-        |> json_response(200)
-
-      assert json["data"] |> Enum.count == 2
-    end
-
-    test "specifying a page number works", %{conn: conn} do
-      project_1 = insert(:project)
-      user = insert(:user)
-
-      insert_list(2, :task, project: project_1, user: user)
-      task_to_test = insert(:task, project: project_1, user: user)
-      insert(:task, project: project_1, user: user)
-
-      path = conn |> task_path(:index)
-      json =
-        conn
-        |> get(path, page: %{ page: 2, page_size: 2 })
-        |> json_response(200)
-
-      [ %{"id" => id} | _ ] = json["data"]
-
-      assert String.to_integer(id) == task_to_test.id
-    end
-
-    test "paginated results include a valid meta key", %{conn: conn} do
-      project_1 = insert(:project)
-      user = insert(:user)
-      insert_list(6, :task, project: project_1, user: user)
-
-      meta = %{
-        "total_records" => 6,
-        "total_pages" => 3,
-        "page_size" => 2,
-        "current_page" => 1,
-      }
-      path = conn |> task_path(:index)
-      json =
-        conn
-        |> get(path, page: %{ page_size: 2 })
-        |> json_response(200)
-
-      assert json["meta"] == meta
-    end
-  end
 end

web/controllers/task_controller.ex

@@ -14,30 +14,17 @@ defmodule CodeCorps.TaskController do
   plug JaResource
 
   def handle_index(conn, params) do
-    page = Task
-    |> project_filter(params)
-    |> task_list_filter(params)
-    |> task_type_filter(params)
-    |> task_status_filter(params)
-    |> sort_by_order
-    |> Repo.paginate(params["page"] || %{})
-
-    # TODO: Once we are able to more easily add top-level meta
-    # from within ja_resource or ja_serializer
-    # we can split up all of this into
-    # handle_index
-    # handle_index_query
-    # serialization_opts
-
-    meta = %{
-      current_page: page.page_number,
-      page_size: page.page_size,
-      total_pages: page.total_pages,
-      total_records: page.total_entries
-    }
+    tasks =
+      Task
+      |> project_filter(params)
+      |> task_list_filter(params)
+      |> task_type_filter(params)
+      |> task_status_filter(params)
+      |> sort_by_order
+      |> Repo.all
 
     conn
-    |> render("index.json-api", data: page, opts: [meta: meta])
+    |> render("index.json-api", data: tasks)
   end
 
   def record(%Plug.Conn{params: %{"project_id" => _project_id} = params}, _number_as_id) do