wip

Author: StanBarrows

.github/workflows/playwright.yml

@@ -38,7 +38,7 @@ jobs:
         uses: shivammathur/setup-php@v2
         with:
           php-version: '8.4'
-          extensions: dom, curl, libxml, mbstring, zip, pcntl, pdo, pdo_sqlite, bcmath, soap, intl, gd, exif, iconv
+          extensions: dom, curl, libxml, mbstring, zip, pcntl, pdo, pdo_sqlite, pdo_pgsql, bcmath, soap, intl, gd, exif, iconv
           coverage: none
 
       - name: "Run composer install"
@@ -47,6 +47,10 @@ jobs:
       - name: "Prepare Laravel Application"
         run: |
           cp .env.ci .env
+          echo "DB_HOST=127.0.0.1" >> .env
+          echo "DB_READ_HOST=127.0.0.1" >> .env
+          echo "DB_WRITE_HOST=127.0.0.1" >> .env
+          sleep 10
           php artisan key:generate
           php artisan passport:keys
           php artisan migrate --seed

CODE_OF_CONDUCT.md

@@ -103,15 +103,16 @@ public function update(Organization $organization, Client $client, ClientUpdateR
      */
     public function destroy(Organization $organization, Client $client): JsonResponse
     {
-        return response()->json(null, 204);
-
         $this->checkPermission($organization, 'clients:delete', $client);
 
+        return response()->json(null, 204);
+
         if ($client->projects()->exists()) {
             throw new EntityStillInUseApiException('client', 'project');
         }
 
         $client->delete();
 
+        return response()->json(null, 204);
     }
 }

app/Http/Controllers/Api/V1/ClientController.php

@@ -27,6 +27,7 @@ class ProjectController extends Controller
     protected function checkPermission(Organization $organization, string $permission, ?Project $project = null): void
     {
         parent::checkPermission($organization, $permission);
+
         if ($project !== null && $project->organization_id !== $organization->id) {
             throw new AuthorizationException('Project does not belong to organization');
         }
@@ -165,8 +166,6 @@ public function update(Organization $organization, Project $project, ProjectUpda
      */
     public function destroy(Organization $organization, Project $project): JsonResponse
     {
-        return response()->json(null, 204);
-
         $this->checkPermission($organization, 'projects:delete', $project);
 
         if ($project->tasks()->exists()) {
@@ -176,12 +175,15 @@ public function destroy(Organization $organization, Project $project): JsonRespo
             throw new EntityStillInUseApiException('project', 'time_entry');
         }
 
+        return response()->json(null, 204);
+
         DB::transaction(function () use (&$project): void {
             $project->members->each(function (ProjectMember $member): void {
                 $member->delete();
             });
             $project->delete();
         });
 
+        return response()->json(null, 204);
     }
 }