refactor: remove pre-macOS 11.0 fallback code paths

With the deployment target bumped to 11.0, remove all @available
guards for macOS 10.16/11.0 and their else branches:
- ScreenAuthStatus: use CGPreflightScreenCaptureAccess directly
- AskForScreenCaptureAccess: remove CGDisplayStreamCreate fallback
- PhotosAuthStatus: always use authorizationStatusForAccessLevel:
- AskForPhotosAccess: always use requestAuthorizationForAccessLevel:
- MusicLibraryAuthStatus: always use SKCloudServiceController
- AskForMusicLibraryAccess: remove pre-11.0 authorized fallback
- Remove API_AVAILABLE annotations that are now always satisfied

Also remove outdated README notes about pre-11.0 behavior.

Author: codebytere

README.md

@@ -75,15 +75,6 @@ Return Value Descriptions:
 - `limited` - The application is authorized for limited access to `type` data. Currently only applicable to the `photos` type.
 - 'provisional' - The application is provisionally authorized to access `type` data. Currently only applicable to the `notifications` type.
 
-**Notes:**
-
-- Access to `bluetooth` will always return a status of `authorized` prior to macOS 10.15, as the underlying API was not introduced until that version.
-- Access to `camera` and `microphone` will always return a status of `authorized` prior to macOS 10.14, as the underlying API was not introduced until that version.
-- Access to `input-monitoring` will always return a status of `authorized` prior to macOS 10.15, as the underlying API was not introduced until that version.
-- Access to `music-library` will always return a status of `authorized` prior to macOS 11.0, as the underlying API was not introduced until that version.
-- Access to `screen` will always return a status of `authorized` prior to macOS 10.15, as the underlying API was not introduced until that version.
-- Access to `speech-recognition` will always return a status of `authorized` prior to macOS 10.15, as the underlying API was not introduced until that version.
-
 Example:
 
 ```js
@@ -224,8 +215,6 @@ askForSpeechRecognitionAccess().then(status => {
 })
 ```
 
-**Note:** `status` will be resolved back as `authorized` prior to macOS 10.15, as the underlying API was not introduced until that version.
-
 ### `permissions.askForRemindersAccess()`
 
 Returns `Promise<String>` - Whether or not the request succeeded or failed; can be `authorized` or `denied`.
@@ -315,10 +304,6 @@ Your app must provide an explanation for its use of capture devices using the `N
 <string>Your reason for wanting to access the Camera</string>
 ```
 
-**Note:**
-
-- `status` will be resolved back as `authorized` prior to macOS 10.14, as the underlying API was not introduced until that version.
-
 Example:
 
 ```js
@@ -358,10 +343,6 @@ Checks the authorization status for input monitoring access. If the status check
 - `not determined` - A dialog will be displayed directing the user to the `Security & Privacy` System Preferences window , where the user can approve your app to monitor keyboard events in the background. The Promise is resolved as `denied`.
 - `denied` - The `Security & Privacy` System Preferences window is opened with the Input Monitoring privacy key highlighted. On open of the `Security & Privacy` window, the Promise is resolved as `denied`.
 
-**Note:**
-
-- `status` will be resolved back as `authorized` prior to macOS 10.15, as the underlying API was not introduced until that version.
-
 Example:
 
 ```js
@@ -389,10 +370,6 @@ Your app must provide an explanation for its use of capture devices using the `N
 <string>Your reason for wanting to access the Microphone</string>
 ```
 
-**Note:**
-
-- `status` will be resolved back as `authorized` prior to macOS 10.14, as the underlying API was not introduced until that version.
-
 Example:
 
 ```js
@@ -418,10 +395,6 @@ Your app must provide an explanation for its use of the music library using the
 <string>Your reason for wanting to access the user’s media library.</string>
 ```
 
-**Note:**
-
-- `status` will be resolved back as `authorized` prior to macOS 11.0, as the underlying API was not introduced until that version.
-
 Example:
 
 ```js

permissions.mm

@@ -57,8 +57,7 @@ bool IsValidBundleID(NSString *bundleID) {
   return kNotDetermined;
 }
 
-PHAccessLevel GetPHAccessLevel(const std::string &type)
-    API_AVAILABLE(macosx(10.16)) {
+PHAccessLevel GetPHAccessLevel(const std::string &type) {
   return type == "read-write" ? PHAccessLevelReadWrite : PHAccessLevelAddOnly;
 }
 
@@ -92,8 +91,7 @@ IOHIDRequestType GetInputMonitoringAccessType(const std::string &type) {
 }
 
 const std::string &
-StringFromMusicLibraryStatus(SKCloudServiceAuthorizationStatus status)
-    API_AVAILABLE(macosx(10.16)) {
+StringFromMusicLibraryStatus(SKCloudServiceAuthorizationStatus status) {
   switch (status) {
   case SKCloudServiceAuthorizationStatusAuthorized:
     return kAuthorized;
@@ -261,13 +259,9 @@ bool HasOpenSystemPreferencesDialog() {
 // Returns a status indicating whether the user has authorized Apple Music
 // Library access.
 std::string MusicLibraryAuthStatus() {
-  if (@available(macOS 10.16, *)) {
-    SKCloudServiceAuthorizationStatus status =
-        [SKCloudServiceController authorizationStatus];
-    return StringFromMusicLibraryStatus(status);
-  }
-
-  return kAuthorized;
+  SKCloudServiceAuthorizationStatus status =
+      [SKCloudServiceController authorizationStatus];
+  return StringFromMusicLibraryStatus(status);
 }
 
 // Returns a status indicating whether the user has authorized
@@ -321,48 +315,7 @@ bool HasOpenSystemPreferencesDialog() {
 // Returns a status indicating whether the user has authorized
 // Screen Capture access.
 std::string ScreenAuthStatus() {
-  std::string auth_status = kNotDetermined;
-  if (@available(macOS 11.0, *)) {
-    auth_status = CGPreflightScreenCaptureAccess() ? kAuthorized : kDenied;
-  } else {
-    auth_status = kDenied;
-    NSRunningApplication *runningApplication =
-        NSRunningApplication.currentApplication;
-    NSNumber *ourProcessIdentifier =
-        [NSNumber numberWithInteger:runningApplication.processIdentifier];
-
-    CFArrayRef windowList =
-        CGWindowListCopyWindowInfo(kCGWindowListOptionAll, kCGNullWindowID);
-    int numberOfWindows = CFArrayGetCount(windowList);
-    for (int index = 0; index < numberOfWindows; index++) {
-      // Get information for each window.
-      NSDictionary *windowInfo =
-          (NSDictionary *)CFArrayGetValueAtIndex(windowList, index);
-      NSString *windowName = windowInfo[(id)kCGWindowName];
-      NSNumber *processIdentifier = windowInfo[(id)kCGWindowOwnerPID];
-
-      // Don't check windows owned by the current process.
-      if (![processIdentifier isEqual:ourProcessIdentifier]) {
-        // Get process information for each window.
-        pid_t pid = processIdentifier.intValue;
-        NSRunningApplication *windowRunningApplication =
-            [NSRunningApplication runningApplicationWithProcessIdentifier:pid];
-        if (windowRunningApplication) {
-          NSString *windowExecutableName =
-              windowRunningApplication.executableURL.lastPathComponent;
-          if (windowName) {
-            if (![windowExecutableName isEqual:@"Dock"]) {
-              auth_status = kAuthorized;
-              break;
-            }
-          }
-        }
-      }
-    }
-    CFRelease(windowList);
-  }
-
-  return auth_status;
+  return CGPreflightScreenCaptureAccess() ? kAuthorized : kDenied;
 }
 
 // Returns a status indicating whether the user has authorized
@@ -433,15 +386,9 @@ bool HasOpenSystemPreferencesDialog() {
 // Returns a status indicating whether or not the user has authorized Photos
 // access.
 std::string PhotosAuthStatus(const std::string &access_level) {
-  PHAuthorizationStatus status = PHAuthorizationStatusNotDetermined;
-
-  if (@available(macOS 10.16, *)) {
-    PHAccessLevel level = GetPHAccessLevel(access_level);
-    status = [PHPhotoLibrary authorizationStatusForAccessLevel:level];
-  } else {
-    status = [PHPhotoLibrary authorizationStatus];
-  }
-
+  PHAccessLevel level = GetPHAccessLevel(access_level);
+  PHAuthorizationStatus status =
+      [PHPhotoLibrary authorizationStatusForAccessLevel:level];
   return StringFromPhotosStatus(status);
 }
 
@@ -720,22 +667,14 @@ void AskForFullDiskAccess(const Napi::CallbackInfo &info) {
   };
 
   if (auth_status == kNotDetermined) {
-    if (@available(macOS 10.16, *)) {
-      [PHPhotoLibrary
-          requestAuthorizationForAccessLevel:GetPHAccessLevel(access_level)
-                                     handler:^(PHAuthorizationStatus status) {
-                                       tsfn.BlockingCall(
-                                           StringFromPhotosStatus(status)
-                                               .c_str(),
-                                           callback);
-                                       tsfn.Release();
-                                     }];
-    } else {
-      [PHPhotoLibrary requestAuthorization:^(PHAuthorizationStatus status) {
-        tsfn.BlockingCall(StringFromPhotosStatus(status).c_str(), callback);
-        tsfn.Release();
-      }];
-    }
+    [PHPhotoLibrary
+        requestAuthorizationForAccessLevel:GetPHAccessLevel(access_level)
+                                   handler:^(PHAuthorizationStatus status) {
+                                     tsfn.BlockingCall(
+                                         StringFromPhotosStatus(status).c_str(),
+                                         callback);
+                                     tsfn.Release();
+                                   }];
   } else {
     if (auth_status == kDenied)
       OpenPrefPane("Privacy_Photos");
@@ -809,57 +748,33 @@ void AskForFullDiskAccess(const Napi::CallbackInfo &info) {
     deferred.Resolve(Napi::String::New(env, status));
   };
 
-  if (@available(macOS 10.16, *)) {
-    std::string auth_status = MusicLibraryAuthStatus();
-
-    if (auth_status == kNotDetermined) {
-      [SKCloudServiceController
-          requestAuthorization:^(SKCloudServiceAuthorizationStatus status) {
-            tsfn.BlockingCall(StringFromMusicLibraryStatus(status).c_str(),
-                              callback);
-            tsfn.Release();
-          }];
-    } else {
-      if (auth_status == kDenied)
-        OpenPrefPane("Privacy_Media");
+  std::string auth_status = MusicLibraryAuthStatus();
 
+  if (auth_status == kNotDetermined) {
+    [SKCloudServiceController requestAuthorization:^(
+                                  SKCloudServiceAuthorizationStatus status) {
+      tsfn.BlockingCall(StringFromMusicLibraryStatus(status).c_str(), callback);
       tsfn.Release();
-      deferred.Resolve(Napi::String::New(env, auth_status));
-    }
+    }];
   } else {
+    if (auth_status == kDenied)
+      OpenPrefPane("Privacy_Media");
+
     tsfn.Release();
-    deferred.Resolve(Napi::String::New(env, kAuthorized));
+    deferred.Resolve(Napi::String::New(env, auth_status));
   }
 
   return deferred.Promise();
 }
 
 // Request Screen Capture Access.
 void AskForScreenCaptureAccess(const Napi::CallbackInfo &info) {
-  if (@available(macOS 11.0, *)) {
-    if (CGPreflightScreenCaptureAccess() || CGRequestScreenCaptureAccess())
-      return;
+  if (CGPreflightScreenCaptureAccess() || CGRequestScreenCaptureAccess())
+    return;
 
-    bool should_force_prefs = info[0].As<Napi::Boolean>().Value();
-    if (should_force_prefs && !HasOpenSystemPreferencesDialog()) {
-      OpenPrefPane("Privacy_ScreenCapture");
-    }
-  } else {
-    // Tries to create a capture stream. This is necessary to add the app back
-    // to the list in sysprefs if the user previously denied.
-    // https://stackoverflow.com/questions/56597221/detecting-screen-recording-settings-on-macos-catalina
-    CGDisplayStreamRef stream = CGDisplayStreamCreate(
-        CGMainDisplayID(), 1, 1, kCVPixelFormatType_32BGRA, NULL,
-        ^(CGDisplayStreamFrameStatus status, uint64_t displayTime,
-          IOSurfaceRef frameSurface, CGDisplayStreamUpdateRef updateRef){
-        });
-
-    if (stream) {
-      CFRelease(stream);
-    } else {
-      if (!HasOpenSystemPreferencesDialog())
-        OpenPrefPane("Privacy_ScreenCapture");
-    }
+  bool should_force_prefs = info[0].As<Napi::Boolean>().Value();
+  if (should_force_prefs && !HasOpenSystemPreferencesDialog()) {
+    OpenPrefPane("Privacy_ScreenCapture");
   }
 }