Refactor anonymous functions to static

Signed-off-by: Tim Goudriaan <tim@codedmonkey.com>

Author: codedmonkey

bin/console

@@ -14,7 +14,7 @@ if (!is_file(dirname(__DIR__) . '/vendor/autoload_runtime.php')) {
 
 require_once dirname(__DIR__) . '/vendor/autoload_runtime.php';
 
-return function (array $context) {
+return static function (array $context) {
     $kernel = new Kernel($context['APP_ENV'], (bool) $context['APP_DEBUG']);
 
     return new Application($kernel);

bin/dirigent

@@ -14,7 +14,7 @@ if (!is_file(dirname(__DIR__) . '/vendor/autoload_runtime.php')) {
 
 require_once dirname(__DIR__) . '/vendor/autoload_runtime.php';
 
-return function (array $context) {
+return static function (array $context) {
     $kernel = new Kernel($context['APP_ENV'], (bool) $context['APP_DEBUG']);
 
     return new ConsoleApplication($kernel);

public/index.php

@@ -4,6 +4,6 @@
 
 require_once dirname(__DIR__) . '/vendor/autoload_runtime.php';
 
-return function (array $context) {
+return static function (array $context) {
     return new Kernel($context['APP_ENV'], (bool) $context['APP_DEBUG']);
 };

src/Controller/Dashboard/DashboardCredentialsController.php

@@ -36,7 +36,7 @@ public function configureFields(string $pageName): iterable
             ->setTemplatePath('dashboard/fields/credentials_type.html.twig')
             ->setRequired(true)
             ->setChoices(CredentialsType::cases())
-            ->setFormTypeOption('choice_label', function (CredentialsType $choice): string {
+            ->setFormTypeOption('choice_label', static function (CredentialsType $choice): string {
                 return "credentials.type.{$choice->value}";
             })
             ->renderExpanded();

src/Controller/Dashboard/DashboardRegistryController.php

@@ -69,7 +69,7 @@ public function configureFields(string $pageName): iterable
             ->setTemplatePath('dashboard/fields/registry_package_mirroring.html.twig')
             ->setRequired(true)
             ->setChoices(RegistryPackageMirroring::cases())
-            ->setFormTypeOption('choice_label', function (RegistryPackageMirroring $choice): string {
+            ->setFormTypeOption('choice_label', static function (RegistryPackageMirroring $choice): string {
                 return "registry.package-mirroring.{$choice->value}";
             })
             ->renderExpanded();

src/Doctrine/Entity/Version.php

@@ -718,7 +718,7 @@ public function toComposerArray(): array
         }
 
         if (isset($data['php-ext']['configure-options'])) {
-            usort($data['php-ext']['configure-options'], fn ($a, $b) => ($a['name'] ?? '') <=> ($b['name'] ?? ''));
+            usort($data['php-ext']['configure-options'], static fn ($a, $b) => ($a['name'] ?? '') <=> ($b['name'] ?? ''));
         }
 
         return $data;

src/Doctrine/Repository/PackageRepository.php

@@ -166,7 +166,7 @@ public function updatePackageLinks(Package $package, Version $version): void
     public function deletePackageLinks(Package $package): void
     {
         $connection = $this->getEntityManager()->getConnection();
-        $connection->transactional(function (Connection $connection) use ($package) {
+        $connection->transactional(static function (Connection $connection) use ($package) {
             $queryParameters = ['id' => $package->getId()];
 
             $connection->executeStatement('DELETE FROM package_provide_link WHERE package_id = :id', $queryParameters);

src/Encryption/Encryption.php

@@ -58,15 +58,15 @@ public static function create(
             $privateKey = $filesystem->readFile($privateKeyPath);
             $publicKey = $filesystem->readFile($publicKeyPath);
             $rotatedKeys = array_map(
-                fn (string $rotatedKeyPath): string => $filesystem->readFile($rotatedKeyPath),
+                static fn (string $rotatedKeyPath): string => $filesystem->readFile($rotatedKeyPath),
                 $rotatedKeyPaths
             );
         }
 
         $binaryPrivateKey = sodium_hex2bin($privateKey);
         $binaryPublicKey = sodium_hex2bin($publicKey);
         $binaryRotatedKeys = array_map(
-            fn (string $rotatedKey): string => sodium_hex2bin($rotatedKey),
+            static fn (string $rotatedKey): string => sodium_hex2bin($rotatedKey),
             $rotatedKeys,
         );
 

src/Form/NewPasswordType.php

@@ -22,15 +22,15 @@ public function configureOptions(OptionsResolver $resolver): void
             'options' => [
                 'attr' => ['autocomplete' => 'new-password'],
             ],
-            'first_options' => function (Options $options): array {
+            'first_options' => static function (Options $options): array {
                 $label = $options['new_password'] ? 'New password' : 'Password';
 
                 return [
                     'constraints' => self::constraints(false),
                     'label' => $label,
                 ];
             },
-            'second_options' => function (Options $options): array {
+            'second_options' => static function (Options $options): array {
                 $label = $options['new_password'] ? 'Repeat new password' : 'Repeat password';
 
                 return [

src/Form/PackageAddMirroringFormType.php

@@ -17,7 +17,7 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
             ->add('packages', TextareaType::class)
             ->add('registry', EntityType::class, [
                 'class' => Registry::class,
-                'query_builder' => function (RegistryRepository $repository) {
+                'query_builder' => static function (RegistryRepository $repository) {
                     return $repository->createPackageMirroringQueryBuilder('manual');
                 },
             ]);