Use equalsIgnoreCase for string compare

jschroeder-avi · jschroeder-avi · commit 1823e556c610 · 2019-03-15T16:20:40.000-04:00
diff --git a/src/main/java/com/codedx/plugins/bamboo/security/FingerprintStrategy.java b/src/main/java/com/codedx/plugins/bamboo/security/FingerprintStrategy.java
@@ -29,7 +29,7 @@ public CertificateAcceptance checkAcceptance(Certificate genericCert, Certificat
 				String certFingerprint = toHexString(getSHA1(cert.getEncoded()));
 				logger.info("Certificate fingerprint:  " + certFingerprint.toUpperCase());
 				logger.info("User-entered fingerprint: " + fingerprint.toUpperCase());
-				if (certFingerprint.toUpperCase().equals(fingerprint.toUpperCase())) {
+				if (certFingerprint.equalsIgnoreCase(fingerprint)) {
 					return CertificateAcceptance.ACCEPT_PERMANENTLY;
 				}
 			} catch (CertificateEncodingException exception) {

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public CertificateAcceptance checkAcceptance(Certificate genericCert, Certificat`
`29`	`29`	`String certFingerprint = toHexString(getSHA1(cert.getEncoded()));`
`30`	`30`	`logger.info("Certificate fingerprint: " + certFingerprint.toUpperCase());`
`31`	`31`	`logger.info("User-entered fingerprint: " + fingerprint.toUpperCase());`
`32`		`- if (certFingerprint.toUpperCase().equals(fingerprint.toUpperCase())) {`
	`32`	`+ if (certFingerprint.equalsIgnoreCase(fingerprint)) {`
`33`	`33`	`return CertificateAcceptance.ACCEPT_PERMANENTLY;`
`34`	`34`	`}`
`35`	`35`	`} catch (CertificateEncodingException exception) {`